amadan
Task 12: the site drops its copies, red then green open
On branch fiesta-1-1
Commit dfd1f04. Every test here is an adapted preservation test: names and assertions are unchanged, and only the selectors that named the site's classes moved.
.site-copyto[rst-snippet-copy]#install .site-liveto#install [rst-snippet-status]#sample .site-side ato#sample [rst-side-nav] a[data-site-theme][aria-current]to[data-site-theme][aria-pressed="true"]
Red: the adapted selectors against the unchanged page (504874e's template, site.css and site.js; /1/ is releases/1.1.0):
./hack/gotest.sh browser internal.www -run '^(TestTheLandingHasNoHorizontalScrollAt320|TestTheLandingReadsWithNoScript|TestABrokenStoredThemeFallsBackToDay|TestEverySamplePaneAndCourseSwitches|TestTheSampleFormsStayOnThePage|TestTheSampleSwitchDrags|TestCopy)$' -v
landingbrowsertest.go:316: /: #sample [rst-side-nav] a: 0 on the page; want 5. This is not the landing page, and measuring it would prove nothing --- FAIL: TestTheLandingHasNoHorizontalScrollAt320 (5.89s) landingbrowsertest.go:432: [rst-snippet-copy]: 0 on the page, 0 shown; want 1 hidden with scripts off --- FAIL: TestTheLandingReadsWithNoScript (5.93s) landingbrowsertest.go:651: with "bogus" stored the page loads "/1/fiesta.css" and marks ""; want /1/fiesta.css and day landingbrowsertest.go:651: with "constructor" stored the page loads "/1/fiesta.css" and marks ""; want /1/fiesta.css and day landingbrowsertest.go:651: with "_proto" stored the page loads "/1/fiesta.css" and marks ""; want /1/fiesta.css and day landingbrowsertest.go:651: with "toString" stored the page loads "/1/fiesta.css" and marks ""; want /1/fiesta.css and day landingbrowsertest.go:651: with "DAY" stored the page loads "/1/fiesta.css" and marks ""; want /1/fiesta.css and day landingbrowsertest.go:651: with "" stored the page loads "/1/fiesta.css" and marks ""; want /1/fiesta.css and day landingbrowsertest.go:660: with a storage that throws the page loads "/1/fiesta.css" and marks ""; want /1/fiesta.css and day --- FAIL: TestABrokenStoredThemeFallsBackToDay (6.85s) landingbrowsertest.go:699: the sample opens showing [pane-overview] with [] current; want pane-overview alone --- FAIL: TestEverySamplePaneAndCourseSwitches (5.87s) landingbrowsertest.go:747: context deadline exceeded --- FAIL: TestTheSampleFormsStayOnThePage (125.61s) landingbrowsertest.go:810: context deadline exceeded --- FAIL: TestTheSampleSwitchDrags (125.64s) landingbrowser_test.go:871: [rst-snippet-copy] never became visible: context deadline exceeded --- FAIL: TestCopy (15.90s) FAIL FAIL amadan.net/rastrillo/fiesta/internal/www 291.733s FAIL
The two 125 s timeouts are showPane waiting to click #sample [rst-side-nav] a[href=...], which is not on the unchanged page.
Green: the same seven after the change
--- PASS: TestTheLandingHasNoHorizontalScrollAt320 (7.86s) --- PASS: TestTheLandingReadsWithNoScript (6.11s) --- PASS: TestABrokenStoredThemeFallsBackToDay (7.46s) --- PASS: TestEverySamplePaneAndCourseSwitches (6.36s) --- PASS: TestTheSampleFormsStayOnThePage (7.51s) --- PASS: TestTheSampleSwitchDrags (7.01s) --- PASS: TestCopy (9.21s) ok amadan.net/rastrillo/fiesta/internal/www 51.550s
The whole package, after the change:
go test ./internal/www -count=1 ok (89.5 s) ./hack/gotest.sh browser internal.www ok (217.5 s) go test . ./cmd/... -count=1 ok
Screenshots of the landing page at 1280 and 390, LTR and RTL, with the Guests pane for the inline statuses, before and after: /home/paulca/.cache/fiesta-1-1-task-12/shots/ and shots-before/ on docs-t1. They are scratch and will be removed once the report is read.