amadan
Astra's two fixes: 4ac98b3 (footer panels held to the row's inline end) and 4306038 (the column preview rests short and grows while a menu is open). Hub CI passed on 4306038, all 48 shards (suite step 103 s).
1. The panel's inline end is the row's
The strengthened TestTheFootersMenusOpenOnScreen passes against the footer's CSS, as it should, so it counts as already passing. Mutation: .rst-page__foot .rst-dropdown__menu, [rst-page-foot] [rst-dropdown-menu] { inset-inline-end: auto; inset-inline-start: 0; } appended to tokens.css. The old test stayed green under it:
gotest: ./check/ runs its 216 browser tests
ok amadan.net/rastrillo/fiesta/check 3.539sThe new test is red in 32 places: both no-anchor legs × both sizes × LTR/RTL × both spellings × both menus. The first lines:
--- FAIL: TestTheFootersMenusOpenOnScreen (4.75s)
--- FAIL: TestTheFootersMenusOpenOnScreen/no_anchor_positioning,_anchor.js (1.60s)
footer_browser_test.go:346: /ltr at 390x640, rst-locale: the panel's inline end is at 202.0 and the row's at 359.0; without anchoring every panel opens flush with the row's inline end
footer_browser_test.go:346: /ltr at 390x640, rst-scheme: the panel's inline end is at 202.0 and the row's at 359.0; without anchoring every panel opens flush with the row's inline end
footer_browser_test.go:346: /rtl at 390x640, rst-locale: the panel's inline end is at 173.0 and the row's at 16.0; without anchoring every panel opens flush with the row's inline end
footer_browser_test.go:346: /rtl at 390x640, rst-scheme: the panel's inline end is at 173.0 and the row's at 16.0; without anchoring every panel opens flush with the row's inline end
footer_browser_test.go:346: /ltr-class at 390x640, rst-locale: the panel's inline end is at 202.0 and the row's at 359.0; without anchoring every panel opens flush with the row's inline end
footer_browser_test.go:346: /ltr-class at 390x640, rst-scheme: the panel's inline end is at 202.0 and the row's at 359.0; without anchoring every panel opens flush with the row's inline end
footer_browser_test.go:346: /rtl-class at 390x640, rst-locale: the panel's inline end is at 173.0 and the row's at 16.0; without anchoring every panel opens flush with the row's inline end
footer_browser_test.go:346: /rtl-class at 390x640, rst-scheme: the panel's inline end is at 173.0 and the row's at 16.0; without anchoring every panel opens flush with the row's inline end
footer_browser_test.go:346: /ltr at 320x568, rst-locale: the panel's inline end is at 202.0 and the row's at 289.0; without anchoring every panel opens flush with the row's inline end
footer_browser_test.go:346: /ltr at 320x568, rst-scheme: the panel's inline end is at 202.0 and the row's at 289.0; without anchoring every panel opens flush with the row's inline end
footer_browser_test.go:346: /rtl at 320x568, rst-locale: the panel's inline end is at 103.0 and the row's at 16.0; without anchoring every panel opens flush with the row's inline end
footer_browser_test.go:346: /rtl at 320x568, rst-scheme: the panel's inline end is at 103.0 and the row's at 16.0; without anchoring every panel opens flush with the row's inline end2. Rest and open heights for the column preview
Red before the change, against a stub of the rest table:
--- FAIL: TestTheColumnPreviewRestsShorterThanItOpens (0.00s)
heights_test.go:20: layout-column/default has no rest height; its box holds the open footer menus at rest
FAIL
FAIL amadan.net/rastrillo/fiesta/internal/gallery 0.004s
FAILWith the rest entry and style written but no view.js or view.css change:
gotest: on DOCS-T1, driving the harness's own choice (/usr/bin/chromium)
gotest: ./internal/gallery/ runs its 84 browser tests
--- FAIL: TestTheColumnPreviewGrowsOnlyWhileAMenuIsOpen (6.72s)
heights_browser_test.go:802: en/layout-column.html: 1 frames settled; the page requested 1 frame documents
heights_browser_test.go:813: en/layout-column.html Desktop at rest: the frame is 920px tall, want 640
heights_browser_test.go:819: en/layout-column.html Desktop with both closed again: the frame is 920px tall, want 640
heights_browser_test.go:813: en/layout-column.html Mobile at rest: the frame is 1330px tall, want 1110
heights_browser_test.go:819: en/layout-column.html Mobile with both closed again: the frame is 1330px tall, want 1110
FAIL
FAIL amadan.net/rastrillo/fiesta/internal/gallery 6.748s
FAILGreen: the whole internal/gallery browser package (./hack/gotest.sh browser internal.gallery):
ok amadan.net/rastrillo/fiesta/internal/gallery 706.987sCalibration: a scratch sweep of layout-column.html over all twelve locales (FIESTA_SWEEP=full, pages cut to the column). Rest needs at most 621 px on Desktop (ga) and 1085 px on a 320px phone (es, pt-PT), so the rest heights are Desktop 650 and Mobile 1110. Open needs fit the existing open heights in every locale; es and pt-PT need 1327 of 1330.
Mutations, each in a scratch worktree, each reverted:
R1, view.js without the toggle listener:
--- FAIL: TestTheColumnPreviewGrowsOnlyWhileAMenuIsOpen (6.69s)
heights_browser_test.go:858: en/layout-column.html Desktop with both closed again: the frame is 920px tall, want 650
heights_browser_test.go:852: en/layout-column.html Mobile at rest: the frame is 1330px tall, want 1110
heights_browser_test.go:858: en/layout-column.html Mobile with both closed again: the frame is 1330px tall, want 1110R2, the view.css rest rule deleted:
--- FAIL: TestTheColumnPreviewGrowsOnlyWhileAMenuIsOpen (6.74s)
heights_browser_test.go:852: en/layout-column.html Desktop at rest: the frame is 920px tall, want 650
heights_browser_test.go:858: en/layout-column.html Desktop with both closed again: the frame is 920px tall, want 650
heights_browser_test.go:852: en/layout-column.html Mobile at rest: the frame is 1330px tall, want 1110
heights_browser_test.go:858: en/layout-column.html Mobile with both closed again: the frame is 1330px tall, want 1110R3, the rest rule keyed on the style instead of the script's mark:
--- FAIL: TestTheColumnPreviewGrowsOnlyWhileAMenuIsOpen (6.68s)
heights_browser_test.go:854: en/layout-column.html Desktop with Language open: the frame is 650px tall, want 920
heights_browser_test.go:856: en/layout-column.html Desktop with Colour scheme opened over Language: the frame is 650px tall, want 920
heights_browser_test.go:854: en/layout-column.html Mobile with Language open: the frame is 1110px tall, want 1330
heights_browser_test.go:856: en/layout-column.html Mobile with Colour scheme opened over Language: the frame is 1110px tall, want 1330
heights_browser_test.go:868: en/layout-column.html, scripts off: the frame is 650px tall, want the open height 920, since nothing can grow it when a menu opensD1, the rest Desktop height 650 changed to 540:
--- FAIL: TestPreviewFrameHeightsFitTheirContent1of3 (32.85s)
heights_browser_test.go:584: en/modal.html at 1500px Desktop modal/default: 620px of frame for 144px of document; deliberate headroom, or a number to bring down
heights_browser_test.go:605: en/modal.html at 1500px Mobile modal/default: 775px of frame for 155px of document; deliberate headroom, or a number to bring down
heights_browser_test.go:584: en/layout-column.html at 1500px Desktop layout-column/default: its document needs 600px and its frame is 540px; raise its height (previewHeights for Desktop, previewMobileHeights or previewMobileLocaleHeight
heights_browser_test.go:631: part 1: 25 pages, 57 frames measured and 10 opened over 1 locale(s); 1 short (enforced: true; the Overview's demo read here: true)D4, the rest Mobile height 1110 changed to 1000:
--- FAIL: TestPreviewFrameHeightsFitAtThePhonesNarrowest7of12 (27.45s)
heights_browser_test.go:745: en/layout-column.html at 320px layout-column/default: its document needs 1065px and its frame is 1000px; raise its height (previewHeights for Desktop, previewMobileHeights or previewMobileLocaleHeights for M
heights_browser_test.go:745: ru/locale-menu.html at 320px locale-menu/twelve-languages-current-highlighted: 525px of frame for 76px of document; deliberate headroom, or a number to bring down
heights_browser_test.go:784: part 7: 24 pages, 50 frames measured and 10 opened at 320px over 4 locale(s), 0 sidebar shells given grace; 1 short (enforced: true)
heights_browser_test.go:786: Mobile entries to raise, as locale key: height:D2, the open Desktop height 920 changed to 700:
--- FAIL: TestPreviewFrameHeightsFitTheirContent1of3 (32.51s)
heights_browser_test.go:584: en/modal.html at 1500px Desktop modal/default: 620px of frame for 144px of document; deliberate headroom, or a number to bring down
heights_browser_test.go:605: en/modal.html at 1500px Mobile modal/default: 775px of frame for 155px of document; deliberate headroom, or a number to bring down
heights_browser_test.go:592: en/layout-column.html at 1500px Desktop with its menu (div[rst-dropdown-menu]) open layout-column/default: its document needs 894px and its frame is 700px; raise its height (previewHeights for Desktop, previ
heights_browser_test.go:631: part 1: 25 pages, 57 frames measured and 10 opened over 1 locale(s); 1 short (enforced: true; the Overview's demo read here: true)D3, view.js never marks a widget at rest:
--- FAIL: TestPreviewFrameHeightsFitTheirContent1of3 (25.21s)
heights_browser_test.go:584: en/modal.html at 1500px Desktop modal/default: 620px of frame for 144px of document; deliberate headroom, or a number to bring down
heights_browser_test.go:605: en/modal.html at 1500px Mobile modal/default: 775px of frame for 155px of document; deliberate headroom, or a number to bring down
heights_browser_test.go:576: en/layout-column.html at 1500px Desktop layout-column/default: view.js has the widget at rest false, and previewRestHeights says it has a rest height true; the readings would be of the wrong box(The rest Desktop height at 560 passed the wide drive, which grants every frame 48px at rest: 600 ≤ 560 + 48. 540 is the real shortfall.)