oficina / slides Public

Fix the local sign-in page copy

Paul Campbell pushed by paul@keymail.dev cb53f56c0f316d60c6304133a078b03c5f7894a1 parent 2cc4316
2 files changed, +1 −2
  • internal/slides/auth.go +0 −1
  • internal/slidestest/signin_test.go +1 −1

CI failed — run details

CI log
=== gate ===
=== rust: fmt
=== rust: clippy
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.18s
=== wasm: the artifact the host embeds
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.06s
    Finished `release` profile [optimized] target(s) in 0.22s
core/target/wasm32-unknown-unknown/release/slides_core.wasm (1228229 bytes)
=== the embedded wasm must match a fresh build
=== rust: test
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.07s
     Running unittests src/lib.rs (core/target/debug/deps/slides_core-929bfceb2edd4a94)

running 30 tests
test layout::tests::media_region_rect ... ok
test layout::tests::body_region_rect_narrows_for_an_aside ... ok
test layout::tests::heading_region_rect ... ok
test layout::tests::default_region_by_kind ... ok
test check::tests::the_empty_document_passes ... ok
test layout::tests::aside_region_rect ... ok
test layout::tests::to_canvas_narrows_body_when_an_aside_is_present ... ok
test check::tests::an_element_inside_a_paragraph_is_reported ... ok
test check::tests::bare_text_at_fragment_level_is_reported ... ok
test check::tests::what_the_ops_write_passes ... ok
test check::tests::a_non_paragraph_child_is_reported ... ok
test layout::tests::to_flow_keeps_a_concurrent_text_edit ... ok
test check::tests::y_prosemirror_shapes_pass ... ok
test markdown::tests::inline_marks ... ok
test schema::tests::an_href_map_without_a_string_url_reads_as_no_link ... ok
test layout::tests::to_flow_is_a_no_op_when_already_in_order ... ok
test layout::tests::to_flow_classifies_by_position_and_kind ... ok
test schema::tests::href_written_as_a_plain_string_still_reads_back ... ok
test check::tests::an_unknown_formatting_attribute_is_reported ... ok
test markdown::tests::marks_nest_and_links_carry_marks ... ok
test markdown::tests::empty_input_is_no_paragraphs_and_lines_keep_blanks ... ok
test schema::tests::an_empty_map_reads_as_a_set_mark ... ok
test layout::tests::to_flow_orders_y_then_x ... ok
test schema::tests::href_is_written_as_a_one_key_map_and_reads_back ... ok
test layout::tests::to_canvas_splits_a_shared_region_equally_and_sets_z_by_index ... ok
test view::tests::malformed_box_is_null_and_phone_keeps_only_typed_fields ... ok
test view::tests::assets_are_typed_or_skipped ... ok
test view::tests::malformed_fonts_are_null ... ok
test markdown::tests::paragraphs_split_on_blank_lines_and_list_markers ... ok
test view::tests::malformed_background_is_the_default ... ok

test result: ok. 30 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

     Running tests/no_host_imports.rs (core/target/debug/deps/no_host_imports-184c0d8bf00e14f9)

running 1 test
test no_host_imports ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/ops.rs (core/target/debug/deps/ops-256addce27f366d1)

running 12 tests
test add_block_with_markdown_produces_runs ... ok
test columns_children_must_name_blocks_on_the_slide ... ok
test add_slide_then_view_lists_it ... ok
test remove_block_drops_it_from_columns_children ... ok
test columns_children_have_one_parent_and_no_cycles ... ok
test update_roundtrip ... ok
test move_slide_keeps_a_concurrent_text_edit ... ok
test ops_are_atomic ... ok
test duplicate_slide_remaps_columns_children ... ok
test move_block_keeps_a_concurrent_text_edit ... ok
test layout_switch_assigns_boxes ... ok
test remaining_ops_roundtrip ... ok

test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.03s

   Doc-tests slides_core

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

=== rust: fmt (pdf)
=== rust: clippy (pdf)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.15s
=== wasm: the pdf artifact the host embeds
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.04s
    Finished `release` profile [optimized] target(s) in 0.07s
core/pdf/target/wasm32-unknown-unknown/release/slides_pdf.wasm (5301002 bytes)
=== the embedded pdf wasm must match a fresh build
=== rust: test (pdf)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 0.03s
     Running unittests src/lib.rs (core/pdf/target/debug/deps/slides_pdf-891fafaa44f9fd64)

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/no_host_imports.rs (core/pdf/target/debug/deps/no_host_imports-17ccbb1d62120093)

running 1 test
test no_host_imports ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

     Running tests/render.rs (core/pdf/target/debug/deps/render-2e1d7e8b19d78595)

running 6 tests
test a_null_zero_length_pair_is_no_frames_not_a_dereference ... ok
test text_with_no_fonts_at_all_still_renders_the_shapes ... ok
test raster_image_is_embedded ... ok
test abi_frames_round_trip ... ok
test renders_text_as_embedded_glyphs ... ok
test two_svgs_make_two_pages ... ok

test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s

   Doc-tests slides_pdf

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

=== fixtures: node dependencies
v24.19.0
11.17.0
=== fixtures: npm ci (needs the registry — see .amadan/README.md)

added 19 packages, and audited 20 packages in 549ms

5 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities
npm warn allow-scripts 1 package has install scripts not yet covered by allowScripts:
npm warn allow-scripts   esbuild@0.28.2 (postinstall: node install.js)
npm warn allow-scripts
npm warn allow-scripts Run `npm approve-scripts --allow-scripts-pending` to review, or `npm approve-scripts <pkg>` to allow.
=== fixtures: the JS side's own tests
✔ one finished upload is register_asset plus the block that uses it, in one batch (32.187863ms)
✔ a record missing its numbers still makes an op the core accepts (1.812182ms)
✔ unusedAssets is what no slide refers to, and remove_asset drops one (3.97828ms)
✔ the Unused images list reconciles by id and names each Remove button (1.177938ms)
✔ an upload refusal is said in words the person can act on (0.291599ms)
✔ clampBox keeps the box inside the frame and no smaller than the minimum (2.162171ms)
✔ fixBox writes four decimals (0.346061ms)
✔ guides are the thirds plus every other block edge (0.301808ms)
✔ snapMove pulls the nearest edge onto a guide within one per cent, and leaves a far one (0.627232ms)
✔ snapResize moves only the edges the handle drags (0.313731ms)
✔ moveBox and resizeBox by handle (0.319983ms)
✔ nudge: arrows move by half a per cent, Shift by two, Alt resizes (0.263076ms)
✔ rectBox reads a block rectangle against its frame (0.311887ms)
✔ typing into a block is a text change on its slide only (10.340209ms)
✔ a block's props changing is structure on its slide (1.80579ms)
✔ adding, moving or removing a block is structure on its slide (2.20929ms)
✔ the notes are text on their slide (1.228363ms)
✔ a slide added, removed or moved is an order change (1.252057ms)
✔ one transaction touching several things reports each once (0.962823ms)
✔ what the ops write passes, and so does an empty document (14.763817ms)
✔ the shapes y-prosemirror and older documents write pass (2.025603ms)
✔ an unknown formatting attribute is reported with the core's message (2.335287ms)
✔ an element inside a paragraph, a non-paragraph child and bare text are reported (3.423597ms)
✔ the unknownmark poison shape is what the check refuses (1.915737ms)
✔ y-prosemirror 1.3.7 deletes the words under an unknown mark; sanitising first keeps them (5.611775ms)
✔ the vocabulary is the five marks and nothing else (0.183555ms)
✔ a reload reuses the id this tab stored for the deck (1.096124ms)
✔ two tabs, and two decks in one tab, get different ids (1.103618ms)
✔ a stored value that is not an id, or storage that throws, gives a fresh id (0.407427ms)
✔ a duplicated tab gives up the copied id; the original keeps it (6.579217ms)
✔ a reload finds no rival and keeps its id (9.313546ms)
✔ presence switches id: beats carry the new one and the old one is somebody else (1.546121ms)
✔ an empty body is no frames (1.48169ms)
✔ frames come back in order with their exact bytes (0.365167ms)
✔ a length prefix is big-endian (0.208322ms)
✔ a truncated frame throws rather than returning a short update (1.841918ms)
✔ deck controls are set_meta (27.034912ms)
✔ slide controls are set_slide, and background keeps its colour (5.089151ms)
✔ move up and down are move_slide with the right after (1.909836ms)
✔ block props: value kinds, region, a shape label (6.498014ms)
✔ box fields are set_block on the desktop and set_phone in the phone view (6.94768ms)
✔ move block and the layer buttons (2.855026ms)
✔ add block: region after the selection on flow, a default box on canvas, a heading level that fits (7.463722ms)
✔ a block is named by its type and its first words (1.254052ms)
✔ blockChange: a control element to its op (1.690393ms)
✔ the Blocks list reconciles by id and keeps its buttons (1.244093ms)
✔ open resolves to the button that closed it and the trimmed field (1.804708ms)
✔ a second open while the dialog is up joins the first (0.251524ms)
✔ a missing dialog mounts as nothing (0.169519ms)
✔ a tab advances its own cursor only when its POST is the very next row (2.993766ms)
✔ the cursor never moves backwards when a response is overtaken by this tab's own write (0.596032ms)
✔ a later response still carries the cursor forward (0.332897ms)
✔ a burst of notifications collapses into one fetch at a time (0.289626ms)
✔ an event naming a seq the tab already has fetches nothing (0.208272ms)
✔ a stopped subscriber drops a response that arrives late (0.462711ms)
✔ stop closes the stream, and start opens exactly one (0.309953ms)
✔ a hidden tab closes its stream on a shortened deadline, and activity reopens it (0.992779ms)
✔ switching away and back inside the grace never drops the stream, so nothing has to be caught up (0.682986ms)
✔ a visible tab that is only being READ closes when idle and comes back on any activity (0.988081ms)
✔ activity while streaming defers the idle close rather than reopening anything (0.250642ms)
✔ a stream failure is never reported as a save failure, and heals on activity (0.243849ms)
✔ an empty response advances the cursor without applying anything (0.310083ms)
✔ a failed fetch leaves the cursor alone so the next notification retries it (0.233249ms)
✔ a decode failure retries once through the raw log, then gives up (1.355232ms)
✔ updatesURL spells the query string exactly, in particular raw as the literal raw=1 (1.994245ms)
✔ empty_doc_views_as_defaults (4.907539ms)
✔ set_meta (3.498657ms)
✔ slides: add, move, remove, set_slide, set_notes (6.72911ms)
✔ duplicate_slide (3.605248ms)
✔ blocks: add, move, remove, set_block (3.223028ms)
✔ set_phone (1.443649ms)
✔ table cells follow rows and cols (1.389967ms)
✔ canvas blocks: box defaults from the region, z from the index (0.995394ms)
✔ assets: register and remove (0.886399ms)
✔ markdown: every mark, code blocks are plain lines (7.156104ms)
✔ batch_is_atomic (2.35341ms)
✔ a batch applies in one transaction with the given origin (0.705147ms)
✔ columns_children_validated (1.772458ms)
✔ layout_switch_round_trip (1.844723ms)
✔ view_matches_snapshot_fixtures (15.607917ms)
✔ columns children have one parent and no cycles (codex 7) (1.002167ms)
✔ canvas-to-flow keeps a concurrent text edit (codex 4) (2.919036ms)
✔ move_block keeps a concurrent text edit, and later inserts land where after says (codex 4) (3.079047ms)
✔ move_slide keeps a concurrent text edit, and later inserts land where after says (codex 4 at slide level) (2.677091ms)
✔ format: {name} and {n} interpolate; an unknown key is left as text (0.938808ms)
✔ a beat on connect, then one every twenty seconds (2.310831ms)
✔ a move posts once, 200ms after the last of a burst, and re-arms the beat (3.220263ms)
✔ a hidden tab stops beating; coming back posts at once (0.307759ms)
✔ applySet leaves this tab out and answers what changed (0.544194ms)
✔ a set with rubbish in it is read for what it does carry (0.263776ms)
✔ initials, and a client id per tab (3.477999ms)
✔ a resync that fails is retried with backoff until it succeeds, without ever running twice at once (2.007128ms)
✔ the browser's online event retries immediately, not just on the next backoff tick (0.317628ms)
✔ reportDivergence before any failure runs the first attempt without a caller ever calling online (1.554748ms)
✔ a permanent 4xx drops its batch instead of retrying it, and does not poison the next edit (84.392182ms)
✔ a network failure or a 5xx is retried, not dropped (60.767031ms)
✔ a 500 is retried the same way a network failure is, never dropped (60.521909ms)
✔ the core-written structure reads as ProseMirror marks (18.823019ms)
✔ a y-prosemirror round trip preserves bold and the link (3.067055ms)
✔ y-prosemirror writes href as the one-key map and marks as {} (0.904604ms)
✔ a plain-string href, written before the map shape, still reads (0.64268ms)
✔ textFragment writes the same shape as writeText (0.641618ms)
✔ safeHref is the server allowlist, and a disallowed href never draws an anchor (0.395214ms)
✔ parseHash splits the slide and the block, and survives a stray % (7.408098ms)
✔ destroy takes the listeners off, and a second mount leaves one of each (0.75987ms)
✔ formatHash is the inverse (6.158174ms)
✔ textBlocks finds the text-bearing blocks and skips the rest (1.484566ms)
✔ mountTarget is the element whose children are the paragraphs (0.240323ms)
✔ paragraphTag keeps the renderer's own markup per type (0.180781ms)
✔ blockFragment finds a block's text by slide and block id (6.047245ms)
✔ notesFragment finds the slide's notes (0.778456ms)
✔ blockIDs and slideIDs are the orders on the stage and the strip (0.857945ms)
✔ cellFragments are a table's cells, row-major (1.228613ms)
✔ a load that fails leaves the stage on the slide it was showing and says so (1.286502ms)
✔ slideAfter is the slide to show once one is gone (0.179538ms)
✔ the queue words map to savestatus states, failed staying failed (1.487721ms)
✔ a dropped batch outranks the queue, for the rest of the session (0.199195ms)
✔ the editor status: the save line and the load error are two lines (0.262705ms)
✔ mountSaveStatus loads estilo's module and mounts it on the line (2.07081ms)
✔ a save-status module that will not load says so and refuses to mount (4.103846ms)
✔ dropTarget: before puts it ahead of the item, after behind it, null means first (1.161958ms)
✔ a drop that leaves the order as it is is no move (0.224192ms)
✔ dropOp is the move_slide (0.755012ms)
✔ labelFor is the slide's first heading, else the numbered fallback (4.319954ms)
✔ flush re-points every dirty thumbnail and relabels it (1.469157ms)
✔ destroy takes the item-menu listener off; a second mount leaves one (0.268044ms)
✔ plan says what to add, drop and where each item goes (0.640105ms)
✔ sync moves only the items out of place and keeps focus (0.965508ms)
✔ desktop view: box and size are the block; hidden and order are always the phone map (1.544869ms)
✔ phone view: everything goes to set_phone, carrying the rest of the map (0.360939ms)
✔ the ops it makes are ones the document takes (8.725148ms)
✔ phoneMap reads only the four keys, and only well-typed (0.206238ms)
✔ the stored view is read defensively (0.282773ms)
✔ linkAt reads the link under the cursor and nothing elsewhere (2.068565ms)
✔ setLink marks the selection (1.702545ms)
✔ setLink on a collapsed cursor inside a link replaces that link (0.521943ms)
✔ setLink with nothing selected and no link does nothing (0.178957ms)
✔ removeLink clears the link under the cursor (0.357343ms)
✔ the keymap binds every documented shortcut (0.193214ms)
✔ Mod-b toggles bold through the keymap (0.514168ms)
✔ setLink refuses an address outside the allowlist and writes nothing (0.442773ms)
✔ the state machine runs choose → sign → put → register → op (2.36391ms)
✔ a file the deck will not take never reaches the network (0.657638ms)
✔ alt text is required before the bytes move, unless the image is decorative (0.345881ms)
✔ a step that fails stops the ones after it and reports its own code (0.591424ms)
✔ a failure that is not ours still becomes an UploadError (0.275498ms)
✔ a second pick while one is in flight is refused, not raced (0.348617ms)
✔ an unreadable size is zero rather than a failure (0.274296ms)
✔ a per-call applyOp wins, so an upload lands on the block it was chosen for (0.20673ms)
✔ checkFile takes exactly the four types (0.450549ms)
✔ sha256Hex is the hex digest of the bytes (12.677438ms)
✔ refusal reads this app's JSON error shape, and survives one that is not (0.365418ms)
✔ malformed fonts are null (2.665108ms)
✔ a malformed background is the theme default (1.421967ms)
✔ a malformed box is null (0.590422ms)
✔ the phone layer keeps only its typed fields, order as a whole number (1.66784ms)
✔ assets are typed or skipped (0.374285ms)
✔ every poison update is deterministic bytes that apply to any deck (6.271488ms)
ℹ tests 158
ℹ suites 0
ℹ pass 158
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 320.093203
=== the vectors must match a fresh generation
canvas: 22 ops, 3715 bytes
columns: 23 ops, 3134 bytes
every-block: 36 ops, 3180 bytes
table: 14 ops, 1509 bytes
title-only: 6 ops, 1136 bytes
=== the editor bundle must match a fresh build
wrote internal/slides/static/editor.5024c57ebd249378.js (376213 bytes)
=== go: vet, gofmt, test, migration check
go vet ./...
gofmt needed:
internal/slides/handlers.go
internal/slides/home.go
make: *** [Makefile:91: fmt-check] Error 1

amadan: step gate failed: exit status 2

amadan: job failed at step gate — its output is above, not at the tail of this log
diff --git a/internal/slides/auth.go b/internal/slides/auth.go
index bef85a2..158170a 100644
--- a/internal/slides/auth.go
+++ b/internal/slides/auth.go
@@ -612,7 +612,6 @@ func (a *app) signin(w http.ResponseWriter, r *http.Request) {
form := chrome.SignIn{
Icon: brand.Path("slides"),
Heading: rastrillo.T(r, "slides.signin.title"),
- Lede: rastrillo.T(r, "slides.signin.lede"),
Action: signinPath,
Hidden: []chrome.Hidden{{Name: "force", Value: "1"}},
AddressLabel: rastrillo.T(r, "slides.signin.address.label"),
diff --git a/internal/slidestest/signin_test.go b/internal/slidestest/signin_test.go
index 84e4f5e..5ec4677 100644
--- a/internal/slidestest/signin_test.go
+++ b/internal/slidestest/signin_test.go
@@ -36,7 +36,7 @@ func TestSigninPageIsPublic(t *testing.T) {
// A real <label> bound to the input, not a placeholder standing in
// for one — the guarantee the vendored field-text partial carries,
// pinned here so a future hand-rolled input cannot quietly drop it.
- if !strings.Contains(body, `for="address"`) {
+ if !strings.Contains(body, `for="estilo-signin-address"`) {
t.Errorf("GET /signin: the address field has no bound <label>:\n%s", body)
}
// The catalog resolved, rather than the key leaking onto the page.