Make the projector a full-screen stage
2 files changed,
+20
−0
internal/slides/templates/present.html+14 −0internal/slidestest/present_test.go+6 −0
CI failed — run details
CI log
=== gate ===
=== rust: fmt
=== rust: clippy
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.05s
=== wasm: the artifact the host embeds
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.03s
Finished `release` profile [optimized] target(s) in 0.06s
core/target/wasm32-unknown-unknown/release/slides_core.wasm (1228229 bytes)
=== the embedded wasm must match a fresh build
=== rust: test
Finished `test` profile [unoptimized + debuginfo] target(s) in 0.03s
Running unittests src/lib.rs (core/target/debug/deps/slides_core-929bfceb2edd4a94)
running 30 tests
test layout::tests::aside_region_rect ... ok
test check::tests::the_empty_document_passes ... ok
test layout::tests::body_region_rect_narrows_for_an_aside ... ok
test layout::tests::heading_region_rect ... ok
test layout::tests::media_region_rect ... ok
test layout::tests::default_region_by_kind ... ok
test layout::tests::to_canvas_narrows_body_when_an_aside_is_present ... ok
test check::tests::an_element_inside_a_paragraph_is_reported ... ok
test layout::tests::to_flow_is_a_no_op_when_already_in_order ... ok
test check::tests::bare_text_at_fragment_level_is_reported ... ok
test layout::tests::to_canvas_splits_a_shared_region_equally_and_sets_z_by_index ... ok
test layout::tests::to_flow_classifies_by_position_and_kind ... ok
test check::tests::a_non_paragraph_child_is_reported ... ok
test check::tests::y_prosemirror_shapes_pass ... ok
test check::tests::what_the_ops_write_passes ... ok
test layout::tests::to_flow_orders_y_then_x ... ok
test check::tests::an_unknown_formatting_attribute_is_reported ... ok
test markdown::tests::empty_input_is_no_paragraphs_and_lines_keep_blanks ... ok
test markdown::tests::inline_marks ... ok
test markdown::tests::marks_nest_and_links_carry_marks ... ok
test markdown::tests::paragraphs_split_on_blank_lines_and_list_markers ... ok
test schema::tests::an_empty_map_reads_as_a_set_mark ... ok
test schema::tests::an_href_map_without_a_string_url_reads_as_no_link ... ok
test schema::tests::href_is_written_as_a_one_key_map_and_reads_back ... ok
test schema::tests::href_written_as_a_plain_string_still_reads_back ... ok
test view::tests::malformed_box_is_null_and_phone_keeps_only_typed_fields ... ok
test view::tests::assets_are_typed_or_skipped ... ok
test view::tests::malformed_fonts_are_null ... ok
test view::tests::malformed_background_is_the_default ... ok
test layout::tests::to_flow_keeps_a_concurrent_text_edit ... ok
test result: ok. 30 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running tests/no_host_imports.rs (core/target/debug/deps/no_host_imports-184c0d8bf00e14f9)
running 1 test
test no_host_imports ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running tests/ops.rs (core/target/debug/deps/ops-256addce27f366d1)
running 12 tests
test ops_are_atomic ... ok
test add_slide_then_view_lists_it ... ok
test add_block_with_markdown_produces_runs ... ok
test layout_switch_assigns_boxes ... ok
test remove_block_drops_it_from_columns_children ... ok
test columns_children_must_name_blocks_on_the_slide ... ok
test duplicate_slide_remaps_columns_children ... ok
test columns_children_have_one_parent_and_no_cycles ... ok
test move_block_keeps_a_concurrent_text_edit ... ok
test update_roundtrip ... ok
test move_slide_keeps_a_concurrent_text_edit ... ok
test remaining_ops_roundtrip ... ok
test result: ok. 12 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
Doc-tests slides_core
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
=== rust: fmt (pdf)
=== rust: clippy (pdf)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.07s
=== wasm: the pdf artifact the host embeds
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.03s
Finished `release` profile [optimized] target(s) in 0.07s
core/pdf/target/wasm32-unknown-unknown/release/slides_pdf.wasm (5301002 bytes)
=== the embedded pdf wasm must match a fresh build
=== rust: test (pdf)
Finished `test` profile [unoptimized + debuginfo] target(s) in 0.03s
Running unittests src/lib.rs (core/pdf/target/debug/deps/slides_pdf-891fafaa44f9fd64)
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
Running tests/no_host_imports.rs (core/pdf/target/debug/deps/no_host_imports-17ccbb1d62120093)
running 1 test
test no_host_imports ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
Running tests/render.rs (core/pdf/target/debug/deps/render-2e1d7e8b19d78595)
running 6 tests
test a_null_zero_length_pair_is_no_frames_not_a_dereference ... ok
test text_with_no_fonts_at_all_still_renders_the_shapes ... ok
test raster_image_is_embedded ... ok
test abi_frames_round_trip ... ok
test renders_text_as_embedded_glyphs ... ok
test two_svgs_make_two_pages ... ok
test result: ok. 6 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
Doc-tests slides_pdf
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
=== fixtures: node dependencies
v24.19.0
11.17.0
=== fixtures: npm ci (needs the registry — see .amadan/README.md)
added 19 packages, and audited 20 packages in 573ms
5 packages are looking for funding
run `npm fund` for details
found 0 vulnerabilities
npm warn allow-scripts 1 package has install scripts not yet covered by allowScripts:
npm warn allow-scripts esbuild@0.28.2 (postinstall: node install.js)
npm warn allow-scripts
npm warn allow-scripts Run `npm approve-scripts --allow-scripts-pending` to review, or `npm approve-scripts <pkg>` to allow.
=== fixtures: the JS side's own tests
✔ one finished upload is register_asset plus the block that uses it, in one batch (26.744173ms)
✔ a record missing its numbers still makes an op the core accepts (3.724935ms)
✔ unusedAssets is what no slide refers to, and remove_asset drops one (9.557179ms)
✔ the Unused images list reconciles by id and names each Remove button (4.740793ms)
✔ an upload refusal is said in words the person can act on (0.28475ms)
✔ clampBox keeps the box inside the frame and no smaller than the minimum (1.883542ms)
✔ fixBox writes four decimals (0.266927ms)
✔ guides are the thirds plus every other block edge (0.305478ms)
✔ snapMove pulls the nearest edge onto a guide within one per cent, and leaves a far one (0.516581ms)
✔ snapResize moves only the edges the handle drags (0.240237ms)
✔ moveBox and resizeBox by handle (0.278818ms)
✔ nudge: arrows move by half a per cent, Shift by two, Alt resizes (0.328141ms)
✔ rectBox reads a block rectangle against its frame (0.194251ms)
✔ typing into a block is a text change on its slide only (11.197318ms)
✔ a block's props changing is structure on its slide (1.755744ms)
✔ adding, moving or removing a block is structure on its slide (2.949483ms)
✔ the notes are text on their slide (1.362623ms)
✔ a slide added, removed or moved is an order change (2.290098ms)
✔ one transaction touching several things reports each once (0.976115ms)
✔ what the ops write passes, and so does an empty document (10.071283ms)
✔ the shapes y-prosemirror and older documents write pass (1.887389ms)
✔ an unknown formatting attribute is reported with the core's message (2.14658ms)
✔ an element inside a paragraph, a non-paragraph child and bare text are reported (3.308572ms)
✔ the unknownmark poison shape is what the check refuses (2.702916ms)
✔ y-prosemirror 1.3.7 deletes the words under an unknown mark; sanitising first keeps them (5.293751ms)
✔ the vocabulary is the five marks and nothing else (0.160158ms)
✔ a reload reuses the id this tab stored for the deck (1.095988ms)
✔ two tabs, and two decks in one tab, get different ids (1.63446ms)
✔ a stored value that is not an id, or storage that throws, gives a fresh id (0.382291ms)
✔ a duplicated tab gives up the copied id; the original keeps it (8.669817ms)
✔ a reload finds no rival and keeps its id (3.206992ms)
✔ presence switches id: beats carry the new one and the old one is somebody else (2.453903ms)
✔ an empty body is no frames (1.687587ms)
✔ frames come back in order with their exact bytes (0.388412ms)
✔ a length prefix is big-endian (0.216844ms)
✔ a truncated frame throws rather than returning a short update (1.856842ms)
✔ deck controls are set_meta (12.825716ms)
✔ slide controls are set_slide, and background keeps its colour (3.600885ms)
✔ move up and down are move_slide with the right after (2.253349ms)
✔ block props: value kinds, region, a shape label (3.970462ms)
✔ box fields are set_block on the desktop and set_phone in the phone view (5.87329ms)
✔ move block and the layer buttons (2.362442ms)
✔ add block: region after the selection on flow, a default box on canvas, a heading level that fits (9.281837ms)
✔ a block is named by its type and its first words (1.684171ms)
✔ blockChange: a control element to its op (1.19941ms)
✔ the Blocks list reconciles by id and keeps its buttons (0.950016ms)
✔ open resolves to the button that closed it and the trimmed field (1.774208ms)
✔ a second open while the dialog is up joins the first (0.233354ms)
✔ a missing dialog mounts as nothing (0.15558ms)
✔ a tab advances its own cursor only when its POST is the very next row (2.679762ms)
✔ the cursor never moves backwards when a response is overtaken by this tab's own write (0.467228ms)
✔ a later response still carries the cursor forward (0.25855ms)
✔ a burst of notifications collapses into one fetch at a time (0.223896ms)
✔ an event naming a seq the tab already has fetches nothing (0.179994ms)
✔ a stopped subscriber drops a response that arrives late (0.245807ms)
✔ stop closes the stream, and start opens exactly one (0.192238ms)
✔ a hidden tab closes its stream on a shortened deadline, and activity reopens it (0.878042ms)
✔ switching away and back inside the grace never drops the stream, so nothing has to be caught up (0.227754ms)
✔ a visible tab that is only being READ closes when idle and comes back on any activity (1.366481ms)
✔ activity while streaming defers the idle close rather than reopening anything (0.18335ms)
✔ a stream failure is never reported as a save failure, and heals on activity (0.177119ms)
✔ an empty response advances the cursor without applying anything (0.176699ms)
✔ a failed fetch leaves the cursor alone so the next notification retries it (0.563879ms)
✔ a decode failure retries once through the raw log, then gives up (1.130662ms)
✔ updatesURL spells the query string exactly, in particular raw as the literal raw=1 (0.146212ms)
✔ empty_doc_views_as_defaults (4.455044ms)
✔ set_meta (3.995748ms)
✔ slides: add, move, remove, set_slide, set_notes (7.529638ms)
✔ duplicate_slide (3.649897ms)
✔ blocks: add, move, remove, set_block (4.495117ms)
✔ set_phone (1.422855ms)
✔ table cells follow rows and cols (2.085918ms)
✔ canvas blocks: box defaults from the region, z from the index (2.054299ms)
✔ assets: register and remove (1.326256ms)
✔ markdown: every mark, code blocks are plain lines (6.578772ms)
✔ batch_is_atomic (2.284347ms)
✔ a batch applies in one transaction with the given origin (1.260323ms)
✔ columns_children_validated (1.692436ms)
✔ layout_switch_round_trip (2.31828ms)
✔ view_matches_snapshot_fixtures (22.33287ms)
✔ columns children have one parent and no cycles (codex 7) (1.601649ms)
✔ canvas-to-flow keeps a concurrent text edit (codex 4) (5.59917ms)
✔ move_block keeps a concurrent text edit, and later inserts land where after says (codex 4) (5.899317ms)
✔ move_slide keeps a concurrent text edit, and later inserts land where after says (codex 4 at slide level) (4.658531ms)
✔ format: {name} and {n} interpolate; an unknown key is left as text (1.046596ms)
✔ a beat on connect, then one every twenty seconds (2.251095ms)
✔ a move posts once, 200ms after the last of a burst, and re-arms the beat (1.69368ms)
✔ a hidden tab stops beating; coming back posts at once (0.411806ms)
✔ applySet leaves this tab out and answers what changed (0.546245ms)
✔ a set with rubbish in it is read for what it does carry (0.255115ms)
✔ initials, and a client id per tab (4.30334ms)
✔ a resync that fails is retried with backoff until it succeeds, without ever running twice at once (8.319597ms)
✔ the browser's online event retries immediately, not just on the next backoff tick (0.452051ms)
✔ reportDivergence before any failure runs the first attempt without a caller ever calling online (2.5655ms)
✔ a permanent 4xx drops its batch instead of retrying it, and does not poison the next edit (81.858769ms)
✔ a network failure or a 5xx is retried, not dropped (61.204521ms)
✔ a 500 is retried the same way a network failure is, never dropped (60.477888ms)
✔ the core-written structure reads as ProseMirror marks (6.114487ms)
✔ a y-prosemirror round trip preserves bold and the link (3.029423ms)
✔ y-prosemirror writes href as the one-key map and marks as {} (1.042979ms)
✔ a plain-string href, written before the map shape, still reads (0.879405ms)
✔ textFragment writes the same shape as writeText (0.634159ms)
✔ safeHref is the server allowlist, and a disallowed href never draws an anchor (0.415472ms)
✔ parseHash splits the slide and the block, and survives a stray % (1.870297ms)
✔ destroy takes the listeners off, and a second mount leaves one of each (1.001983ms)
✔ formatHash is the inverse (1.007082ms)
✔ textBlocks finds the text-bearing blocks and skips the rest (1.59793ms)
✔ mountTarget is the element whose children are the paragraphs (0.197497ms)
✔ paragraphTag keeps the renderer's own markup per type (0.132887ms)
✔ blockFragment finds a block's text by slide and block id (7.710025ms)
✔ notesFragment finds the slide's notes (0.976626ms)
✔ blockIDs and slideIDs are the orders on the stage and the strip (0.892569ms)
✔ cellFragments are a table's cells, row-major (1.241909ms)
✔ a load that fails leaves the stage on the slide it was showing and says so (1.238543ms)
✔ slideAfter is the slide to show once one is gone (0.23139ms)
✔ the queue words map to savestatus states, failed staying failed (0.950407ms)
✔ a dropped batch outranks the queue, for the rest of the session (0.197768ms)
✔ the editor status: the save line and the load error are two lines (0.255585ms)
✔ mountSaveStatus loads estilo's module and mounts it on the line (0.904031ms)
✔ a save-status module that will not load says so and refuses to mount (0.485022ms)
✔ dropTarget: before puts it ahead of the item, after behind it, null means first (1.035656ms)
✔ a drop that leaves the order as it is is no move (0.243071ms)
✔ dropOp is the move_slide (0.890937ms)
✔ labelFor is the slide's first heading, else the numbered fallback (6.359104ms)
✔ flush re-points every dirty thumbnail and relabels it (2.330593ms)
✔ destroy takes the item-menu listener off; a second mount leaves one (0.394534ms)
✔ plan says what to add, drop and where each item goes (1.021429ms)
✔ sync moves only the items out of place and keeps focus (1.445427ms)
✔ desktop view: box and size are the block; hidden and order are always the phone map (1.384904ms)
✔ phone view: everything goes to set_phone, carrying the rest of the map (0.379446ms)
✔ the ops it makes are ones the document takes (10.137558ms)
✔ phoneMap reads only the four keys, and only well-typed (0.22561ms)
✔ the stored view is read defensively (0.374667ms)
✔ linkAt reads the link under the cursor and nothing elsewhere (1.999397ms)
✔ setLink marks the selection (1.693139ms)
✔ setLink on a collapsed cursor inside a link replaces that link (0.469443ms)
✔ setLink with nothing selected and no link does nothing (0.162452ms)
✔ removeLink clears the link under the cursor (0.317691ms)
✔ the keymap binds every documented shortcut (0.181267ms)
✔ Mod-b toggles bold through the keymap (0.475885ms)
✔ setLink refuses an address outside the allowlist and writes nothing (0.400465ms)
✔ the state machine runs choose → sign → put → register → op (2.823659ms)
✔ a file the deck will not take never reaches the network (0.545013ms)
✔ alt text is required before the bytes move, unless the image is decorative (0.339661ms)
✔ a step that fails stops the ones after it and reports its own code (0.491173ms)
✔ a failure that is not ours still becomes an UploadError (0.290019ms)
✔ a second pick while one is in flight is refused, not raced (0.329022ms)
✔ an unreadable size is zero rather than a failure (0.286243ms)
✔ a per-call applyOp wins, so an upload lands on the block it was chosen for (0.321879ms)
✔ checkFile takes exactly the four types (0.43583ms)
✔ sha256Hex is the hex digest of the bytes (8.656645ms)
✔ refusal reads this app's JSON error shape, and survives one that is not (0.316178ms)
✔ malformed fonts are null (3.943272ms)
✔ a malformed background is the theme default (2.078424ms)
✔ a malformed box is null (0.945117ms)
✔ the phone layer keeps only its typed fields, order as a whole number (0.799607ms)
✔ assets are typed or skipped (1.513333ms)
✔ every poison update is deterministic bytes that apply to any deck (8.942997ms)
ℹ tests 158
ℹ suites 0
ℹ pass 158
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 323.677802
=== the vectors must match a fresh generation
canvas: 22 ops, 3715 bytes
columns: 23 ops, 3134 bytes
every-block: 36 ops, 3180 bytes
table: 14 ops, 1509 bytes
title-only: 6 ops, 1136 bytes
=== the editor bundle must match a fresh build
wrote internal/slides/static/editor.5024c57ebd249378.js (376213 bytes)
=== go: vet, gofmt, test, migration check
go vet ./...
gofmt needed:
internal/slides/handlers.go
internal/slides/home.go
make: *** [Makefile:91: fmt-check] Error 1
amadan: step gate failed: exit status 2
amadan: job failed at step gate — its output is above, not at the tail of this log
diff --git a/internal/slides/templates/present.html b/internal/slides/templates/present.html| index b6499fd..2323771 100644 |
| --- a/internal/slides/templates/present.html |
| +++ b/internal/slides/templates/present.html |
| @@ -21,9 +21,22 @@ |
| /* The stage fills what it is given and keeps the slide's aspect; |
| everything else on this page is one line of chrome under it. */ |
| [slides-surface] { |
| + box-sizing: border-box; |
| display: flex; |
| flex-direction: column; |
| gap: var(--rst-sp-3); |
| + min-block-size: 100dvh; |
| + padding: var(--rst-sp-3); |
| + } |
| + /* The projector is its own full-screen stage, not a document inside |
| + the ordinary constrained rst-page wrapper. Its capability is what |
| + makes it safe to omit the app bar and account menu. */ |
| + [slides-present-stage] { |
| + box-sizing: border-box; |
| + inline-size: 100%; |
| + max-inline-size: none; |
| + min-block-size: 100dvh; |
| + padding: 0; |
| } |
| [slides-stage] { |
| margin: 0; |
| @@ -58,6 +71,7 @@ |
| margin: 0; |
| } |
| </style>{{end}} |
| +{{define "main"}}<main id="main" slides-present-stage>{{template "content" .}}</main>{{end}} |
| {{define "content"}} |
| {{/* The two URLs the script reads come DOWN rather than being built up |
| there: which capability this surface reads under is the handler's |
diff --git a/internal/slidestest/present_test.go b/internal/slidestest/present_test.go| index fd69a71..121fb0b 100644 |
| --- a/internal/slidestest/present_test.go |
| +++ b/internal/slidestest/present_test.go |
| @@ -144,6 +144,12 @@ func TestPresentCreatesSessionWithCodeAndRemoteUrl(t *testing.T) { |
| // The fullscreen surface is the sqid's own capability: anybody who |
| // has the address can watch, with no token and no session. |
| surface := mustGet(t, a, "/p/"+session, http.StatusOK, nil).Body.String() |
| + if !strings.Contains(surface, `<main id="main" slides-present-stage>`) || strings.Contains(surface, `<main rst-page id="main">`) { |
| + t.Errorf("the projector is not a full-screen stage outside the ordinary page wrapper:\n%s", surface) |
| + } |
| + if strings.Contains(surface, "<header estilo-bar") || strings.Contains(surface, "estilo-account") { |
| + t.Errorf("the projector surface carries app chrome:\n%s", surface) |
| + } |
| if !strings.Contains(surface, "<section slides-slide") { |
| t.Errorf("the fullscreen surface renders no slide:\n%s", surface) |
| } |