oficina / sheets Public

fix: the selection had a fill and no outline in dark

Reported from a canary: a range in dark mode is a navy slab with one
bright white line down its left side and no edge anywhere else.

Every colour in the vendored Jspreadsheet stylesheet is a literal, and
sheets.css restated the ones for the grid, the headers and the range
fill. It stopped there. The outline is where the rest of them live:

  .highlight-right/-bottom   border: 1px solid #000
  .highlight-top/-left       the same, plus box-shadow: -1px 0 #ccc

In dark that renders backwards. The black borders vanish into a #111418
grid. The two that would not are overwritten by our own
`td { border-top-color: var(--rst-line) }`, which at (0,2,3) outranks
the library's (0,2,0) `.jss_worksheet .highlight-top` — so they resolve
to ordinary grid lines. What survives is the #ccc box-shadow, a shim
that exists only to mask the grid line the border sits on, and it
becomes the only visible edge. Hence the white L.

Three more of the same shape, found while measuring the first:

  - The selected row's header was #dcdcdc — a light slab in a dark grid
    carrying --rst-text-muted at 1.9:1. sheets.css DID have an override
    for it, `tbody > tr > td:first-child.selected`, but the library puts
    .selected on the <tr>, not on its first cell, so the rule matched
    nothing and looked like a fix. A CSS rule that matches nothing fails
    exactly like a rule nobody wrote.
  - The fill handle is a black knob ringed in white: inverted in dark.
  - The copy marquee and the range a formula points at are dashed and
    dotted #000, both invisible.

The fix is one outline colour, --rst-accent, on all four sides of all
three range states, scoped `> tbody > tr > td.foo` so it clears the grid
line, and the #ccc shadow dropped — with an outline that reads, masking
the line beneath it buys nothing and costs the selection its symmetry.
The library gives each state a different border STYLE (solid, dashed,
dotted) and the style survives a colour-only override, so that is what
tells them apart. --rst-accent on --rst-accent-soft measures 6.59:1 in
dark and 4.75:1 in light, both past 1.4.11's 3:1 for a component
boundary.

One thing here is not dark-specific. .highlight-selected — the anchor
cell the keyboard is on — is transparent in the library so it reads out
of the fill, and our opaque .highlight rule took that back. Restored: a
range now shows its cursor in both schemes.

TestVendorSelectionChromeIsRestated is the gate. It checks both
directions: that each vendored selector still exists — v5 renamed every
.jexcel to .jss_* once already, and a stale list is how that goes
unnoticed a second time — and that sheets.css restates it. Rules the app
cannot render (.readonly, .jss_freezed, pagination, the editors we do not
enable) are named in the test with the reason, not silently omitted. A
second test pins the specificity, which is the half of the bug that is
invisible in a diff.

Verified in Chromium at 1200x620 in both schemes, on the real binary:
outline #7ba7ff dark / #2464e0 light on all four sides, box-shadow none,
row header on --rst-accent-soft with --rst-text, handle on the accent,
marquee dashed and visible. make test green including vet, fmt,
migrations and race.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UiPVt2xfkKStDgkv4qLCm1