oficina / calendar Public

chore/review-nits

Non-blocking findings left from Astra's review of #26.

1. Quick-add panel overflows at 390px (dabf234)

  • Cause: under 40rem the quick-add form and its textarea are both width: 100% and content-box, so padding and border were added on top of the 100%. The open panel ran about 15px past the right edge, and the page scrolled sideways. This predates the migration.
  • Fix: box-sizing: border-box on [cal-quick-form] and [cal-quick-text].
  • Test: TestQuickAddOnANarrowScreen (browser tag; make browser picks it up through OnANarrowScreen) opens the panel at 320 and 390. It fails if any element of it, or the page, is wider than the viewport. Red before the fix: at 390 the form spanned 16-400, the textarea 29-405, and the page was 405px wide; at 320, 16-330, 29-335 and 335px. Green after. make ci and make browser are green (GOTOOLCHAIN go1.26.5).

2. datetime.js native-picker button: aria-haspopup="listbox", permanently aria-expanded="false"

  • Not fixed in this repo. static/datetime.js is a rastrillo vendored asset, pinned byte-identical to ui.VendoredAssets by TestVendoredAssetsMatchTheLibrary, so it is not hand-edited.
  • The fix is upstream on rastrillo/rastrillo branch chore/review-nits (a5d82f3, discussion rastrillo/rastrillo#57). The popup attributes now appear only on the grid (dialog) and the clock (listbox). A browser test there drives a page without calendar.js, and it was red on all three checks before the fix.
  • Calendar takes it with the next rastrillo bump plus rastrillo doctor --fix. Calendar runs without rastrillo's calendar.js (vendoredIsMine), so its date fields are exactly the case that was wrong.

Release. CSS only. After review and merge: make release, then carlos deploy per the README with --channel edge, flags before the binary path. Check /api/version.

Commits 2
Discussions 1 1 open
Tasks 0/0 done

Activity