chore/review-nits
Non-blocking findings left from Astra's review of #26.
1. Quick-add panel overflows at 390px (dabf234)
- Cause: under 40rem the quick-add form and its textarea are both
width: 100%and content-box, so padding and border were added on top of the 100%. The open panel ran about 15px past the right edge, and the page scrolled sideways. This predates the migration. - Fix:
box-sizing: border-boxon[cal-quick-form]and[cal-quick-text]. - Test: TestQuickAddOnANarrowScreen (browser tag;
make browserpicks it up throughOnANarrowScreen) opens the panel at 320 and 390. It fails if any element of it, or the page, is wider than the viewport. Red before the fix: at 390 the form spanned 16-400, the textarea 29-405, and the page was 405px wide; at 320, 16-330, 29-335 and 335px. Green after.make ciandmake browserare green (GOTOOLCHAIN go1.26.5).
2. datetime.js native-picker button: aria-haspopup="listbox", permanently aria-expanded="false"
- Not fixed in this repo.
static/datetime.jsis a rastrillo vendored asset, pinned byte-identical toui.VendoredAssetsby TestVendoredAssetsMatchTheLibrary, so it is not hand-edited. - The fix is upstream on rastrillo/rastrillo branch
chore/review-nits(a5d82f3, discussion rastrillo/rastrillo#57). The popup attributes now appear only on the grid (dialog) and the clock (listbox). A browser test there drives a page without calendar.js, and it was red on all three checks before the fix. - Calendar takes it with the next rastrillo bump plus
rastrillo doctor --fix. Calendar runs without rastrillo's calendar.js (vendoredIsMine), so its date fields are exactly the case that was wrong.
Release. CSS only. After review and merge: make release, then carlos deploy per the README with --channel edge, flags before the binary path. Check /api/version.
Commits
2
Discussions
1
1 open
Tasks
0/0
done
Discussions 1 open
Tasks
- No tasks yet.
Activity
- claude agent, operated by paul@keymail.dev replied to Review nits: quick-add fits a phone; datetime.js fix is upstream
- paul@keymail.dev pushed 8a02f1e Seed the boot-recovery test's work before the failing boot
- claude agent, operated by paul@keymail.dev replied to Review nits: quick-add fits a phone; datetime.js fix is upstream
- claude agent, operated by paul@keymail.dev opened Review nits: quick-add fits a phone; datetime.js fix is upstream
- paul@keymail.dev pushed dabf234 Keep the open quick-add panel inside a phone's screen