amadan
Give check more slices, so the 1.0 photographs finish well inside their deadline
On a7a1129 the fleet ran TestEveryOneOhExampleRendersAsItDid2of4 into its own 300 s deadline. It takes 38 s on docs-t1 and passed on the fleet at 95bd8cc, so something on that runner stopped answering partway through, and the failure said only "context deadline exceeded", with no word of which page. Check's slices were also at 77 to 91 s each after the photographs were weighed, past the under-a-minute the Makefile aims every role at. - Every shot now has its own 60 s budget. A hang fails as that shot, named (side, state, width, direction, scheme and medium), within a minute, not as a whole part with no word of where it stopped. Shown with the budget cut to 50 ms in a scratch copy: "old's page-header/title-subhead-and-a-primary-action.html at 900px, left to right, light, screen: no answer within 50ms". The 300 s deadline stays, now about ten times each part's fleet time. - The layouts are dealt into six parts, one per theme and scheme (Day light also takes forced colours and print), and the other states into eight. Locally the parts take 15 to 24 s and 19 to 23 s. - check goes from 13 slices to 24, and 50-suite from 48 shards to 59 to match. With the new weights, the deal puts 38 to 45 weighted seconds on each slice, where 13 slices put 72 or 73. The floor is now the heaviest single tests (TestEveryThemeAndShellRendersAsTheBaseline 45, TestEveryThemeRendersAsItDidExceptDay 44), each nearly a slice of its own. Eighteen slices would still put 52 or 53 on each. - A leg now fails only when three pairs in a row differ, still at zero tolerance. On 8d58daa the fleet failed api-tokens' just-created-the-secret-shown-once at 390px by one level at one pixel, the corner of its autofocused callout. The same page under one stylesheet does that 1 pair in 60 on docs-t1, while a difference the CSS makes is in every pair: the base [rst-ftok] rule deleted still fails dropdown/menu-idiom in all four legs, the same pixel three times over. A leg that differs and then agrees is logged. The new parts' weights are their docs-t1 times scaled by 1.17, the ratio the unsplit parts ran at on the fleet.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 files changed,
+86
−34
.amadan/ci.d/{50-suite@48 => 50-suite@59}+0 −0Makefile+1 −1check/oneoh_browser_test.go+67 −23hack/test-weights.txt+18 −10
CI failed — run details
CI log
=== gofmt ===
=== no-rastrillo ===
go test -run '^(TestFiestaNeverImportsRastrillo|TestThePublicPackagesLinkNoBrowser)$' -count=1 .
ok amadan.net/rastrillo/fiesta 1.067s
=== size ===
go test ./internal/build -run '^TestTheOneLinkIsUnder25KiBGzipped$' -count=1 -v
=== RUN TestTheOneLinkIsUnder25KiBGzipped
build_test.go:138: fiesta-plain.css: 152856 bytes, 22303 bytes gzipped (21.8 KiB of the 25.0 KiB limit)
build_test.go:138: fiesta-signal.css: 152951 bytes, 22414 bytes gzipped (21.9 KiB of the 25.0 KiB limit)
build_test.go:138: fiesta.css: 155770 bytes, 23018 bytes gzipped (22.5 KiB of the 25.0 KiB limit)
--- PASS: TestTheOneLinkIsUnder25KiBGzipped (0.02s)
PASS
ok amadan.net/rastrillo/fiesta/internal/build 0.025s
=== history ===
history: 13 commits; release tags: v1.0.0
=== suite ===
--- shard 0 of 59 ---
==> shard 0 of 59: make root
go build ./...
go vet ./...
FIESTA_TEST_REQUIRE_NODE=1 FIESTA_TEST_REQUIRE_GIT=1 FIESTA_TEST_REQUIRE_TAGS=1 ./hack/gotest.sh root 'internal/gallery@3 cmd/fiesta@2 internal/www@2'
ok amadan.net/rastrillo/fiesta 8.609s
ok amadan.net/rastrillo/fiesta/check 13.555s
ok amadan.net/rastrillo/fiesta/example 0.507s
? amadan.net/rastrillo/fiesta/hack/seed/english [no test files]
ok amadan.net/rastrillo/fiesta/internal/axe 0.498s
ok amadan.net/rastrillo/fiesta/internal/build 2.556s
ok amadan.net/rastrillo/fiesta/internal/codeview 0.035s
? amadan.net/rastrillo/fiesta/internal/harness [no test files]
ok amadan.net/rastrillo/fiesta/internal/markup 0.068s
ok amadan.net/rastrillo/fiesta/internal/nodetest 1.346s
ok amadan.net/rastrillo/fiesta/internal/site 5.827s
ok amadan.net/rastrillo/fiesta/internal/tokens 0.104s
suite: root took 27s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m11.650000s 0m2.180000s
--- shard 1 of 59 ---
==> shard 1 of 59: make test.internal.gallery~1of3
FIESTA_TEST_REQUIRE_NODE=1 FIESTA_TEST_REQUIRE_GIT=1 FIESTA_TEST_REQUIRE_TAGS=1 ./hack/gotest.sh test 'internal.gallery~1of3'
gotest: slice 1 of 3 of ./internal/gallery/ runs 35 of 105 test tests
ok amadan.net/rastrillo/fiesta/internal/gallery 116.273s
suite: test.internal.gallery~1of3 took 123s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m49.920000s 0m1.390000s
--- shard 2 of 59 ---
==> shard 2 of 59: make test.internal.gallery~2of3
FIESTA_TEST_REQUIRE_NODE=1 FIESTA_TEST_REQUIRE_GIT=1 FIESTA_TEST_REQUIRE_TAGS=1 ./hack/gotest.sh test 'internal.gallery~2of3'
gotest: slice 2 of 3 of ./internal/gallery/ runs 35 of 105 test tests
ok amadan.net/rastrillo/fiesta/internal/gallery 116.781s
suite: test.internal.gallery~2of3 took 123s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m48.050000s 0m1.340000s
--- shard 3 of 59 ---
==> shard 3 of 59: make test.internal.gallery~3of3
FIESTA_TEST_REQUIRE_NODE=1 FIESTA_TEST_REQUIRE_GIT=1 FIESTA_TEST_REQUIRE_TAGS=1 ./hack/gotest.sh test 'internal.gallery~3of3'
gotest: slice 3 of 3 of ./internal/gallery/ runs 35 of 105 test tests
ok amadan.net/rastrillo/fiesta/internal/gallery 110.274s
suite: test.internal.gallery~3of3 took 116s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m45.660000s 0m1.430000s
--- shard 4 of 59 ---
==> shard 4 of 59: make test.cmd.fiesta~1of2
FIESTA_TEST_REQUIRE_NODE=1 FIESTA_TEST_REQUIRE_GIT=1 FIESTA_TEST_REQUIRE_TAGS=1 ./hack/gotest.sh test 'cmd.fiesta~1of2'
gotest: slice 1 of 2 of ./cmd/fiesta/ runs 7 of 12 test tests
ok amadan.net/rastrillo/fiesta/cmd/fiesta 107.761s
suite: test.cmd.fiesta~1of2 took 114s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m33.830000s 0m2.400000s
--- shard 5 of 59 ---
==> shard 5 of 59: make test.cmd.fiesta~2of2
FIESTA_TEST_REQUIRE_NODE=1 FIESTA_TEST_REQUIRE_GIT=1 FIESTA_TEST_REQUIRE_TAGS=1 ./hack/gotest.sh test 'cmd.fiesta~2of2'
gotest: slice 2 of 2 of ./cmd/fiesta/ runs 5 of 12 test tests
ok amadan.net/rastrillo/fiesta/cmd/fiesta 101.537s
suite: test.cmd.fiesta~2of2 took 107s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m36.340000s 0m2.520000s
--- shard 6 of 59 ---
==> shard 6 of 59: make test.internal.www~1of2
FIESTA_TEST_REQUIRE_NODE=1 FIESTA_TEST_REQUIRE_GIT=1 FIESTA_TEST_REQUIRE_TAGS=1 ./hack/gotest.sh test 'internal.www~1of2'
gotest: slice 1 of 2 of ./internal/www/ runs 11 of 25 test tests
ok amadan.net/rastrillo/fiesta/internal/www 113.030s
suite: test.internal.www~1of2 took 126s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m48.120000s 0m1.800000s
--- shard 7 of 59 ---
==> shard 7 of 59: make test.internal.www~2of2
FIESTA_TEST_REQUIRE_NODE=1 FIESTA_TEST_REQUIRE_GIT=1 FIESTA_TEST_REQUIRE_TAGS=1 ./hack/gotest.sh test 'internal.www~2of2'
gotest: slice 2 of 2 of ./internal/www/ runs 14 of 25 test tests
ok amadan.net/rastrillo/fiesta/internal/www 111.274s
suite: test.internal.www~2of2 took 124s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m45.870000s 0m1.850000s
--- shard 8 of 59 ---
==> shard 8 of 59: make staticcheck
go run honnef.co/go/tools/cmd/staticcheck@v0.8.2 -tags browser ./...
suite: staticcheck took 28s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m15.030000s 0m1.040000s
--- shard 9 of 59 ---
==> shard 9 of 59: make govulncheck
go run golang.org/x/vuln/cmd/govulncheck@v1.8.0 ./...
=== Symbol Results ===
No vulnerabilities found.
Your code is affected by 0 vulnerabilities.
This scan also found 2 vulnerabilities in packages you import and 5
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.
suite: govulncheck took 16s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m3.230000s 0m0.480000s
--- shard 10 of 59 ---
==> shard 10 of 59: make gitleaks
go run github.com/zricethezav/gitleaks/v8@v8.30.1 git --no-banner --redact --log-opts='--full-history --diff-filter=tuxdb HEAD' .
[90m12:39AM[0m [32mINF[0m [1mUnknown SCM platform. Use --platform to include links in findings.[0m [36mhost=[0mamadan.net
[90m12:39AM[0m [32mINF[0m [1m13 commits scanned.[0m
[90m12:39AM[0m [32mINF[0m [1mscanned ~8190266 bytes (8.19 MB) in 9.08s[0m
[90m12:39AM[0m [32mINF[0m [1mno leaks found[0m
suite: gitleaks took 15s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m7.610000s 0m0.550000s
--- shard 11 of 59 ---
==> shard 11 of 59: make browser.internal.harness
./hack/gotest.sh browser 'internal.harness'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: ./internal/harness/ runs its 10 browser tests
ok amadan.net/rastrillo/fiesta/internal/harness 10.685s
suite: browser.internal.harness took 24s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m1.900000s 0m1.360000s
--- shard 12 of 59 ---
==> shard 12 of 59: make browser.check~1of24
./hack/gotest.sh browser 'check~1of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 1 of 24 of ./check/ runs 1 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 123.322s
suite: browser.check~1of24 took 144s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m39.450000s 0m8.300000s
--- shard 13 of 59 ---
==> shard 13 of 59: make browser.check~2of24
./hack/gotest.sh browser 'check~2of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 2 of 24 of ./check/ runs 1 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 120.482s
suite: browser.check~2of24 took 144s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m40.760000s 0m7.380000s
--- shard 14 of 59 ---
==> shard 14 of 59: make browser.check~3of24
./hack/gotest.sh browser 'check~3of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 3 of 24 of ./check/ runs 1 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 104.654s
suite: browser.check~3of24 took 127s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m25.170000s 0m5.340000s
--- shard 15 of 59 ---
==> shard 15 of 59: make browser.check~4of24
./hack/gotest.sh browser 'check~4of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 4 of 24 of ./check/ runs 2 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 115.415s
suite: browser.check~4of24 took 139s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m36.740000s 0m6.350000s
--- shard 16 of 59 ---
==> shard 16 of 59: make browser.check~5of24
./hack/gotest.sh browser 'check~5of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 5 of 24 of ./check/ runs 9 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 107.468s
suite: browser.check~5of24 took 130s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m33.320000s 0m9.860000s
--- shard 17 of 59 ---
==> shard 17 of 59: make browser.check~6of24
./hack/gotest.sh browser 'check~6of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 6 of 24 of ./check/ runs 10 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 99.049s
suite: browser.check~6of24 took 122s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m28.080000s 0m7.560000s
--- shard 18 of 59 ---
==> shard 18 of 59: make browser.check~7of24
./hack/gotest.sh browser 'check~7of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 7 of 24 of ./check/ runs 10 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 107.368s
suite: browser.check~7of24 took 129s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m29.370000s 0m8.120000s
--- shard 19 of 59 ---
==> shard 19 of 59: make browser.check~8of24
./hack/gotest.sh browser 'check~8of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 8 of 24 of ./check/ runs 10 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 101.461s
suite: browser.check~8of24 took 124s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m28.620000s 0m7.830000s
--- shard 20 of 59 ---
==> shard 20 of 59: make browser.check~9of24
./hack/gotest.sh browser 'check~9of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 9 of 24 of ./check/ runs 10 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 68.872s
suite: browser.check~9of24 took 91s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m16.940000s 0m4.950000s
--- shard 21 of 59 ---
==> shard 21 of 59: make browser.check~10of24
./hack/gotest.sh browser 'check~10of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 10 of 24 of ./check/ runs 10 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 88.815s
suite: browser.check~10of24 took 114s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m25.500000s 0m7.640000s
--- shard 22 of 59 ---
==> shard 22 of 59: make browser.check~11of24
./hack/gotest.sh browser 'check~11of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 11 of 24 of ./check/ runs 10 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 98.811s
suite: browser.check~11of24 took 120s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m26.760000s 0m6.710000s
--- shard 23 of 59 ---
==> shard 23 of 59: make browser.check~12of24
./hack/gotest.sh browser 'check~12of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 12 of 24 of ./check/ runs 10 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 100.492s
suite: browser.check~12of24 took 123s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m27.050000s 0m7.070000s
--- shard 24 of 59 ---
==> shard 24 of 59: make browser.check~13of24
./hack/gotest.sh browser 'check~13of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 13 of 24 of ./check/ runs 10 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 105.599s
suite: browser.check~13of24 took 128s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m28.520000s 0m7.150000s
--- shard 25 of 59 ---
==> shard 25 of 59: make browser.check~14of24
./hack/gotest.sh browser 'check~14of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 14 of 24 of ./check/ runs 11 of 211 browser tests
--- FAIL: TestEveryOneOhExampleRendersAsItDid7of8 (75.42s)
oneoh_browser_test.go:358: 1.0.0's api-tokens/just-created-the-secret-shown-once at 390px, left to right, light, screen renders differently under the tree's CSS: pixel 372,18 differs by 1; pixel 372,18 differs by 1; pixel 372,18 differs by 1
oneoh_browser_test.go:358: 1.0.0's api-tokens/just-created-the-secret-shown-once at 390px, right to left, light, screen differed (pixel 372,18 differs by 1), then agreed: the renderer, not the CSS
2026/10/30 00:41:40 ERROR: unhandled node event *dom.EventTopLayerElementsUpdated
2026/10/30 00:41:40 ERROR: unhandled node event *dom.EventTopLayerElementsUpdated
2026/10/30 00:41:40 ERROR: unhandled node event *dom.EventTopLayerElementsUpdated
2026/10/30 00:41:40 ERROR: unhandled node event *dom.EventTopLayerElementsUpdated
2026/10/30 00:41:40 ERROR: unhandled node event *dom.EventTopLayerElementsUpdated
2026/10/30 00:41:40 ERROR: unhandled node event *dom.EventTopLayerElementsUpdated
2026/10/30 00:41:40 ERROR: unhandled node event *dom.EventTopLayerElementsUpdated
2026/10/30 00:41:40 ERROR: unhandled node event *dom.EventTopLayerElementsUpdated
FAIL
FAIL amadan.net/rastrillo/fiesta/check 99.118s
FAIL
make[1]: *** [Makefile:234: browser.check~14of24] Error 1
suite: browser.check~14of24 took 123s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m27.540000s 0m6.750000s
make: *** [Makefile:76: suite] Error 2
amadan: step suite shard 25 of 59 failed: exit status 2
--- shard 26 of 59 ---
==> shard 26 of 59: make browser.check~15of24
./hack/gotest.sh browser 'check~15of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 15 of 24 of ./check/ runs 11 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 102.859s
suite: browser.check~15of24 took 126s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m29.040000s 0m7.790000s
--- shard 27 of 59 ---
==> shard 27 of 59: make browser.check~16of24
./hack/gotest.sh browser 'check~16of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 16 of 24 of ./check/ runs 11 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 98.536s
suite: browser.check~16of24 took 120s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m27.790000s 0m7.770000s
--- shard 28 of 59 ---
==> shard 28 of 59: make browser.check~17of24
./hack/gotest.sh browser 'check~17of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 17 of 24 of ./check/ runs 11 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 93.756s
suite: browser.check~17of24 took 116s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m25.450000s 0m6.920000s
--- shard 29 of 59 ---
==> shard 29 of 59: make browser.check~18of24
./hack/gotest.sh browser 'check~18of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 18 of 24 of ./check/ runs 11 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 78.261s
suite: browser.check~18of24 took 102s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m24.530000s 0m6.570000s
--- shard 30 of 59 ---
==> shard 30 of 59: make browser.check~19of24
./hack/gotest.sh browser 'check~19of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 19 of 24 of ./check/ runs 11 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 108.441s
suite: browser.check~19of24 took 130s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m32.340000s 0m10.100000s
--- shard 31 of 59 ---
==> shard 31 of 59: make browser.check~20of24
./hack/gotest.sh browser 'check~20of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 20 of 24 of ./check/ runs 10 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 100.288s
suite: browser.check~20of24 took 122s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m27.980000s 0m8.180000s
--- shard 32 of 59 ---
==> shard 32 of 59: make browser.check~21of24
./hack/gotest.sh browser 'check~21of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 21 of 24 of ./check/ runs 10 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 105.350s
suite: browser.check~21of24 took 127s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m28.500000s 0m8.190000s
--- shard 33 of 59 ---
==> shard 33 of 59: make browser.check~22of24
./hack/gotest.sh browser 'check~22of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 22 of 24 of ./check/ runs 10 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 78.669s
suite: browser.check~22of24 took 101s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m20.740000s 0m6.330000s
--- shard 34 of 59 ---
==> shard 34 of 59: make browser.check~23of24
./hack/gotest.sh browser 'check~23of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 23 of 24 of ./check/ runs 10 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 79.261s
suite: browser.check~23of24 took 102s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m22.840000s 0m8.500000s
--- shard 35 of 59 ---
==> shard 35 of 59: make browser.check~24of24
./hack/gotest.sh browser 'check~24of24'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 24 of 24 of ./check/ runs 11 of 211 browser tests
ok amadan.net/rastrillo/fiesta/check 99.786s
suite: browser.check~24of24 took 122s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m26.560000s 0m6.530000s
--- shard 36 of 59 ---
==> shard 36 of 59: make browser.internal.gallery~1of18
./hack/gotest.sh browser 'internal.gallery~1of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 1 of 18 of ./internal/gallery/ runs 6 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 71.302s
suite: browser.internal.gallery~1of18 took 92s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m15.140000s 0m3.220000s
--- shard 37 of 59 ---
==> shard 37 of 59: make browser.internal.gallery~2of18
./hack/gotest.sh browser 'internal.gallery~2of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 2 of 18 of ./internal/gallery/ runs 6 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 82.749s
suite: browser.internal.gallery~2of18 took 102s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m16.180000s 0m3.820000s
--- shard 38 of 59 ---
==> shard 38 of 59: make browser.internal.gallery~3of18
./hack/gotest.sh browser 'internal.gallery~3of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 3 of 18 of ./internal/gallery/ runs 6 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 102.320s
suite: browser.internal.gallery~3of18 took 120s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m17.500000s 0m4.270000s
--- shard 39 of 59 ---
==> shard 39 of 59: make browser.internal.gallery~4of18
./hack/gotest.sh browser 'internal.gallery~4of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 4 of 18 of ./internal/gallery/ runs 6 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 107.570s
suite: browser.internal.gallery~4of18 took 126s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m19.850000s 0m5.350000s
--- shard 40 of 59 ---
==> shard 40 of 59: make browser.internal.gallery~5of18
./hack/gotest.sh browser 'internal.gallery~5of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 5 of 18 of ./internal/gallery/ runs 6 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 105.046s
suite: browser.internal.gallery~5of18 took 125s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m17.930000s 0m4.650000s
--- shard 41 of 59 ---
==> shard 41 of 59: make browser.internal.gallery~6of18
./hack/gotest.sh browser 'internal.gallery~6of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 6 of 18 of ./internal/gallery/ runs 6 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 86.044s
suite: browser.internal.gallery~6of18 took 106s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m16.220000s 0m3.790000s
--- shard 42 of 59 ---
==> shard 42 of 59: make browser.internal.gallery~7of18
./hack/gotest.sh browser 'internal.gallery~7of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 7 of 18 of ./internal/gallery/ runs 5 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 76.814s
suite: browser.internal.gallery~7of18 took 97s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m14.600000s 0m2.810000s
--- shard 43 of 59 ---
==> shard 43 of 59: make browser.internal.gallery~8of18
./hack/gotest.sh browser 'internal.gallery~8of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 8 of 18 of ./internal/gallery/ runs 5 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 97.726s
suite: browser.internal.gallery~8of18 took 116s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m19.210000s 0m5.310000s
--- shard 44 of 59 ---
==> shard 44 of 59: make browser.internal.gallery~9of18
./hack/gotest.sh browser 'internal.gallery~9of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 9 of 18 of ./internal/gallery/ runs 5 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 114.893s
suite: browser.internal.gallery~9of18 took 135s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m23.280000s 0m7.120000s
--- shard 45 of 59 ---
==> shard 45 of 59: make browser.internal.gallery~10of18
./hack/gotest.sh browser 'internal.gallery~10of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 10 of 18 of ./internal/gallery/ runs 2 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 87.080s
suite: browser.internal.gallery~10of18 took 106s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m14.740000s 0m2.910000s
--- shard 46 of 59 ---
==> shard 46 of 59: make browser.internal.gallery~11of18
./hack/gotest.sh browser 'internal.gallery~11of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 11 of 18 of ./internal/gallery/ runs 2 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 90.627s
suite: browser.internal.gallery~11of18 took 111s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m14.980000s 0m2.880000s
--- shard 47 of 59 ---
==> shard 47 of 59: make browser.internal.gallery~12of18
./hack/gotest.sh browser 'internal.gallery~12of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 12 of 18 of ./internal/gallery/ runs 2 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 121.420s
suite: browser.internal.gallery~12of18 took 142s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m19.430000s 0m4.920000s
--- shard 48 of 59 ---
==> shard 48 of 59: make browser.internal.gallery~13of18
./hack/gotest.sh browser 'internal.gallery~13of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 13 of 18 of ./internal/gallery/ runs 3 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 119.300s
suite: browser.internal.gallery~13of18 took 139s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m20.090000s 0m5.400000s
--- shard 49 of 59 ---
==> shard 49 of 59: make browser.internal.gallery~14of18
./hack/gotest.sh browser 'internal.gallery~14of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 14 of 18 of ./internal/gallery/ runs 4 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 119.675s
suite: browser.internal.gallery~14of18 took 141s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m20.380000s 0m5.430000s
--- shard 50 of 59 ---
==> shard 50 of 59: make browser.internal.gallery~15of18
./hack/gotest.sh browser 'internal.gallery~15of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 15 of 18 of ./internal/gallery/ runs 4 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 116.590s
suite: browser.internal.gallery~15of18 took 136s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m20.520000s 0m5.630000s
--- shard 51 of 59 ---
==> shard 51 of 59: make browser.internal.gallery~16of18
./hack/gotest.sh browser 'internal.gallery~16of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 16 of 18 of ./internal/gallery/ runs 5 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 108.286s
suite: browser.internal.gallery~16of18 took 130s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m17.090000s 0m4.260000s
--- shard 52 of 59 ---
==> shard 52 of 59: make browser.internal.gallery~17of18
./hack/gotest.sh browser 'internal.gallery~17of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 17 of 18 of ./internal/gallery/ runs 5 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 114.957s
suite: browser.internal.gallery~17of18 took 135s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m20.760000s 0m5.920000s
--- shard 53 of 59 ---
==> shard 53 of 59: make browser.internal.gallery~18of18
./hack/gotest.sh browser 'internal.gallery~18of18'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 18 of 18 of ./internal/gallery/ runs 5 of 83 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery 114.011s
suite: browser.internal.gallery~18of18 took 134s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m19.720000s 0m5.410000s
--- shard 54 of 59 ---
==> shard 54 of 59: make browser.internal.gallery.history
./hack/gotest.sh browser 'internal.gallery.history'
gotest: on ip-172-31-26-150, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: ./internal/gallery/history/ runs its 3 browser tests
ok amadan.net/rastrillo/fiesta/internal/gallery/history 72.785s
suite: browser.internal.gallery.history took 88s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m22.570000s 0m2.370000s
--- shard 55 of 59 ---
==> shard 55 of 59: make browser.internal.www~1of4
./hack/gotest.sh browser 'internal.www~1of4'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 1 of 4 of ./internal/www/ runs 4 of 22 browser tests
ok amadan.net/rastrillo/fiesta/internal/www 114.384s
suite: browser.internal.www~1of4 took 131s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m33.050000s 0m2.380000s
--- shard 56 of 59 ---
==> shard 56 of 59: make browser.internal.www~2of4
./hack/gotest.sh browser 'internal.www~2of4'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 2 of 4 of ./internal/www/ runs 6 of 22 browser tests
ok amadan.net/rastrillo/fiesta/internal/www 118.123s
suite: browser.internal.www~2of4 took 136s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m46.690000s 0m3.070000s
--- shard 57 of 59 ---
==> shard 57 of 59: make browser.internal.www~3of4
./hack/gotest.sh browser 'internal.www~3of4'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 3 of 4 of ./internal/www/ runs 6 of 22 browser tests
ok amadan.net/rastrillo/fiesta/internal/www 124.512s
suite: browser.internal.www~3of4 took 144s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m53.130000s 0m3.130000s
--- shard 58 of 59 ---
==> shard 58 of 59: make browser.internal.www~4of4
./hack/gotest.sh browser 'internal.www~4of4'
gotest: on ip-172-31-26-150, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 4 of 4 of ./internal/www/ runs 6 of 22 browser tests
ok amadan.net/rastrillo/fiesta/internal/www 126.615s
suite: browser.internal.www~4of4 took 144s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m47.260000s 0m3.130000s
amadan: job failed at step suite shard 25 of 59 — its output is above, not at the tail of this log
Intent
diff --git a/.amadan/ci.d/50-suite@48 b/.amadan/ci.d/50-suite@59| similarity index 100% |
| rename from .amadan/ci.d/50-suite@48 |
| rename to .amadan/ci.d/50-suite@59 |
diff --git a/Makefile b/Makefile| index f9f6c00..febe73f 100644 |
| --- a/Makefile |
| +++ b/Makefile |
| @@ -64,7 +64,7 @@ ci: gofmt no-rastrillo size history suite |
| # the two axe sweeps, the HTML tab's renders, the floors drive). The |
| # tasks that add a browser package append here and rename 50-suite@N |
| # to match. |
| -BROWSER_PKGS := internal/harness check@13 internal/gallery@18 internal/gallery/history internal/www@4 |
| +BROWSER_PKGS := internal/harness check@24 internal/gallery@18 internal/gallery/history internal/www@4 |
| ROOT_SPLIT := internal/gallery@3 cmd/fiesta@2 internal/www@2 |
| go-roles = $(foreach p,$(2),$(if $(findstring @,$(p)),$(call go-slices,$(1),$(subst /,.,$(word 1,$(subst @, ,$(p)))),$(word 2,$(subst @, ,$(p)))),$(1).$(subst /,.,$(p)))) |
| go-slices = $(foreach k,$(shell seq 1 $(3)),$(1).$(2)~$(k)of$(3)) |
diff --git a/check/oneoh_browser_test.go b/check/oneoh_browser_test.go| index bbc5578..beedd82 100644 |
| --- a/check/oneoh_browser_test.go |
| +++ b/check/oneoh_browser_test.go |
| @@ -161,6 +161,13 @@ const imagesLoadedJS = `new Promise(r => { |
| .then(() => { clearTimeout(timer); done(); }); |
| })` |
| +// oneOhShotBudget is how long one photograph may take. A shot takes |
| +// about a tenth of a second; the budget is there so a page or a |
| +// browser that hangs fails as that shot, named, within a minute, |
| +// rather than as the whole part running into its own deadline with no |
| +// word of where it stopped (which is how a fleet run once read). |
| +const oneOhShotBudget = 60 * time.Second |
| + |
| // oneOhShot photographs one side's copy of a document in one leg. |
| // Before the photograph every picture has loaded and the rig has seen |
| // no failed request or response of 400 or more, or the test fails |
| @@ -172,6 +179,15 @@ func oneOhShot(t *testing.T, rig *harness.Rig, ctx context.Context, side, doc st |
| url += "?" + rtlQuery |
| } |
| where := fmt.Sprintf("%s's %s at %s", side, doc, leg) |
| + ctx, cancel := context.WithTimeout(ctx, oneOhShotBudget) |
| + defer cancel() |
| + // mustRun fails the test from inside the shot; this runs as that |
| + // failure unwinds, and says which shot it was. |
| + defer func() { |
| + if ctx.Err() == context.DeadlineExceeded { |
| + t.Errorf("%s: no answer within %s; the page or the browser hung", where, oneOhShotBudget) |
| + } |
| + }() |
| return pageShotChecked(t, ctx, url, leg.width, leg.scheme, func() { |
| var broken []string |
| mustRun(t, ctx, chromedp.Evaluate(imagesLoadedJS, &broken, awaitPromise)) |
| @@ -182,15 +198,37 @@ func oneOhShot(t *testing.T, rig *harness.Rig, ctx context.Context, side, doc st |
| }) |
| } |
| +// oneOhTries is how many pairs a leg may take before a difference is |
| +// believed. One frozen state (api-tokens' secret, with its autofocused |
| +// callout) photographs a rounded corner one level apart on two loads |
| +// of the same page under the same stylesheet: 1 pair in 60 on docs-t1, |
| +// and once on the fleet. A difference the CSS makes is there in every |
| +// pair; one that comes and goes is the renderer's, so the leg fails |
| +// only when every pair differs, still at zero tolerance. |
| +const oneOhTries = 3 |
| + |
| // sameOneOh photographs doc on both sides in each leg and fails each |
| -// leg whose pictures differ by a single pixel. |
| +// leg whose pictures differ by a single pixel in every one of |
| +// oneOhTries pairs. |
| func sameOneOh(t *testing.T, rig *harness.Rig, ctx context.Context, doc string, legs []oneOhLeg) { |
| t.Helper() |
| + name := strings.TrimSuffix(doc, ".html") |
| for _, leg := range legs { |
| - was := oneOhShot(t, rig, ctx, "old", doc, leg) |
| - is := oneOhShot(t, rig, ctx, "new", doc, leg) |
| - if ok, why := samePixelsWithin(t, was, is, 0); !ok { |
| - t.Errorf("1.0.0's %s at %s renders differently under the tree's CSS: %s", strings.TrimSuffix(doc, ".html"), leg, why) |
| + var whys []string |
| + for len(whys) < oneOhTries { |
| + was := oneOhShot(t, rig, ctx, "old", doc, leg) |
| + is := oneOhShot(t, rig, ctx, "new", doc, leg) |
| + ok, why := samePixelsWithin(t, was, is, 0) |
| + if ok { |
| + break |
| + } |
| + whys = append(whys, why) |
| + } |
| + switch { |
| + case len(whys) == oneOhTries: |
| + t.Errorf("1.0.0's %s at %s renders differently under the tree's CSS: %s", name, leg, strings.Join(whys, "; ")) |
| + case len(whys) > 0: |
| + t.Logf("1.0.0's %s at %s differed (%s), then agreed: the renderer, not the CSS", name, leg, strings.Join(whys, "; ")) |
| } |
| } |
| } |
| @@ -229,25 +267,24 @@ func oneOhLayoutLegs(scheme, media string) []oneOhLeg { |
| return legs |
| } |
| -// oneOhLayoutsRender is the k-th of the three parts of |
| -// TestOneOhLayoutsRenderAsTheyDid: the seven layouts in one theme, in |
| -// both schemes, and in Day also under forced colours and under print |
| -// at 1280 and 390, the two media whose rules no screen photograph |
| -// reaches. |
| +// oneOhLayoutsRender is the k-th of the six parts of |
| +// TestOneOhLayoutsRenderAsTheyDid: the seven layouts in one theme and |
| +// one scheme, and in Day light also under forced colours and under |
| +// print at 1280 and 390, the two media whose rules no screen |
| +// photograph reaches. Six parts, one a theme and scheme, so each runs |
| +// in well under its deadline on the fleet. |
| func oneOhLayoutsRender(t *testing.T, k int) { |
| themes := fiesta.ThemeNames() |
| if len(themes) != 3 { |
| - t.Fatalf("fiesta ships %d themes, and this test is dealt into three parts, one a theme", len(themes)) |
| + t.Fatalf("fiesta ships %d themes, and this test is dealt into six parts, one a theme and scheme", len(themes)) |
| } |
| - theme := themes[k] |
| + theme, scheme := themes[k/2], []string{"light", "dark"}[k%2] |
| layouts := oneOhLayouts(t) |
| rig, ctx := oneOhRig(t, theme, nil) |
| for _, layout := range layouts { |
| - for _, scheme := range []string{"light", "dark"} { |
| - sameOneOh(t, rig, ctx, layout+"/default.html", oneOhLayoutLegs(scheme, "screen")) |
| - } |
| + sameOneOh(t, rig, ctx, layout+"/default.html", oneOhLayoutLegs(scheme, "screen")) |
| } |
| - if theme != "day" { |
| + if theme != "day" || scheme != "light" { |
| return |
| } |
| for _, m := range []struct { |
| @@ -269,9 +306,12 @@ func oneOhLayoutsRender(t *testing.T, k int) { |
| } |
| } |
| -func TestOneOhLayoutsRenderAsTheyDid1of3(t *testing.T) { oneOhLayoutsRender(t, 0) } |
| -func TestOneOhLayoutsRenderAsTheyDid2of3(t *testing.T) { oneOhLayoutsRender(t, 1) } |
| -func TestOneOhLayoutsRenderAsTheyDid3of3(t *testing.T) { oneOhLayoutsRender(t, 2) } |
| +func TestOneOhLayoutsRenderAsTheyDid1of6(t *testing.T) { oneOhLayoutsRender(t, 0) } |
| +func TestOneOhLayoutsRenderAsTheyDid2of6(t *testing.T) { oneOhLayoutsRender(t, 1) } |
| +func TestOneOhLayoutsRenderAsTheyDid3of6(t *testing.T) { oneOhLayoutsRender(t, 2) } |
| +func TestOneOhLayoutsRenderAsTheyDid4of6(t *testing.T) { oneOhLayoutsRender(t, 3) } |
| +func TestOneOhLayoutsRenderAsTheyDid5of6(t *testing.T) { oneOhLayoutsRender(t, 4) } |
| +func TestOneOhLayoutsRenderAsTheyDid6of6(t *testing.T) { oneOhLayoutsRender(t, 5) } |
| // oneOhStates is every non-layout state of 1.0.0's examples, as |
| // <name>/<state>.html, in its manifest's order. Fewer than 150 is a |
| @@ -319,7 +359,11 @@ func oneOhExamplesRender(t *testing.T, k, n int) { |
| } |
| } |
| -func TestEveryOneOhExampleRendersAsItDid1of4(t *testing.T) { oneOhExamplesRender(t, 0, 4) } |
| -func TestEveryOneOhExampleRendersAsItDid2of4(t *testing.T) { oneOhExamplesRender(t, 1, 4) } |
| -func TestEveryOneOhExampleRendersAsItDid3of4(t *testing.T) { oneOhExamplesRender(t, 2, 4) } |
| -func TestEveryOneOhExampleRendersAsItDid4of4(t *testing.T) { oneOhExamplesRender(t, 3, 4) } |
| +func TestEveryOneOhExampleRendersAsItDid1of8(t *testing.T) { oneOhExamplesRender(t, 0, 8) } |
| +func TestEveryOneOhExampleRendersAsItDid2of8(t *testing.T) { oneOhExamplesRender(t, 1, 8) } |
| +func TestEveryOneOhExampleRendersAsItDid3of8(t *testing.T) { oneOhExamplesRender(t, 2, 8) } |
| +func TestEveryOneOhExampleRendersAsItDid4of8(t *testing.T) { oneOhExamplesRender(t, 3, 8) } |
| +func TestEveryOneOhExampleRendersAsItDid5of8(t *testing.T) { oneOhExamplesRender(t, 4, 8) } |
| +func TestEveryOneOhExampleRendersAsItDid6of8(t *testing.T) { oneOhExamplesRender(t, 5, 8) } |
| +func TestEveryOneOhExampleRendersAsItDid7of8(t *testing.T) { oneOhExamplesRender(t, 6, 8) } |
| +func TestEveryOneOhExampleRendersAsItDid8of8(t *testing.T) { oneOhExamplesRender(t, 7, 8) } |
diff --git a/hack/test-weights.txt b/hack/test-weights.txt| index a110a36..78b2fa2 100644 |
| --- a/hack/test-weights.txt |
| +++ b/hack/test-weights.txt |
| @@ -16,23 +16,31 @@ |
| # fleet run once Fiesta's CI is routed there: the fleet is arm64 with |
| # its own Chromium and fonts, and these weights are docs-t1's. The |
| # exceptions are the 1.0 photographs (TestOneOhLayoutsRenderAsTheyDid*, |
| -# TestEveryOneOhExampleRendersAsItDid*): each is how much its check |
| -# slice grew on the fleet run that added it (7b71b5b against 162deaf), |
| -# since that log does not time single tests. |
| -browser check TestOneOhLayoutsRenderAsTheyDid1of3 52 |
| -browser check TestEveryOneOhExampleRendersAsItDid4of4 49 |
| -browser check TestEveryOneOhExampleRendersAsItDid2of4 46 |
| -browser check TestEveryOneOhExampleRendersAsItDid3of4 45 |
| +# TestEveryOneOhExampleRendersAsItDid*), which are fleet seconds: each |
| +# part's docs-t1 time scaled by 1.17, the ratio its unsplit parts ran |
| +# at on the fleet (7b71b5b's slices against 162deaf's, since that log |
| +# does not time single tests). |
| browser check TestEveryThemeAndShellRendersAsTheBaseline 45 |
| -browser check TestEveryOneOhExampleRendersAsItDid1of4 44 |
| browser check TestEveryThemeRendersAsItDidExceptDay 44 |
| browser check TestEveryExampleStateMeetsTheFloorsWithAMouse 40 |
| -browser check TestOneOhLayoutsRenderAsTheyDid2of3 39 |
| browser check TestTheReleaseRendersAsTheSource 38 |
| -browser check TestOneOhLayoutsRenderAsTheyDid3of3 36 |
| +browser check TestOneOhLayoutsRenderAsTheyDid1of6 28 |
| +browser check TestEveryOneOhExampleRendersAsItDid2of8 26 |
| +browser check TestEveryOneOhExampleRendersAsItDid6of8 24 |
| +browser check TestEveryOneOhExampleRendersAsItDid4of8 23 |
| browser check TestBusyButtonDrive 22 |
| browser check TestEveryExampleStateMeetsTheFloorsOnAPhone 22 |
| +browser check TestEveryOneOhExampleRendersAsItDid1of8 22 |
| +browser check TestEveryOneOhExampleRendersAsItDid3of8 22 |
| +browser check TestEveryOneOhExampleRendersAsItDid5of8 22 |
| +browser check TestEveryOneOhExampleRendersAsItDid7of8 22 |
| +browser check TestEveryOneOhExampleRendersAsItDid8of8 22 |
| +browser check TestOneOhLayoutsRenderAsTheyDid6of6 21 |
| +browser check TestOneOhLayoutsRenderAsTheyDid5of6 20 |
| browser check TestAnyAccentKeepsTheFillLabelReadable 19 |
| +browser check TestOneOhLayoutsRenderAsTheyDid2of6 18 |
| +browser check TestOneOhLayoutsRenderAsTheyDid3of6 18 |
| +browser check TestOneOhLayoutsRenderAsTheyDid4of6 18 |
| browser check TestTheLightStaysWithinItsFrameBudget 17 |
| browser check TestTheProfileMenuIsADropUpAtTheRailsFoot 16 |
| browser check TestFlatThemesFollowAnAppsOverrides 13 |