rastrillo / fiesta Public

Apply the copy review, and say transition.js loads before the rest

The 1.2.0 changelog entry and the gallery's transition.js line are Luna's. The README bullet is Luna's with the clause that it is the one exception to the load order. ScriptNames' comment and the gallery's scriptOrder say the list is the order for the deferred scripts and that transition.js loads before the stylesheets. drafts.json records the new English for the 11 drafted translations.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude 1 day ago 659fe416fc7a7367a47f5e1661ae56b05907ee3d parent 617e93d

6 files changed, +23 −20

CHANGELOG.md +6 −6
README.md +1 −1
fiesta.go +10 −9
internal/gallery/copy.go +1 −1
internal/gallery/i18n/drafts.json +1 −1
internal/gallery/started.go +4 −2

CI passed — run details

CI log

=== gofmt ===
=== no-rastrillo ===
go test -run '^(TestFiestaNeverImportsRastrillo|TestThePublicPackagesLinkNoBrowser)$' -count=1 .
ok  	amadan.net/rastrillo/fiesta	0.155s
=== size ===
go test ./internal/build -run '^TestTheOneLinkIsUnder25KiBGzipped$' -count=1 -v
=== RUN   TestTheOneLinkIsUnder25KiBGzipped
    build_test.go:138: fiesta-plain.css: 158448 bytes, 23151 bytes gzipped (22.6 KiB of the 25.0 KiB limit)
    build_test.go:138: fiesta-signal.css: 158543 bytes, 23264 bytes gzipped (22.7 KiB of the 25.0 KiB limit)
    build_test.go:138: fiesta.css: 161362 bytes, 23870 bytes gzipped (23.3 KiB of the 25.0 KiB limit)
--- PASS: TestTheOneLinkIsUnder25KiBGzipped (0.02s)
PASS
ok  	amadan.net/rastrillo/fiesta/internal/build	0.027s
=== history ===
history: 20 commits; release tags: v1.0.0 v1.1.0
=== suite ===
--- shard 0 of 49 ---
==> shard 0 of 49: make root
go build ./...
go vet ./...
FIESTA_TEST_REQUIRE_NODE=1 FIESTA_TEST_REQUIRE_GIT=1 FIESTA_TEST_REQUIRE_TAGS=1 ./hack/gotest.sh root 'internal/gallery@3 cmd/fiesta@2 internal/www@2'
ok  	amadan.net/rastrillo/fiesta	3.204s
ok  	amadan.net/rastrillo/fiesta/check	12.919s
ok  	amadan.net/rastrillo/fiesta/example	0.181s
?   	amadan.net/rastrillo/fiesta/hack/seed/english	[no test files]
ok  	amadan.net/rastrillo/fiesta/internal/axe	0.077s
ok  	amadan.net/rastrillo/fiesta/internal/build	1.308s
ok  	amadan.net/rastrillo/fiesta/internal/codeview	0.006s
?   	amadan.net/rastrillo/fiesta/internal/harness	[no test files]
ok  	amadan.net/rastrillo/fiesta/internal/markup	0.005s
ok  	amadan.net/rastrillo/fiesta/internal/nodetest	0.323s
ok  	amadan.net/rastrillo/fiesta/internal/rowrule	0.007s
ok  	amadan.net/rastrillo/fiesta/internal/site	1.679s
ok  	amadan.net/rastrillo/fiesta/internal/tokens	0.004s
suite: root took 15s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m11.190000s 0m1.930000s
--- shard 1 of 49 ---
==> shard 1 of 49: make test.internal.gallery~1of3
FIESTA_TEST_REQUIRE_NODE=1 FIESTA_TEST_REQUIRE_GIT=1 FIESTA_TEST_REQUIRE_TAGS=1 ./hack/gotest.sh test 'internal.gallery~1of3'
gotest: slice 1 of 3 of ./internal/gallery/ runs 37 of 109 test tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	65.529s
suite: test.internal.gallery~1of3 took 67s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m47.800000s 0m1.290000s
--- shard 2 of 49 ---
==> shard 2 of 49: make test.internal.gallery~2of3
FIESTA_TEST_REQUIRE_NODE=1 FIESTA_TEST_REQUIRE_GIT=1 FIESTA_TEST_REQUIRE_TAGS=1 ./hack/gotest.sh test 'internal.gallery~2of3'
gotest: slice 2 of 3 of ./internal/gallery/ runs 36 of 109 test tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	70.112s
suite: test.internal.gallery~2of3 took 71s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m51.920000s 0m1.290000s
--- shard 3 of 49 ---
==> shard 3 of 49: make test.internal.gallery~3of3
FIESTA_TEST_REQUIRE_NODE=1 FIESTA_TEST_REQUIRE_GIT=1 FIESTA_TEST_REQUIRE_TAGS=1 ./hack/gotest.sh test 'internal.gallery~3of3'
gotest: slice 3 of 3 of ./internal/gallery/ runs 36 of 109 test tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	63.654s
suite: test.internal.gallery~3of3 took 65s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m45.860000s 0m1.100000s
--- shard 4 of 49 ---
==> shard 4 of 49: make test.cmd.fiesta~1of2
FIESTA_TEST_REQUIRE_NODE=1 FIESTA_TEST_REQUIRE_GIT=1 FIESTA_TEST_REQUIRE_TAGS=1 ./hack/gotest.sh test 'cmd.fiesta~1of2'
gotest: slice 1 of 2 of ./cmd/fiesta/ runs 8 of 13 test tests
ok  	amadan.net/rastrillo/fiesta/cmd/fiesta	59.980s
suite: test.cmd.fiesta~1of2 took 61s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m38.810000s 0m3.200000s
--- shard 5 of 49 ---
==> shard 5 of 49: make test.cmd.fiesta~2of2
FIESTA_TEST_REQUIRE_NODE=1 FIESTA_TEST_REQUIRE_GIT=1 FIESTA_TEST_REQUIRE_TAGS=1 ./hack/gotest.sh test 'cmd.fiesta~2of2'
gotest: slice 2 of 2 of ./cmd/fiesta/ runs 5 of 13 test tests
ok  	amadan.net/rastrillo/fiesta/cmd/fiesta	64.456s
suite: test.cmd.fiesta~2of2 took 66s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m44.450000s 0m2.630000s
--- shard 6 of 49 ---
==> shard 6 of 49: make test.internal.www~1of2
FIESTA_TEST_REQUIRE_NODE=1 FIESTA_TEST_REQUIRE_GIT=1 FIESTA_TEST_REQUIRE_TAGS=1 ./hack/gotest.sh test 'internal.www~1of2'
gotest: slice 1 of 2 of ./internal/www/ runs 14 of 28 test tests
ok  	amadan.net/rastrillo/fiesta/internal/www	68.137s
suite: test.internal.www~1of2 took 70s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m49.650000s 0m1.560000s
--- shard 7 of 49 ---
==> shard 7 of 49: make test.internal.www~2of2
FIESTA_TEST_REQUIRE_NODE=1 FIESTA_TEST_REQUIRE_GIT=1 FIESTA_TEST_REQUIRE_TAGS=1 ./hack/gotest.sh test 'internal.www~2of2'
gotest: slice 2 of 2 of ./internal/www/ runs 14 of 28 test tests
ok  	amadan.net/rastrillo/fiesta/internal/www	68.443s
suite: test.internal.www~2of2 took 70s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m50.530000s 0m1.710000s
--- shard 8 of 49 ---
==> shard 8 of 49: make staticcheck
go run honnef.co/go/tools/cmd/staticcheck@v0.8.2 -tags browser ./...
suite: staticcheck took 1s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m0.570000s 0m0.230000s
--- shard 9 of 49 ---
==> shard 9 of 49: make govulncheck
go run golang.org/x/vuln/cmd/govulncheck@v1.8.0 ./...
=== Symbol Results ===

No vulnerabilities found.

Your code is affected by 0 vulnerabilities.
This scan also found 2 vulnerabilities in packages you import and 5
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.
suite: govulncheck took 4s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m3.340000s 0m0.420000s
--- shard 10 of 49 ---
==> shard 10 of 49: make gitleaks
go run github.com/zricethezav/gitleaks/v8@v8.30.1 git --no-banner --redact --log-opts='--full-history --diff-filter=tuxdb HEAD' .
[90m6:17PM[0m [32mINF[0m [1mUnknown SCM platform. Use --platform to include links in findings.[0m [36mhost=[0mamadan.net
[90m6:17PM[0m [32mINF[0m [1m20 commits scanned.[0m
[90m6:17PM[0m [32mINF[0m [1mscanned ~10375514 bytes (10.38 MB) in 2.79s[0m
[90m6:17PM[0m [32mINF[0m [1mno leaks found[0m
suite: gitleaks took 3s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m9.130000s 0m0.200000s
--- shard 11 of 49 ---
==> shard 11 of 49: make browser.internal.harness
./hack/gotest.sh browser 'internal.harness'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: ./internal/harness/ runs its 10 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/harness	4.431s
suite: browser.internal.harness took 6s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m1.640000s 0m1.360000s
--- shard 12 of 49 ---
==> shard 12 of 49: make browser.check~1of14
./hack/gotest.sh browser 'check~1of14'
gotest: on ip-172-31-31-194, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 1 of 14 of ./check/ runs 17 of 238 browser tests
ok  	amadan.net/rastrillo/fiesta/check	106.078s
suite: browser.check~1of14 took 109s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m50.100000s 0m16.210000s
--- shard 13 of 49 ---
==> shard 13 of 49: make browser.check~2of14
./hack/gotest.sh browser 'check~2of14'
gotest: on ip-172-31-31-194, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 2 of 14 of ./check/ runs 17 of 238 browser tests
ok  	amadan.net/rastrillo/fiesta/check	104.235s
suite: browser.check~2of14 took 107s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m45.470000s 0m13.370000s
--- shard 14 of 49 ---
==> shard 14 of 49: make browser.check~3of14
./hack/gotest.sh browser 'check~3of14'
gotest: on ip-172-31-31-194, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 3 of 14 of ./check/ runs 16 of 238 browser tests
ok  	amadan.net/rastrillo/fiesta/check	101.944s
suite: browser.check~3of14 took 105s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m40.190000s 0m16.480000s
--- shard 15 of 49 ---
==> shard 15 of 49: make browser.check~4of14
./hack/gotest.sh browser 'check~4of14'
gotest: on ip-172-31-31-194, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 4 of 14 of ./check/ runs 17 of 238 browser tests
ok  	amadan.net/rastrillo/fiesta/check	109.873s
suite: browser.check~4of14 took 113s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m52.550000s 0m17.210000s
--- shard 16 of 49 ---
==> shard 16 of 49: make browser.check~5of14
./hack/gotest.sh browser 'check~5of14'
gotest: on ip-172-31-31-194, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 5 of 14 of ./check/ runs 17 of 238 browser tests
ok  	amadan.net/rastrillo/fiesta/check	101.848s
suite: browser.check~5of14 took 105s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m50.640000s 0m24.830000s
--- shard 17 of 49 ---
==> shard 17 of 49: make browser.check~6of14
./hack/gotest.sh browser 'check~6of14'
gotest: on ip-172-31-31-194, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 6 of 14 of ./check/ runs 18 of 238 browser tests
ok  	amadan.net/rastrillo/fiesta/check	93.178s
suite: browser.check~6of14 took 96s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m38.600000s 0m14.920000s
--- shard 18 of 49 ---
==> shard 18 of 49: make browser.check~7of14
./hack/gotest.sh browser 'check~7of14'
gotest: on ip-172-31-31-194, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 7 of 14 of ./check/ runs 18 of 238 browser tests
ok  	amadan.net/rastrillo/fiesta/check	94.272s
suite: browser.check~7of14 took 97s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m42.520000s 0m15.230000s
--- shard 19 of 49 ---
==> shard 19 of 49: make browser.check~8of14
./hack/gotest.sh browser 'check~8of14'
gotest: on ip-172-31-31-194, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 8 of 14 of ./check/ runs 17 of 238 browser tests
ok  	amadan.net/rastrillo/fiesta/check	105.717s
suite: browser.check~8of14 took 109s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m52.620000s 0m19.490000s
--- shard 20 of 49 ---
==> shard 20 of 49: make browser.check~9of14
./hack/gotest.sh browser 'check~9of14'
gotest: on ip-172-31-31-194, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 9 of 14 of ./check/ runs 17 of 238 browser tests
ok  	amadan.net/rastrillo/fiesta/check	109.232s
suite: browser.check~9of14 took 112s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m52.920000s 0m19.010000s
--- shard 21 of 49 ---
==> shard 21 of 49: make browser.check~10of14
./hack/gotest.sh browser 'check~10of14'
gotest: on ip-172-31-31-194, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 10 of 14 of ./check/ runs 17 of 238 browser tests
ok  	amadan.net/rastrillo/fiesta/check	91.478s
suite: browser.check~10of14 took 94s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m30.110000s 0m11.680000s
--- shard 22 of 49 ---
==> shard 22 of 49: make browser.check~11of14
./hack/gotest.sh browser 'check~11of14'
gotest: on ip-172-31-31-194, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 11 of 14 of ./check/ runs 17 of 238 browser tests
ok  	amadan.net/rastrillo/fiesta/check	95.878s
suite: browser.check~11of14 took 99s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m40.260000s 0m15.000000s
--- shard 23 of 49 ---
==> shard 23 of 49: make browser.check~12of14
./hack/gotest.sh browser 'check~12of14'
gotest: on ip-172-31-31-194, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 12 of 14 of ./check/ runs 16 of 238 browser tests
ok  	amadan.net/rastrillo/fiesta/check	100.277s
suite: browser.check~12of14 took 103s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m47.320000s 0m15.510000s
--- shard 24 of 49 ---
==> shard 24 of 49: make browser.check~13of14
./hack/gotest.sh browser 'check~13of14'
gotest: on ip-172-31-31-194, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 13 of 14 of ./check/ runs 17 of 238 browser tests
ok  	amadan.net/rastrillo/fiesta/check	108.375s
suite: browser.check~13of14 took 111s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m53.500000s 0m19.360000s
--- shard 25 of 49 ---
==> shard 25 of 49: make browser.check~14of14
./hack/gotest.sh browser 'check~14of14'
gotest: on ip-172-31-31-194, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: slice 14 of 14 of ./check/ runs 17 of 238 browser tests
ok  	amadan.net/rastrillo/fiesta/check	96.833s
suite: browser.check~14of14 took 100s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m44.320000s 0m15.030000s
--- shard 26 of 49 ---
==> shard 26 of 49: make browser.internal.gallery~1of18
./hack/gotest.sh browser 'internal.gallery~1of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 1 of 18 of ./internal/gallery/ runs 6 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	42.976s
suite: browser.internal.gallery~1of18 took 46s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m12.160000s 0m3.680000s
--- shard 27 of 49 ---
==> shard 27 of 49: make browser.internal.gallery~2of18
./hack/gotest.sh browser 'internal.gallery~2of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 2 of 18 of ./internal/gallery/ runs 5 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	52.746s
suite: browser.internal.gallery~2of18 took 56s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m11.190000s 0m3.090000s
--- shard 28 of 49 ---
==> shard 28 of 49: make browser.internal.gallery~3of18
./hack/gotest.sh browser 'internal.gallery~3of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 3 of 18 of ./internal/gallery/ runs 5 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	61.192s
suite: browser.internal.gallery~3of18 took 64s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m12.260000s 0m3.820000s
--- shard 29 of 49 ---
==> shard 29 of 49: make browser.internal.gallery~4of18
./hack/gotest.sh browser 'internal.gallery~4of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 4 of 18 of ./internal/gallery/ runs 5 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	52.543s
suite: browser.internal.gallery~4of18 took 55s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m10.930000s 0m3.040000s
--- shard 30 of 49 ---
==> shard 30 of 49: make browser.internal.gallery~5of18
./hack/gotest.sh browser 'internal.gallery~5of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 5 of 18 of ./internal/gallery/ runs 6 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	66.426s
suite: browser.internal.gallery~5of18 took 69s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m15.790000s 0m5.640000s
--- shard 31 of 49 ---
==> shard 31 of 49: make browser.internal.gallery~6of18
./hack/gotest.sh browser 'internal.gallery~6of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 6 of 18 of ./internal/gallery/ runs 5 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	59.338s
suite: browser.internal.gallery~6of18 took 62s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m12.830000s 0m3.970000s
--- shard 32 of 49 ---
==> shard 32 of 49: make browser.internal.gallery~7of18
./hack/gotest.sh browser 'internal.gallery~7of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 7 of 18 of ./internal/gallery/ runs 5 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	59.130s
suite: browser.internal.gallery~7of18 took 62s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m10.560000s 0m2.650000s
--- shard 33 of 49 ---
==> shard 33 of 49: make browser.internal.gallery~8of18
./hack/gotest.sh browser 'internal.gallery~8of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 8 of 18 of ./internal/gallery/ runs 5 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	61.963s
suite: browser.internal.gallery~8of18 took 65s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m14.740000s 0m4.750000s
--- shard 34 of 49 ---
==> shard 34 of 49: make browser.internal.gallery~9of18
./hack/gotest.sh browser 'internal.gallery~9of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 9 of 18 of ./internal/gallery/ runs 6 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	72.460s
suite: browser.internal.gallery~9of18 took 76s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m20.820000s 0m7.860000s
--- shard 35 of 49 ---
==> shard 35 of 49: make browser.internal.gallery~10of18
./hack/gotest.sh browser 'internal.gallery~10of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 10 of 18 of ./internal/gallery/ runs 2 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	65.423s
suite: browser.internal.gallery~10of18 took 68s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m10.850000s 0m2.670000s
--- shard 36 of 49 ---
==> shard 36 of 49: make browser.internal.gallery~11of18
./hack/gotest.sh browser 'internal.gallery~11of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 11 of 18 of ./internal/gallery/ runs 2 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	68.554s
suite: browser.internal.gallery~11of18 took 71s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m11.200000s 0m2.900000s
--- shard 37 of 49 ---
==> shard 37 of 49: make browser.internal.gallery~12of18
./hack/gotest.sh browser 'internal.gallery~12of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 12 of 18 of ./internal/gallery/ runs 2 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	70.782s
suite: browser.internal.gallery~12of18 took 73s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m15.820000s 0m5.050000s
--- shard 38 of 49 ---
==> shard 38 of 49: make browser.internal.gallery~13of18
./hack/gotest.sh browser 'internal.gallery~13of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 13 of 18 of ./internal/gallery/ runs 4 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	70.111s
suite: browser.internal.gallery~13of18 took 73s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m16.190000s 0m5.480000s
--- shard 39 of 49 ---
==> shard 39 of 49: make browser.internal.gallery~14of18
./hack/gotest.sh browser 'internal.gallery~14of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 14 of 18 of ./internal/gallery/ runs 5 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	72.186s
suite: browser.internal.gallery~14of18 took 75s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m16.260000s 0m5.370000s
--- shard 40 of 49 ---
==> shard 40 of 49: make browser.internal.gallery~15of18
./hack/gotest.sh browser 'internal.gallery~15of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 15 of 18 of ./internal/gallery/ runs 5 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	73.123s
suite: browser.internal.gallery~15of18 took 76s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m16.790000s 0m5.590000s
--- shard 41 of 49 ---
==> shard 41 of 49: make browser.internal.gallery~16of18
./hack/gotest.sh browser 'internal.gallery~16of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 16 of 18 of ./internal/gallery/ runs 5 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	68.473s
suite: browser.internal.gallery~16of18 took 71s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m13.560000s 0m4.590000s
--- shard 42 of 49 ---
==> shard 42 of 49: make browser.internal.gallery~17of18
./hack/gotest.sh browser 'internal.gallery~17of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 17 of 18 of ./internal/gallery/ runs 5 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	73.551s
suite: browser.internal.gallery~17of18 took 77s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m16.400000s 0m5.690000s
--- shard 43 of 49 ---
==> shard 43 of 49: make browser.internal.gallery~18of18
./hack/gotest.sh browser 'internal.gallery~18of18'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 18 of 18 of ./internal/gallery/ runs 6 of 84 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery	74.897s
suite: browser.internal.gallery~18of18 took 78s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m17.920000s 0m6.570000s
--- shard 44 of 49 ---
==> shard 44 of 49: make browser.internal.gallery.history
./hack/gotest.sh browser 'internal.gallery.history'
gotest: on ip-172-31-31-194, driving /opt/amadan-browser/chromium-1234/chrome-linux/chrome
gotest: ./internal/gallery/history/ runs its 3 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/gallery/history	35.150s
suite: browser.internal.gallery.history took 37s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m21.410000s 0m2.040000s
--- shard 45 of 49 ---
==> shard 45 of 49: make browser.internal.www~1of4
./hack/gotest.sh browser 'internal.www~1of4'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 1 of 4 of ./internal/www/ runs 5 of 24 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/www	83.848s
suite: browser.internal.www~1of4 took 87s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m38.280000s 0m2.300000s
--- shard 46 of 49 ---
==> shard 46 of 49: make browser.internal.www~2of4
./hack/gotest.sh browser 'internal.www~2of4'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 2 of 4 of ./internal/www/ runs 7 of 24 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/www	83.754s
suite: browser.internal.www~2of4 took 87s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m53.580000s 0m3.350000s
--- shard 47 of 49 ---
==> shard 47 of 49: make browser.internal.www~3of4
./hack/gotest.sh browser 'internal.www~3of4'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 3 of 4 of ./internal/www/ runs 6 of 24 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/www	85.994s
suite: browser.internal.www~3of4 took 89s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m52.820000s 0m3.090000s
--- shard 48 of 49 ---
==> shard 48 of 49: make browser.internal.www~4of4
./hack/gotest.sh browser 'internal.www~4of4'
gotest: on ip-172-31-31-194, driving the harness's own choice (/usr/local/bin/chromium)
gotest: slice 4 of 4 of ./internal/www/ runs 6 of 24 browser tests
ok  	amadan.net/rastrillo/fiesta/internal/www	83.887s
suite: browser.internal.www~4of4 took 87s; CPU, user then system, of this shell and then of the role:
0m0.000000s 0m0.000000s
0m46.480000s 0m3.110000s

Intent

full ledger: rastrillo-catch-up

diff --git a/CHANGELOG.md b/CHANGELOG.md

index 1c40855..8de4c1f 100644

--- a/CHANGELOG.md

+++ b/CHANGELOG.md

@@ -4,13 +4,13 @@

## 1.2.0

-Fiesta takes the fixes Rastrillo made to these files after Fiesta was copied from it. One of them changes how 1.0 markup looks: the console rail's current item draws its ring whole. Nothing else 1.0.0 or 1.1.0 styles looks or lays out differently.

+Fiesta includes fixes Rastrillo made to these files after Fiesta was copied from it. One changes how 1.0 markup looks: the current item in the console rail now shows its full ring and shadow. No other styles in 1.0.0 or 1.1.0 change appearance or layout.

-- The console rail's current item draws its ring and shadow whole. Before, the rail cut them off at its edges. No item moves. (Rastrillo cc7c9c69)

-- `shell.js` no longer logs an uncaught `AbortError` when the browser skips a page transition. It ignores only that skip, and any other error still shows. (Rastrillo d9c9ed13, 023740c5, e5e35a3e and 6b1c5478)

-- `transition.js` does the same for column, stage and topbar pages, which have no `shell.js`. Load it before the stylesheets, without `defer`: the browser can skip a transition before a deferred script runs. The column, stage and topbar examples load it. Sidebar and console pages don't need it.

-- `busy.js` leaves a form marked `data-live-form` to the script that sends it. A server that swaps forms in place sets the attribute, and its script marks each submit it takes with `liveForm`. `busy.js` shows the spinner only on a submit that script leaves to the browser. Without such a script, the attribute changes nothing. (Rastrillo 8548e455)

-- `fiesta.Sources()` says where each example state came from: the partial, idiom, shell, format or screen it was seeded from, which of its states, and its locale and view. A server can use it to check its templates against the examples.

+- The console rail's current item now shows its full ring and shadow. Previously, the rail clipped them at its edges. No item moves. (Rastrillo cc7c9c69)

+- `shell.js` no longer logs an uncaught `AbortError` when the browser skips a page transition. It ignores only this error; other errors are still logged. (Rastrillo d9c9ed13, 023740c5, e5e35a3e and 6b1c5478)

+- For column, stage and topbar pages without `shell.js`, `transition.js` does the same. Load it before the stylesheets, without `defer`: the browser can skip a transition before a deferred script runs. The column, stage and topbar examples load it. Sidebar and console pages don't need it.

+- `busy.js` leaves submits from a form marked `data-live-form` to the script that handles them. A server that swaps forms in place sets the attribute, and its script marks each submit it handles with `liveForm`. `busy.js` shows the spinner only when that script leaves a submit to the browser. Without such a script, the attribute has no effect. (Rastrillo 8548e455)

+- `fiesta.Sources()` reports the source of each example state: the partial, idiom, shell, format or screen it was seeded from, the state within that source, and its locale and view. A server can use it to check its templates against the examples.

## 1.1.0

diff --git a/README.md b/README.md

index 74044f1..9692d19 100644

--- a/README.md

+++ b/README.md

@@ -28,7 +28,7 @@ Everything works with scripts off. The scripts are enhancements, each its own fi

- `light.js` lights the page from where the sun is at this hour and puts the pointer's position on the button under it. Delete it and the page is the still design.

- `anchor.js` keeps a dropdown's menu on the screen in a browser without CSS anchor positioning.

- `shell.js` is phone navigation for the sidebar and console shells.

-- `transition.js` stops a page transition the browser skips from logging an error on a column, stage or topbar page. It is the one exception to the order: load it before the stylesheets, without `defer`. Sidebar and console pages don't need it, because `shell.js` does the same.

+- `transition.js` prevents an error when the browser skips a page transition on a column, stage or topbar page. Load it before the stylesheets, without `defer`, the one exception to the order above. Sidebar and console pages don't need it, because `shell.js` does the same.

- `copy.js` makes a snippet's Copy button copy its code, and keeps the button hidden where the browser has no clipboard.

- `select.js` makes a `<select data-rst-select>` searchable.

- `datetime.js` is the natural-language date field: "tomorrow", "next fri 9am", "in 2 weeks".

diff --git a/fiesta.go b/fiesta.go

index 22b24cc..0b2f313 100644

--- a/fiesta.go

+++ b/fiesta.go

@@ -73,15 +73,16 @@ func ThemeCSS(name string) ([]byte, bool) {

}

// scriptNames lists the optional scripts in the order a page that

-// wants them all would load them: fiesta.js first, since it restores a

-// remembered colour scheme and owns the menus every page has, busy and

-// light next, since they touch every button, the shells' navigation

-// after that, then the snippet's Copy button and the controls, and

-// calendar.js last because it is the grid datetime.js asks it for.

-// transition.js sits beside shell.js because it does shell.js's

-// transition work on a page without a shell, though such a page loads

-// it before its stylesheets rather than deferred. The slice matches the

-// files in js/ exactly.

+// wants them all would load them, deferred: fiesta.js first, since it

+// restores a remembered colour scheme and owns the menus every page

+// has, busy and light next, since they touch every button, the shells'

+// navigation after that, then the snippet's Copy button and the

+// controls, and calendar.js last because it is the grid datetime.js

+// asks it for. transition.js is the one script that is not deferred: a

+// page loads it before its stylesheets, since the browser can reject a

+// skipped transition before a deferred script runs. It is listed

+// beside shell.js because it does shell.js's transition work on a page

+// without a shell. The slice matches the files in js/ exactly.

var scriptNames = []string{"fiesta.js", "busy.js", "light.js", "anchor.js", "shell.js", "transition.js", "copy.js", "select.js", "datetime.js", "calendar.js"}

// ScriptNames returns the optional scripts' file names, in load order.

diff --git a/internal/gallery/copy.go b/internal/gallery/copy.go

index c3e85e3..2e40fd3 100644

--- a/internal/gallery/copy.go

+++ b/internal/gallery/copy.go

@@ -133,7 +133,7 @@ var text = map[string]string{

"gallery.started.file.light-js": "The light the depth styles read: shadows lit by the hour, and a sheen on the button under the pointer. Delete it for the still design.",

"gallery.started.file.anchor-js": "Keeps a dropdown's menu on the screen in browsers without CSS anchor positioning. It does nothing where they have it: delete it once every browser you support does.",

"gallery.started.file.shell-js": "Phone navigation for the sidebar and console shells: the slide between pages, Back that reuses history, and focus returned to the section you left. Deletable on its own.",

- "gallery.started.file.transition-js": "Stops a skipped page transition logging an error on column, stage and topbar pages. Load it before the stylesheets, without defer. Sidebar and console pages don't need it.",

+ "gallery.started.file.transition-js": "Prevents an error when the browser skips a page transition on column, stage and topbar pages. Load it before the stylesheets, without defer. Sidebar and console pages don't need it.",

"gallery.started.file.copy-js": "The snippet's Copy button: it copies the code, says Copied, and stays hidden where the browser has no clipboard. Deletable on its own.",

"gallery.started.file.select-js": "field-select's searchable combobox. Inert until a select opts in with data-rst-select, and deletable on its own.",

"gallery.started.file.datetime-js": "The date fields' natural-language input. Inert until a field opts in with data-rst-date or data-rst-time, and deletable on its own.",

diff --git a/internal/gallery/i18n/drafts.json b/internal/gallery/i18n/drafts.json

index e600b28..5edae3c 100644

--- a/internal/gallery/i18n/drafts.json

+++ b/internal/gallery/i18n/drafts.json

@@ -1280,7 +1280,7 @@

]

"gallery.started.file.transition-js": {

- "english": "Stops a skipped page transition logging an error on column, stage and topbar pages. Load it before the stylesheets, without defer. Sidebar and console pages don't need it.",

+ "english": "Prevents an error when the browser skips a page transition on column, stage and topbar pages. Load it before the stylesheets, without defer. Sidebar and console pages don't need it.",

"locales": [

"ar",

"bn",

diff --git a/internal/gallery/started.go b/internal/gallery/started.go

index 49c0aea..61c38c5 100644

--- a/internal/gallery/started.go

+++ b/internal/gallery/started.go

@@ -41,8 +41,10 @@ type assetsView struct {

// scriptOrder is the order the scripts are listed in: fiesta.js first

// and calendar.js last, as the page says to load them, the rest as the

-// scripts paragraph names them. A script in the release and not here

-// fails the render by name, so a new script cannot ship off this page.

+// scripts paragraph names them. That is the order for the deferred

+// scripts; transition.js's row says it loads before the stylesheets.

+// A script in the release and not here fails the render by name, so a

+// new script cannot ship off this page.

var scriptOrder = []string{"fiesta.js", "busy.js", "light.js", "anchor.js", "shell.js", "transition.js", "copy.js", "select.js", "datetime.js", "calendar.js"}

// blurbs is the copy id of each shipped file whose sentence has no