amadan

rastrillo / fiesta Public

← Discussions

Test evidence: The CSS, scripts and icons, from rastrillo at SEED open

On branch fiesta-1

claude operated by paul@keymail.dev session 92c0689a · claude-code/2.1.310 · DOCS-T1

Test evidence for Task 2 of the Fiesta packaging, copied from the implementer's report so it sits on the branch.

Commits

  • 6510f90 The CSS, scripts and icons, from rastrillo at SEED
  • 0e9be0f DESIGN.md and design.json, from rastrillo at SEED, in Fiesta's words (after copy review; no Go changed)
  • a06d9e8 Carry Lucide's whole licence, and refuse a stylesheet with no baseline (fix round 1)

RED: a stub fiesta.go with no go:embed, css/ absent

go test -count=1 . ./check/:

--- FAIL: TestTheStylesheetsAreEmbedded (0.00s)
    fiesta_test.go:66: TokensCSS() is empty
    fiesta_test.go:66: ShellCSS() is empty
--- FAIL: TestEveryThemeIsEmbedded (0.00s)
    fiesta_test.go:78: ThemeNames() = [], want ["day" "plain" "signal"]
--- FAIL: TestEveryScriptIsEmbedded (0.00s)
    fiesta_test.go:108: ScriptNames() = [], want ["busy.js" "light.js" "anchor.js" "shell.js" "select.js" "datetime.js" "calendar.js"]
--- FAIL: TestEveryIconIsOneLucideSVG (0.00s)
    fiesta_test.go:141: IconSlugs() lists 0 slugs, want 12: []
--- FAIL: TestNamesAreCopies (0.00s)
    fiesta_test.go:198: ThemeNames() is empty
--- FAIL: TestTheLicenseIsMPL (0.00s)
    fiesta_test.go:212: License() does not start "Mozilla Public License Version 2.0": ""
    fiesta_test.go:214: FS() is nil; the embedded tree is missing
--- FAIL: TestTheVersionIsSemver (0.00s)
    fiesta_test.go:227: Version = "", want "1.0.0"
FAIL	amadan.net/rastrillo/fiesta	0.047s
--- FAIL: TestTheSourceIsTheSyncedBaseline (0.00s)
    baseline_test.go:36: css/tokens.css: open ../css/tokens.css: no such file or directory
    ... (all five stylesheets)
FAIL	amadan.net/rastrillo/fiesta/check	0.002s

GREEN

cmp of each of the 12 css/ and js/ files against git show e14b745:ui/<path>, and of each baseline file against its css/ twin: no output. go test -count=1 -v . ./check/: every test above PASS; ok amadan.net/rastrillo/fiesta, ok amadan.net/rastrillo/fiesta/check. make ci green before the commit and again on it.

Negative control: a changed stylesheet

Scratch copy, last byte of css/themes/day.css changed (cmp: "differ: byte 27788, line 422"):

--- FAIL: TestTheSourceIsTheSyncedBaseline (0.00s)
    baseline_test.go:49: css/themes/day.css differs from its baseline check/testdata/seed/day.css (27788 bytes vs 27788); the CSS is frozen at the synced commit, so either revert it or sync the baseline with it

Fix round 1 (a06d9e8)

Important 1, the Lucide licence. The coordinator's strings ("MIT", "Cole Bemis") were already in the old hybrid file, so the test stayed green with them; the MIT notice itself was pinned instead.

RED (old file):

fiesta_test.go:234: icons/LICENSE-lucide.txt does not mention "The MIT License (MIT)"
fiesta_test.go:234: icons/LICENSE-lucide.txt does not mention "Copyright (c) 2013-present Cole Bemis"
fiesta_test.go:234: icons/LICENSE-lucide.txt does not mention "Permission is hereby granted, free of charge"
--- FAIL: TestTheLicenseIsMPL

GREEN (upstream file): ok amadan.net/rastrillo/fiesta.

Minor 1, the baseline test walks css/. RED (scratch copy with css/extra.css added):

--- FAIL: TestTheSourceIsTheSyncedBaseline (0.00s)
    baseline_test.go:70: css/extra.css has no baseline twin under check/testdata/seed/; every file in css/ is synced from rastrillo and named in this test

GREEN on the real tree: ok amadan.net/rastrillo/fiesta/check.