oficina / sheets Public

Keep workbook fixtures outside the application discovery root

Paul Campbell pushed by paul@keymail.dev 1 month ago 55e98af865786d8792fb32100ecaafbc5c75d279 parent 7504fdc

5 files changed, +2 −2

docs/superpowers/plans/2026-09-07-workbook-import-fidelity.md +1 −1
internal/sheets/workbook_import_readiness_test.go +1 −1
{internal/testdata => testdata}/workbook-regressions/cross-reference-first.xlsx binary
{internal/testdata => testdata}/workbook-regressions/cross-reference-later.xlsx binary
{internal/testdata => testdata}/workbook-regressions/two-worksheets.xlsx binary

diff --git a/docs/superpowers/plans/2026-09-07-workbook-import-fidelity.md b/docs/superpowers/plans/2026-09-07-workbook-import-fidelity.md

index 6bfb9aa..dac2d9b 100644

--- a/docs/superpowers/plans/2026-09-07-workbook-import-fidelity.md

+++ b/docs/superpowers/plans/2026-09-07-workbook-import-fidelity.md

@@ -32,4 +32,4 @@ No tab deletion, cross-tab formula implementation, formula rewriting, row/column

## Verification candidate

-internal/sheets/workbook_import_readiness_test.go exercises actual runImport and the authenticated export route with fixtures in internal/testdata/workbook-regressions. Current expected red cases are one retained tab/worksheet and later unsupported-formula publication; the first-tab refusal control is green and checks the failure coordinate. No implementation is hidden behind these tests. Root owns the Fable allocation and all integrations/deployments.

+internal/sheets/workbook_import_readiness_test.go exercises actual runImport and the authenticated export route with fixtures in testdata/workbook-regressions. Current expected red cases are one retained tab/worksheet and later unsupported-formula publication; the first-tab refusal control is green and checks the failure coordinate. No implementation is hidden behind these tests. Root owns the Fable allocation and all integrations/deployments.

diff --git a/internal/sheets/workbook_import_readiness_test.go b/internal/sheets/workbook_import_readiness_test.go

index d07686e..fca53be 100644

--- a/internal/sheets/workbook_import_readiness_test.go

+++ b/internal/sheets/workbook_import_readiness_test.go

@@ -16,7 +16,7 @@ import (

func workbookReadinessFixture(t *testing.T, name string) []byte {

t.Helper()

- data, err := os.ReadFile("../testdata/workbook-regressions/" + name + ".xlsx")

+ data, err := os.ReadFile("../../testdata/workbook-regressions/" + name + ".xlsx")

if err != nil {

t.Fatal(err)

}

diff --git a/internal/testdata/workbook-regressions/cross-reference-first.xlsx b/testdata/workbook-regressions/cross-reference-first.xlsx

similarity index 100%

rename from internal/testdata/workbook-regressions/cross-reference-first.xlsx

rename to testdata/workbook-regressions/cross-reference-first.xlsx

diff --git a/internal/testdata/workbook-regressions/cross-reference-later.xlsx b/testdata/workbook-regressions/cross-reference-later.xlsx

similarity index 100%

rename from internal/testdata/workbook-regressions/cross-reference-later.xlsx

rename to testdata/workbook-regressions/cross-reference-later.xlsx

diff --git a/internal/testdata/workbook-regressions/two-worksheets.xlsx b/testdata/workbook-regressions/two-worksheets.xlsx

similarity index 100%

rename from internal/testdata/workbook-regressions/two-worksheets.xlsx

rename to testdata/workbook-regressions/two-worksheets.xlsx