oficina / sheets Public

fix(css): delete a rule that has never matched an element

[data-cell-value] was styled in sheets.css and nothing in any template
or module has ever written that attribute. It matched nothing for the
life of the branch.

Found by auditing every hook in sheets.css against everything that could
write one — our templates, our modules, and rastrillo's own vendored
layout, since a rule of ours can legitimately target an attribute the
framework emits. Two false-positive classes worth knowing about, both
learned from the Docs session doing the same audit: strip CSS comments
before matching, or a hook named only in a paragraph explaining an old
mistake reads as live; and search the module cache, or four framework
shell hooks read as dead.

This is the third defect tonight of one shape: a probe that returns the
same answer whether or not the thing works. A rule matching nothing, a
warning flag invisible on the cells it flags, and — on the Docs side — a
hit test measuring the framework's overlay rather than the rule under
test. None is catchable by adding more checks of the same kind. The
question that catches them is "what would make this go red", asked of
each one and then actually done.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0182f7QfojuuqdS4Xd2fYFaL
Paul Campbell pushed by paul@keymail.dev 37b90f60807009fed4b0babf8daf45eb8880d86c parent d632f27
1 file changed, +11 −5
  • internal/sheets/static/sheets.css +11 −5

CI cancelled — superseded by a newer push — run details

diff --git a/internal/sheets/static/sheets.css b/internal/sheets/static/sheets.css
index 540008d..c7fa716 100644
--- a/internal/sheets/static/sheets.css
+++ b/internal/sheets/static/sheets.css
@@ -740,11 +740,17 @@
min-inline-size: 6ch;
}
-[data-cell-value] {
- display: block;
- color: var(--rst-text-muted);
- font-size: var(--rst-fs-sm);
-}
+/* [data-cell-value] used to be styled here and is now gone. Nothing in
+ * any template or module has ever written that attribute, so the rule
+ * matched no element for the life of the branch — the same defect as
+ * the contrast flag two sections up, which had a rule and no attribute
+ * and therefore warned about cells it never marked.
+ *
+ * A selector that matches nothing is invisible to every test we have
+ * and to every screenshot, which is why it is worth saying it was here
+ * rather than deleting it silently: the next person to want a secondary
+ * line under a table cell should write the markup and the rule
+ * together, not find this and assume it works. */
/* Import drop zone ───────────────────────────────────────────────────