oficina / memoria Public

The implementation review's findings: recognisers, perf, and four gate holes

Reviewed by Fable 5.1 (dispatched: fable; self-reported: claude-fable-5-1).
REQUEST CHANGES, eight must-fix. It re-ran all ten of the author's
mutations — every one red, as claimed — and then found six of its own
that stayed green, which is §1.9 working exactly as written.

**Three recognisers were wrong on ordinary document text**, verified live
before being fixed. "Take the N11 then exit at Bray" boxed "N11 then" and
"Form P45 then P60" boxed "P45 then", because the eircode identifier
alphabet is most of the consonants and the pattern was case-insensitive.
"The deadline is 01-02-2024 10:30" boxed "01-02-2024 10", walking past
the 9-or-10 bound written to keep dates out, because the pattern allowed
mixed separators. "Growth of +10 000 000 users" boxed "+10 000 000",
because E.164's floor of eight admits it. Eircodes are now matched
case-sensitively, a phone number must use one separator style throughout
and at most four groups, and the international floor is ten.

**And the IBAN kind was inert on its commonest written shape.** Groups of
two-to-four swallowed the following word, so "IE29 AIBK 9311 5212 3456 78
and our BIC is …" found nothing at all; only a full stop immediately
after the number worked. Groups of exactly four with one short tail.

**A label must not depend on which kinds the query named.** Scan located
spans only for wanted kinds, so the earlier-span rule could not skip what
it could not see: "Email paul@tito.io or phone: 01 547 7854" asked for
phone alone came back labelled "Email paul@tito.io or phone" — one fact's
value inside another's label, which is the failure that rule exists to
stop.

**Label derivation was quadratic in the facts a chunk holds**, and
chunk.Split bounds a chunk by words — so a 2 MiB upload with no
whitespace is one chunk, one line, and minutes of search latency bought
by one person's file. Measured 48.5s at 1 MB. Deduping before labelling,
binary-searching the span list and bounding the backward walk take it to
152 ms, and a timed test holds it there.

**Four gate holes, each now with the fixture that sees it.** silenced
counted before the ruling — no other gate-34 fixture had a NoBox
candidate at all. A citation cross-wired field by field — the two bodies
were identical, so only Title could be checked, and the mutation renders
an href to the withheld document under its own heading. A collision check
comparing only neighbours — every other collision fixture is a pair.
Rows sorted rather than first-seen — §10 said this gate asserted order
and it asserted a length. All four mutations re-run and red.

Worth recording: addFacts cannot see unruled data at all, because it
takes only *Page. Every leak mutation has to be made in Search, one level
up — a stronger statement of the design than the comment claiming it.

Also fixed in the composing direction the spec names: initials ("J.
Smith's line" yielded "Smith's line") and NBSP-glued abbreviations, which
Word and Notion produce.

Still failing, and pre-existing on main: TestCreditsMatchProductionDependencies
reads $GOROOT/LICENSE, which the Homebrew Go layout does not have.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>