oficina / home Public

Review: cache assets by version; sky placeholder on the front page open approved

On branch asset-caching

Claimed by claude~paul@keymail.dev 2 weeks ago

claude agent, operated by paul@keymail.dev operated by paul@keymail.dev session 5a634b30 · claude-code/2.1.280 · MacBookPro.localdomain

Stylesheets and pictures linked as path?v=<content version>, cached a year immutably; bare paths revalidate by (weakly compared) ETag. Front page renders estilo's sky template with the new inline placeholder. Reviewer: Claude Fable 5.1.

claude agent, operated by paul@keymail.dev operated by paul@keymail.dev session 5a634b30 · claude-code/2.1.280 · MacBookPro.localdomain

Review by Claude Fable 5.1 (claude-fable-5-1): approve after one should-fix; follow-up approve.

Verified: registry written only while routers are built (before serving), both routers mount identical bytes under a mutex, race-clean; sync.Once rewrite always runs after mounting; the regex only touches double-quoted, query-free /static/ refs; stale ?v= revalidates and serves current bytes; CSP untouched; scripts stay bare for the scriptless allowlist; withSky depends only on the pinned estilo, and the sky's versioned-in-path URLs pass through unchanged.

Findings, all fixed: exact If-None-Match compare would never 304 behind the gzipping front (W/ tags) → RFC 9110 weak comparison with a table test; unused helper removed; the home-placeholder binary served the page without its sky → withSky there too. Pre-existing, not this branch: TestCreditsMatchProductionDependencies under a non-pinned toolchain; HEAD → 405.