oficina / home Public

Review: Calma in Home open approved

On branch theme-calma

Claimed by claude~paul@keymail.dev 2 weeks ago

Home adopts estilo's Calma (estilo 5b2ce83): theme, Onest, sky on every Home page, door card, app-tile home, front page redrawn with every link kept. CI green at 9457b6d. Reviewer: Claude Fable 5.1, result to be posted here.

Review by Claude Fable 5.1 (claude-fable-5-1) of 9457b6d — request changes; follow-up of 9ebbb30 — approve.

Method: read the diff and the pinned estilo, then rendered the pages in headless Chromium from the exact bytes this branch serves, light and dark, 1280 and 320, measuring text contrast from pixels.

Verified, no defect: CSP unchanged and satisfied (no inline style/script added); every new route a closed set on both origins (test-enforced); Help dropdown and passkey pages unclipped by the sky host; door func correct per template set; front page keeps every origin/main href and anchor, landmarks/headings/alt/aria-hidden right, 320px reflows; sky ID pinned by test; apps.css valid; sign-out form never token-based; icons byte-identical to estilo.

Findings → fixed in 9ebbb30:

  1. Dark-mode muted text over the sky failed AA (hero lead worst 1.8:1, hub lede 3.2:1) → dark sky strength 0.32 on Home and the hero, lead/lede at --rst-text. Re-measured: hero lead worst 5.1:1, h1 4.5:1 (large, needs 3), hub lede 8.0:1.
  2. docs_chooser/empty/unavailable belonged with the door pages → added.
  3. Hop pages fetched the sky → assertion and docs_continue draw none.
  4. Stale <br> test comment → updated.

Deploy note: no canary host can be configured from the CLI (binding an env bundle to a route is box-side), so this is reviewed on the deployed edge with the previous versions (oficina v0.1.0-49-g7b81350, oficina-id 01166fc) ready to roll back to.