amadan
Answer the review (Claude Fable 5.1)
- A test pins the layout's Onest link to estilo's versioned prefix (not needed where an equivalent already exists). - Slides: the credits page test expects Onest; a committed .pyc removed and __pycache__/ ignored. Calendar, Memoria: "'s" in writetheme's comment. Fichas: estilo is a direct requirement (go mod tidy).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2 files changed,
+25
−1
go.mod+1 −1internal/fichastest/fontlink_test.go+24 −0
CI passed — run details
CI log
=== vet === go vet ./... === fmt === === test === go test ./... ? amadan.net/oficina/fichas/cmd/fichas [no test files] ok amadan.net/oficina/fichas/internal/fichas 0.175s ? amadan.net/oficina/fichas/internal/fichas/icons [no test files] ok amadan.net/oficina/fichas/internal/fichas/seal (cached) ok amadan.net/oficina/fichas/internal/fichastest 0.132s ? amadan.net/oficina/fichas/scripts/writetheme [no test files] === migration-check === go run github.com/carlosframework/rastrillo/cmd/rastrillo migration check rastrillo migration check: models and migrations agree
diff --git a/go.mod b/go.mod| index 8f2894b..e138632 100644 |
| --- a/go.mod |
| +++ b/go.mod |
| @@ -5,6 +5,7 @@ go 1.26 |
| toolchain go1.26.5 |
| require ( |
| + amadan.net/oficina/estilo.git v0.0.0-20260929070530-5b2ce835e773 |
| github.com/carlosframework/rastrillo v0.23.0 |
| github.com/chromedp/chromedp v0.14.2 |
| github.com/go-chi/chi/v5 v5.3.2 |
| @@ -14,7 +15,6 @@ require ( |
| ) |
| require ( |
| - amadan.net/oficina/estilo.git v0.0.0-20260929070530-5b2ce835e773 // indirect |
| github.com/BurntSushi/toml v1.6.0 // indirect |
| github.com/chromedp/cdproto v0.0.0-20250724212937-08a3db8b4327 // indirect |
| github.com/chromedp/sysutil v1.1.0 // indirect |
diff --git a/internal/fichastest/fontlink_test.go b/internal/fichastest/fontlink_test.go| new file mode 100644 |
| index 0000000..8e39289 |
| --- /dev/null |
| +++ b/internal/fichastest/fontlink_test.go |
| @@ -0,0 +1,24 @@ |
| +package fichastest |
| + |
| +import ( |
| + "bytes" |
| + "os" |
| + "path/filepath" |
| + "testing" |
| + |
| + "amadan.net/oficina/estilo.git/theme" |
| +) |
| + |
| +// The layout names Onest's stylesheet by a literal path; this keeps that |
| +// literal equal to estilo's versioned prefix, so an estilo font move |
| +// fails here rather than every page quietly falling back to the system |
| +// face. |
| +func TestLayoutLinksEstilosFonts(t *testing.T) { |
| + layout, err := os.ReadFile(filepath.Join("..", "fichas", "templates", "layout.html")) |
| + if err != nil { |
| + t.Fatal(err) |
| + } |
| + if want := `href="` + theme.FontPrefix + `fonts.css"`; !bytes.Contains(layout, []byte(want)) { |
| + t.Errorf("layout.html does not link %s", want) |
| + } |
| +} |