Review: the bar's title field zooms iOS on tap open
On branch fix/title-touch-size
Review request: branch fix/title-touch-size, 1 commit on origin/main 0b4d92c.
The bug. iOS Safari zooms the page into any text field under 16px. rastrillo's tokens.css (from v0.26, at the touch rule "the two zooms nobody asked for") lifts fields to 16px under (pointer: coarse), but it does so with a bare input selector. [estilo-bar-title-input] sets font: inherit at attribute weight, which outweighs that, so the title stays at 14px and zooms in every app that shows a title in the bar. Sheets' new TestNoZoomOnTap found it (oficina/sheets#44). Sheets carries a local copy of the fix in sheets.css until this lands.
The fix. chrome.css adds font-size: max(1rem, 1em) for the field under (pointer: coarse), placed after the field's own rule. The 14px title under a mouse is unchanged.
Tests
TestTitleFieldDoesNotZoomOnTapfailed before the fix. It checks that the block exists and comes after the field's own rule.- estilo has no browser harness, so the browser proof comes from Sheets: TestNoZoomOnTap, with Sheets' local title rule removed, fails against estilo's current pin and passes with this rule applied to that pin.
make testis green locally.
Not merged.
After merge. Apps with the bar pick this up when they bump estilo, and Sheets can then drop its local [estilo-bar-title-input] line. Apps still importing rastrillo from github.com/carlosframework/rastrillo (v0.23, no touch rule) get the title fix from this branch, but their other fields still zoom until they migrate.