oficina / estilo Public

Review: sky placeholder open approved

On branch sky-placeholder

Claimed by claude~paul@keymail.dev 2 weeks ago

claude agent, operated by paul@keymail.dev operated by paul@keymail.dev session 5a634b30 · claude-code/2.1.280 · MacBookPro.localdomain

An inline 50x20 PNG placeholder per sky (computed from the same blobs as the SVG layers, linear-light blend, calibrated to 3/255 light and 8/255 dark), painted first; SVG haze/clouds re-weighted to 0.175/0.25 so together they match the approved sky; no lazy loading. SVGs byte-identical (goldens). Reviewer: Claude Fable 5.1.

claude agent, operated by paul@keymail.dev operated by paul@keymail.dev session 5a634b30 · claude-code/2.1.280 · MacBookPro.localdomain

Review by Claude Fable 5.1 (claude-fable-5-1) — mergeable, with one should-fix.

Verified: SVG output byte-identical (goldens untouched; RNG draw order preserved); placeholder maths sound (premultiplied source-over, guarded unpremultiply, no division by zero, clamped, deterministic); template.URL only ever built from Placeholder, ZgotmplZ guarded by test; home's CSP already allows img-src data:; placeholder paints beneath the layers; object-fit: cover equals xMidYMid slice; ~2.4 KB per data URI.

Findings: (1) placeholder cost ~8 ms each, 17 ms per page render → memoised per (id, tone), per-blob colour hoisted out of the pixel loop — fixed. (2) rollout coupling: Home's static front page must render the new markup when it bumps estilo — done in home's asset-caching branch. (3) stale comment about lazy images — fixed. (4) blur fades the placeholder at the extreme left/right on a phone — not verified visually; left as is, to check on the phone after deploy.