oficina / docs Public

Task 3 fix round 2: name internal/docs, not this package, as the missing caller

Round 1's rewrite of ErrUpdateLogFull's doc comment said this package
(internal/core) still needed to call the snapshot/compaction primitive
- false, since Handle.Snapshot and Handle.VerifySnapshot, added by this
same task, do exactly that. Checked against the code: ABI v4 exports
the primitive (core/src/abi.rs), internal/core calls it (this file,
below), and nothing in internal/docs calls either method or persists a
snapshot row yet (grep confirms). Rewrote the comment to name
internal/docs as the missing caller instead.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Paul Campbell pushed by paul@keymail.dev 1 month ago d5e6f138a51fb2c5aa135fd2ed0acfe68942d308 parent 60c4412

1 file changed, +6 −4

internal/core/core.go +6 −4

diff --git a/internal/core/core.go b/internal/core/core.go

index ae312a8..bdebd02 100644

--- a/internal/core/core.go

+++ b/internal/core/core.go

@@ -144,10 +144,12 @@ const MaxRetainedUpdates = maxRetainedUpdates

// ErrUpdateLogFull is returned by Handle.Apply once a document's retained

// update log has reached maxRetainedUpdates. See that constant's doc

-// comment: the ABI has exported a snapshot/compaction primitive since

-// v4; what's still missing is this package calling it and a caller

-// persisting the result. This is a deliberate, visible failure standing

-// in for that host-side wiring, not a bug.

+// comment: ABI v4 exports the snapshot/compaction primitive, and this

+// package now calls it (Handle.Snapshot, Handle.VerifySnapshot, below)

+// — what's still missing is a host caller in internal/docs persisting a

+// snapshot row and using it to compact a document's log before this

+// limit is reached. This is a deliberate, visible failure standing in

+// for that missing internal/docs wiring, not a bug.

var ErrUpdateLogFull = errors.New("update log exceeds the retained limit; document needs compaction (not yet wired up on the host side) before it can accept further updates")

// Option configures a Runtime. See WithGuestCallTimeout.