Bump estilo to 894afdc; Share page Copy button hidden without JS open
On branch chore/estilo-894afdc
Bumps estilo to main 894afdc, plus the follow-ups that come with it. Head 6a8d21f, one commit on e0c2f2a.
1. Estilo 894afdc. Bar.Actions is now []chrome.Action (a menu.Item plus Primary). There are two edits, frameOptions.actions in chrome.go and handlers.go:660. Share… stays a link (GET) and is not Primary, so it renders exactly as before: <a rst-btn href="/d/…/share">Share…</a>.
2. Menubar vs estilo's Escape and outside click. estilo's chrome.js now closes the estilo-menus group on Escape (capture phase, preventDefault) and outside click, and moves the roving tab stop with focus. Docs' menu.mjs duplicated both. Its Escape case found nothing left open, and its document click-away repeated estilo's. I removed both, so the editor bundle is rebuilt (editor.1407830d… → editor.fedd7579…). Tab-closes-menu, arrows, Home/End, hover-to-switch and command items are unchanged. Whoever squash-merges second rebuilds the bundle on top of main (AGENTS.md).
3. Share page Copy button without JS (Astra, #65 P3). [rst-btn] sets display: inline-flex, which beats the user agent's [hidden]. I added an explicit [docs-share-copy][hidden] { display: none } rule. TestTheSharePageCopyButtonStaysHiddenWithoutScript failed before the rule and passes after it.
4. Keyboard shortcuts… into the account Help group: skipped, not small. In Docs the dialog exists only on the editor page, and shortcuts.mjs fills its body from the menubar when it opens (the Tools command). An estilo Dialog row opens it with the native invoker and never runs that filler. Moving it needs the body filled at mount time, a per-page Help flag in account(), the Tools item removed, a dialog id, and test changes. Better as its own branch.
Verification
- Full local gate,
TMPDIR=/tmp GOTOOLCHAIN=go1.26.5 .amadan/ci.d/10-gate:gate: ok. - Shared visual check,
r2-chrome-check.mjswithr2-docs-check.config.mjs: 591 ok, all checks passed. - Menubar drive (Playwright, 1440px) on File-row menus Format, View (entered via an item) and Edit: - Escape closes the menu and returns focus to its own title. - The roving stop moves to that title. - Tab then Shift+Tab lands back on that menu. - An outside click closes the menu. - Escape reaches
windowwithdefaultPrevented. - No page errors. - Share… is a GET link, with no form among the bar actions. - With JS disabled, the Copy button renders and computesdisplay: none. - Repo browser drive (
scripts/browser-drive.sh, Chrome for Testing): 43/44. The one failure, "a document does not scroll sideways at 320px (path ends at 562/592/622)", is pre-existing: the same drive on origin/main e0c2f2a fails it with identical numbers.
estilo 894afdc (Bar.Actions → chrome.Action); drop Docs' duplicate menubar Escape/click-away (bundle rebuilt); [docs-share-copy][hidden] rule + test. Keyboard shortcuts move skipped (not small).