amadan
design: record the five code-review passes and the deploy
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
1 file changed,
+18
−0
docs/superpowers/specs/2026-09-02-calendar-design.md+18 −0
CI cancelled — superseded by a newer push — run details
diff --git a/docs/superpowers/specs/2026-09-02-calendar-design.md b/docs/superpowers/specs/2026-09-02-calendar-design.md| index 6ad4672..50449ba 100644 |
| --- a/docs/superpowers/specs/2026-09-02-calendar-design.md |
| +++ b/docs/superpowers/specs/2026-09-02-calendar-design.md |
| @@ -291,3 +291,21 @@ own spec is `2026-09-07-booking-design.md`, reviewed eight times by |
| GPT-6 before code; the review found six defects in this engine's |
| recurrence expansion that every view already had, all fixed on the |
| same branch. |
| + |
| +**Code review of the booking branch**, by GPT-6 (Codex CLI 0.153.0; |
| +the runtime variant was not exposed), five passes, 2026-09-07. Each |
| +pass re-read the previous pass's fixes in full and was strict about |
| +partial fixes. |
| + |
| +| Pass | Verdict | Findings | Commit that answered it | |
| +|---|---|---|---| |
| +| 1 | DO NOT SHIP | 21, 12 blocking: a folded mail subject leaking the title into the relay's error and so the log; `WKST` ignored; the output cap reported complete; reminder claim not re-checking `due_at`; the immediate mail attempt draining everyone's queue; and sixteen more | `1e2ba83` | |
| +| 2 | DO NOT SHIP | 5 new, 7 partial: the sender's error text still reached the sign-in log; CRLF notes refused; the snapshot sealed before the lock; reschedule using stale windows; deferred mail reported sent | `5e3f047` | |
| +| 3 | DO NOT SHIP | 3 blocking, 1 hardening: "nothing claimable" read as "everything sent"; a closed page's reschedule picker; page-view bookkeeping on an expired context; budgets | `b840938` | |
| +| 4 | SHIP WITH FIXES | 1 blocking: a spent send budget counted as a reminder attempt | `d961b65` | |
| +| 5 | **SHIP** | none blocking. Left open as (ii): bookkeeping after a send may run one second past the page-view budget, by design — the floor is what lets a late claim's outcome be recorded rather than left to the lease | |
| + |
| +Every finding has a regression in `internal/calendartest/booking_review_test.go`, |
| +`booking_review2_test.go` or `internal/calendar/mail_bounded_test.go`. |
| +Deployed to edge as `d961b65` and verified on the process's own |
| +`/api/version`. |