eleven / messenger Public

ios+mac: tidy seven build warnings (no behaviour change) (#595)

* ios: defer composer caret write out of the SwiftUI view update

ComposerField's textViewDidChangeSelection fires synchronously when
updateUIView sets `tv.text` (a programmatic text change moves the
caret), so writing the `caret` binding there landed mid-view-update —
Xcode's purple "Modifying state during view update, this will cause
undefined behavior." Snapshot the caret and publish it next runloop,
the same DispatchQueue.main.async idiom the first-responder wiring
already uses.

textViewDidChange is deliberately left synchronous: it fires only for
user edits (a programmatic text set doesn't call it), so it never runs
inside a view update — and deferring its `text` write would open a
runloop window where tv.text and the binding disagree, letting an
unrelated re-render clobber a just-typed character.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* ios: tidy simple Swift / strict-concurrency warnings

Three low-risk warning fixes, no behaviour change:

- Crypto.swift: drop the redundant `public` on Data.base64urlEncodedString()
  — the enclosing extension is already `public extension Data`.
- ChatFeedModel.ProgressFetch: mark the mutable delegate state
  (buffer/expected/ok) `nonisolated(unsafe)`. The URLSessionDataDelegate
  protocol requires Sendable, but a session serialises its delegate
  callbacks on its delegateQueue (nil → a private serial queue), so the
  state is only ever touched one at a time; the compiler can't prove that.
- SchemaEngine.template: `chars` is only read, never mutated — var → let.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* ios+mac: fix two concurrency/builder warnings in extension & Mac UI

- LChatShare/ShareViewController: un-nest the NSItemProvider file/data
  loads in save() into two awaited steps, so the data fallback no longer
  sits inside — and captures `provider` in — the file load's @Sendable
  completion (NSItemProvider isn't Sendable). Behaviour preserved: data is
  tried only when no file representation was offered, not when a file copy
  failed.
- LChatMac/RootView: drop a stray @ViewBuilder left dangling above
  chatInitials() by an earlier refactor — it returns String, so the
  attribute did nothing but emit "result builder disabled by explicit
  return". No behaviour change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* mac: use the async UNUserNotificationCenter.add alternative

Called inside a Task.detached, so the compiler flagged the completion
-handler overload ("consider using asynchronous alternative"). Switch to
`try? await …add(request)`; the original passed no completion handler and
so ignored delivery errors — `try?` preserves that.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>