| 1 | package release |
| 2 | |
| 3 | import ( |
| 4 | "context" |
| 5 | "crypto/ed25519" |
| 6 | "errors" |
| 7 | "os" |
| 8 | "slices" |
| 9 | "strings" |
| 10 | "testing" |
| 11 | "time" |
| 12 | ) |
| 13 | |
| 14 | // ctx is the package's test context; the older tests in this file shadow it |
| 15 | // with their own local one, harmlessly. |
| 16 | var ctx = context.Background() |
| 17 | |
| 18 | func TestTrashAppRoundTrip(t *testing.T) { |
| 19 | ctx := context.Background() |
| 20 | s := NewDirStore(t.TempDir()) |
| 21 | now := time.Date(2026, 8, 4, 16, 0, 0, 0, time.UTC) |
| 22 | |
| 23 | // The key path is a wire contract: later tasks (route hiding, the purge |
| 24 | // pass) string-match "deleted.json" independently of this package. |
| 25 | if got, want := AppTombstoneKey("bab", "derp"), "apps/bab/derp/deleted.json"; got != want { |
| 26 | t.Fatalf("AppTombstoneKey(bab, derp) = %q, want %q", got, want) |
| 27 | } |
| 28 | |
| 29 | // Absent: (nil, nil), not an error. |
| 30 | if tomb, err := ReadAppTombstone(ctx, s, "bab", "derp"); err != nil || tomb != nil { |
| 31 | t.Fatalf("absent marker: got %v, %v; want nil, nil", tomb, err) |
| 32 | } |
| 33 | if err := TrashApp(ctx, s, "bab", "derp", "paul@keymail.dev", now); err != nil { |
| 34 | t.Fatalf("TrashApp: %v", err) |
| 35 | } |
| 36 | tomb, err := ReadAppTombstone(ctx, s, "bab", "derp") |
| 37 | if err != nil || tomb == nil { |
| 38 | t.Fatalf("ReadAppTombstone: got %v, %v", tomb, err) |
| 39 | } |
| 40 | if tomb.Account != "bab" || tomb.App != "derp" || tomb.Actor != "paul@keymail.dev" || !tomb.DeletedAt.Equal(now) { |
| 41 | t.Fatalf("tombstone fields: %+v", tomb) |
| 42 | } |
| 43 | // Idempotent: trashing a trashed app is nil and does NOT move the clock. |
| 44 | if err := TrashApp(ctx, s, "bab", "derp", "eve@keymail.dev", now.Add(time.Hour)); err != nil { |
| 45 | t.Fatalf("second TrashApp: %v", err) |
| 46 | } |
| 47 | tomb2, _ := ReadAppTombstone(ctx, s, "bab", "derp") |
| 48 | if !tomb2.DeletedAt.Equal(now) || tomb2.Actor != "paul@keymail.dev" { |
| 49 | t.Fatalf("second trash rewrote the marker: %+v", tomb2) |
| 50 | } |
| 51 | // Restore deletes the marker; restoring an untrashed app is fine. |
| 52 | if err := RestoreApp(ctx, s, "bab", "derp"); err != nil { |
| 53 | t.Fatalf("RestoreApp: %v", err) |
| 54 | } |
| 55 | if tomb, _ := ReadAppTombstone(ctx, s, "bab", "derp"); tomb != nil { |
| 56 | t.Fatalf("marker survived restore: %+v", tomb) |
| 57 | } |
| 58 | if err := RestoreApp(ctx, s, "bab", "derp"); err != nil { |
| 59 | t.Fatalf("restore of untrashed app: %v", err) |
| 60 | } |
| 61 | } |
| 62 | |
| 63 | // TestReadAppTombstoneParsesWireShape pins the JSON tags against the spec's |
| 64 | // exact example body — a struct-tag typo would still fail the negative |
| 65 | // tests above (any parse error refuses), so only a positive round-trip on |
| 66 | // literal bytes catches it. |
| 67 | func TestReadAppTombstoneParsesWireShape(t *testing.T) { |
| 68 | ctx := context.Background() |
| 69 | s := NewDirStore(t.TempDir()) |
| 70 | body := []byte(`{"schema":1,"account":"bab","app":"derp","deleted_at":"2026-08-04T16:00:00Z","actor":"paul@keymail.dev"}`) |
| 71 | if _, err := s.Put(ctx, AppTombstoneKey("bab", "derp"), body, ""); err != nil { |
| 72 | t.Fatal(err) |
| 73 | } |
| 74 | tomb, err := ReadAppTombstone(ctx, s, "bab", "derp") |
| 75 | if err != nil || tomb == nil { |
| 76 | t.Fatalf("ReadAppTombstone: got %v, %v", tomb, err) |
| 77 | } |
| 78 | want := time.Date(2026, 8, 4, 16, 0, 0, 0, time.UTC) |
| 79 | if tomb.Account != "bab" || tomb.App != "derp" || tomb.Actor != "paul@keymail.dev" || !tomb.DeletedAt.Equal(want) { |
| 80 | t.Fatalf("tombstone fields: %+v", tomb) |
| 81 | } |
| 82 | // The schema is part of the shape, not decoration: the refusal below |
| 83 | // only means anything if the happy path really carries a 1. |
| 84 | if tomb.Schema != 1 { |
| 85 | t.Fatalf("schema = %d, want 1", tomb.Schema) |
| 86 | } |
| 87 | } |
| 88 | |
| 89 | // A marker written by a future box, in a shape this one has never seen, is |
| 90 | // refused — and refusal is the safe direction: the app keeps serving and |
| 91 | // keeps its bytes until this box is upgraded. Believing an unknown schema |
| 92 | // would hide or destroy on terms nobody here can read. |
| 93 | func TestReadAppTombstoneRefusesUnknownSchema(t *testing.T) { |
| 94 | ctx := context.Background() |
| 95 | s := NewDirStore(t.TempDir()) |
| 96 | body := []byte(`{"schema":2,"account":"bab","app":"derp","deleted_at":"2026-08-04T16:00:00Z","actor":"paul@keymail.dev"}`) |
| 97 | if _, err := s.Put(ctx, AppTombstoneKey("bab", "derp"), body, ""); err != nil { |
| 98 | t.Fatal(err) |
| 99 | } |
| 100 | tomb, err := ReadAppTombstone(ctx, s, "bab", "derp") |
| 101 | if err == nil { |
| 102 | t.Fatalf("schema 2 marker was believed: %+v", tomb) |
| 103 | } |
| 104 | if !strings.Contains(err.Error(), "schema 2") { |
| 105 | t.Errorf("error %q does not name the schema it refused", err) |
| 106 | } |
| 107 | // And the refusal must reach the destructive path as a refusal, not as |
| 108 | // "no marker" — PurgeApp errors rather than deciding there is nothing |
| 109 | // to purge. |
| 110 | if err := PurgeApp(ctx, s, nil, "bab", "derp", time.Now()); err == nil || errors.Is(err, ErrNotTrashed) { |
| 111 | t.Errorf("PurgeApp on an unreadable-schema marker: %v, want a refusal", err) |
| 112 | } |
| 113 | // A schema-0 body (the field missing entirely) is refused for the same |
| 114 | // reason: a marker that does not say what it is, is not a marker. |
| 115 | if _, err := s.Put(ctx, AppTombstoneKey("bab", "noschema"), |
| 116 | []byte(`{"account":"bab","app":"noschema","deleted_at":"2026-08-04T16:00:00Z"}`), ""); err != nil { |
| 117 | t.Fatal(err) |
| 118 | } |
| 119 | if _, err := ReadAppTombstone(ctx, s, "bab", "noschema"); err == nil { |
| 120 | t.Fatal("schema-less marker was not refused") |
| 121 | } |
| 122 | } |
| 123 | |
| 124 | func TestReadAppTombstoneRefusesDisagreement(t *testing.T) { |
| 125 | ctx := context.Background() |
| 126 | s := NewDirStore(t.TempDir()) |
| 127 | // A marker whose body claims a different app than its path is a lie |
| 128 | // about identity: error, never acted on. |
| 129 | body := []byte(`{"schema":1,"account":"bab","app":"OTHER","deleted_at":"2026-08-04T16:00:00Z","actor":"x@y.z"}`) |
| 130 | if _, err := s.Put(ctx, AppTombstoneKey("bab", "derp"), body, ""); err != nil { |
| 131 | t.Fatal(err) |
| 132 | } |
| 133 | if _, err := ReadAppTombstone(ctx, s, "bab", "derp"); err == nil { |
| 134 | t.Fatal("path/body disagreement was not refused") |
| 135 | } |
| 136 | // Malformed JSON: error too. |
| 137 | if _, err := s.Put(ctx, AppTombstoneKey("bab", "junk"), []byte("{"), ""); err != nil { |
| 138 | t.Fatal(err) |
| 139 | } |
| 140 | if _, err := ReadAppTombstone(ctx, s, "bab", "junk"); err == nil { |
| 141 | t.Fatal("malformed marker was not refused") |
| 142 | } |
| 143 | // Zero deleted_at: refused — the cooloff clock would never expire and |
| 144 | // the marker would be acted on with no timestamp to reason from. |
| 145 | body = []byte(`{"schema":1,"account":"bab","app":"noat","actor":"x@y.z"}`) |
| 146 | if _, err := s.Put(ctx, AppTombstoneKey("bab", "noat"), body, ""); err != nil { |
| 147 | t.Fatal(err) |
| 148 | } |
| 149 | if _, err := ReadAppTombstone(ctx, s, "bab", "noat"); err == nil { |
| 150 | t.Fatal("marker with zero deleted_at was not refused") |
| 151 | } |
| 152 | } |
| 153 | |
| 154 | // recordingStore is a Store that remembers the ORDER of Delete calls. The |
| 155 | // purge's marker-last discipline is not observable from final state (in the |
| 156 | // happy path everything is gone either way) — only from the sequence. |
| 157 | type recordingStore struct { |
| 158 | Store |
| 159 | deletes *[]string |
| 160 | } |
| 161 | |
| 162 | func (r recordingStore) Delete(ctx context.Context, key string) error { |
| 163 | *r.deletes = append(*r.deletes, key) |
| 164 | return r.Store.Delete(ctx, key) |
| 165 | } |
| 166 | |
| 167 | // seedApp lays down a plausible app: two channel pointers, a manifest, an |
| 168 | // artifact. The purge has to take all of them. |
| 169 | func seedApp(t *testing.T, s Store, acct, app string) []string { |
| 170 | t.Helper() |
| 171 | keys := []string{ |
| 172 | "apps/" + acct + "/" + app + "/channels/stable.json", |
| 173 | "apps/" + acct + "/" + app + "/channels/canary/x.json", |
| 174 | "apps/" + acct + "/" + app + "/releases/1.0.0/manifest.json", |
| 175 | "apps/" + acct + "/" + app + "/releases/1.0.0/app.tar.gz", |
| 176 | } |
| 177 | for _, k := range keys { |
| 178 | if _, err := s.Put(context.Background(), k, []byte("{}"), ""); err != nil { |
| 179 | t.Fatal(err) |
| 180 | } |
| 181 | } |
| 182 | return keys |
| 183 | } |
| 184 | |
| 185 | func listUnder(t *testing.T, s Store, prefix string) []string { |
| 186 | t.Helper() |
| 187 | keys, err := s.List(context.Background(), prefix) |
| 188 | if err != nil { |
| 189 | t.Fatal(err) |
| 190 | } |
| 191 | slices.Sort(keys) |
| 192 | return keys |
| 193 | } |
| 194 | |
| 195 | // Contract 1: purge without a marker is destruction without an instruction. |
| 196 | func TestPurgeAppRefusesWhenNotTrashed(t *testing.T) { |
| 197 | s := NewDirStore(t.TempDir()) |
| 198 | _, pub := testKeys(t) |
| 199 | keys := seedApp(t, s, "bab", "derp") |
| 200 | err := PurgeApp(ctx, s, pub, "bab", "derp", time.Now()) |
| 201 | if !errors.Is(err, ErrNotTrashed) { |
| 202 | t.Fatalf("PurgeApp on a live app = %v, want ErrNotTrashed", err) |
| 203 | } |
| 204 | if got := listUnder(t, s, "apps/bab/derp/"); len(got) != len(keys) { |
| 205 | t.Fatalf("a refused purge destroyed objects: %v", got) |
| 206 | } |
| 207 | // A marker that exists but cannot be believed is not an instruction |
| 208 | // either: ReadAppTombstone's error propagates and nothing is destroyed. |
| 209 | if _, err := s.Put(ctx, AppTombstoneKey("bab", "derp"), []byte("{"), ""); err != nil { |
| 210 | t.Fatal(err) |
| 211 | } |
| 212 | if err := PurgeApp(ctx, s, pub, "bab", "derp", time.Now()); err == nil { |
| 213 | t.Fatal("purge acted on an unparseable marker") |
| 214 | } |
| 215 | if got := listUnder(t, s, "apps/bab/derp/"); len(got) != len(keys)+1 { |
| 216 | t.Fatalf("a refused purge destroyed objects: %v", got) |
| 217 | } |
| 218 | } |
| 219 | |
| 220 | // Contract 2: no public key means the production flag cannot be verified, |
| 221 | // which means the app cannot be PROVEN non-production. Refuse. |
| 222 | func TestPurgeAppRefusesWithoutAPublicKey(t *testing.T) { |
| 223 | s := NewDirStore(t.TempDir()) |
| 224 | keys := seedApp(t, s, "bab", "derp") |
| 225 | if err := TrashApp(ctx, s, "bab", "derp", "paul@keymail.dev", time.Now()); err != nil { |
| 226 | t.Fatal(err) |
| 227 | } |
| 228 | for _, pub := range []ed25519.PublicKey{nil, {}, make([]byte, 8)} { |
| 229 | if err := PurgeApp(ctx, s, pub, "bab", "derp", time.Now()); err == nil { |
| 230 | t.Fatalf("purge with a %d-byte key was allowed", len(pub)) |
| 231 | } |
| 232 | } |
| 233 | if got := listUnder(t, s, "apps/bab/derp/"); len(got) != len(keys)+1 { |
| 234 | t.Fatalf("a refused purge destroyed objects: %v", got) |
| 235 | } |
| 236 | } |
| 237 | |
| 238 | // Contract 3: production ON refuses; an UNREADABLE flag refuses (unreadable |
| 239 | // is not off); ABSENT is fine, because most apps never had a flag at all. |
| 240 | func TestPurgeAppRefusesProductionAndUnreadableFlags(t *testing.T) { |
| 241 | priv, pub := testKeys(t) |
| 242 | |
| 243 | // ON. |
| 244 | s := NewDirStore(t.TempDir()) |
| 245 | seedApp(t, s, "bab", "derp") |
| 246 | if err := SetProduction(ctx, s, priv, "bab", "derp", true, "paul@keymail.dev"); err != nil { |
| 247 | t.Fatal(err) |
| 248 | } |
| 249 | if err := TrashApp(ctx, s, "bab", "derp", "paul@keymail.dev", time.Now()); err != nil { |
| 250 | t.Fatal(err) |
| 251 | } |
| 252 | if err := PurgeApp(ctx, s, pub, "bab", "derp", time.Now()); err == nil { |
| 253 | t.Fatal("purge destroyed a production-flagged app") |
| 254 | } |
| 255 | if got := listUnder(t, s, "apps/bab/derp/"); len(got) == 0 { |
| 256 | t.Fatal("a refused purge destroyed objects") |
| 257 | } |
| 258 | |
| 259 | // UNREADABLE: the object is there but does not verify. |
| 260 | s = NewDirStore(t.TempDir()) |
| 261 | seedApp(t, s, "bab", "derp") |
| 262 | if _, err := s.Put(ctx, ProductionKey("bab", "derp"), []byte(`{"payload":"zz","sig":"zz"}`), ""); err != nil { |
| 263 | t.Fatal(err) |
| 264 | } |
| 265 | if err := TrashApp(ctx, s, "bab", "derp", "paul@keymail.dev", time.Now()); err != nil { |
| 266 | t.Fatal(err) |
| 267 | } |
| 268 | if err := PurgeApp(ctx, s, pub, "bab", "derp", time.Now()); err == nil { |
| 269 | t.Fatal("purge treated an unreadable production flag as off") |
| 270 | } |
| 271 | if got := listUnder(t, s, "apps/bab/derp/"); len(got) == 0 { |
| 272 | t.Fatal("a refused purge destroyed objects") |
| 273 | } |
| 274 | |
| 275 | // OFF, explicitly: purges. |
| 276 | s = NewDirStore(t.TempDir()) |
| 277 | seedApp(t, s, "bab", "derp") |
| 278 | if err := SetProduction(ctx, s, priv, "bab", "derp", false, "paul@keymail.dev"); err != nil { |
| 279 | t.Fatal(err) |
| 280 | } |
| 281 | if err := TrashApp(ctx, s, "bab", "derp", "paul@keymail.dev", time.Now()); err != nil { |
| 282 | t.Fatal(err) |
| 283 | } |
| 284 | if err := PurgeApp(ctx, s, pub, "bab", "derp", time.Now()); err != nil { |
| 285 | t.Fatalf("purge of an explicitly non-production app: %v", err) |
| 286 | } |
| 287 | if got := listUnder(t, s, "apps/bab/derp/"); len(got) != 0 { |
| 288 | t.Fatalf("purge left objects behind: %v", got) |
| 289 | } |
| 290 | } |
| 291 | |
| 292 | // Contract 4: everything under the prefix goes, and the MARKER GOES LAST, so |
| 293 | // a purge that dies half-way leaves a trashed app with fewer objects rather |
| 294 | // than a live app with holes. |
| 295 | func TestPurgeAppDestroysEverythingMarkerLast(t *testing.T) { |
| 296 | base := NewDirStore(t.TempDir()) |
| 297 | var deletes []string |
| 298 | s := recordingStore{Store: base, deletes: &deletes} |
| 299 | _, pub := testKeys(t) |
| 300 | seedApp(t, s, "bab", "derp") |
| 301 | // A neighbouring app in the same account must be untouched: the prefix |
| 302 | // ends in "/" precisely so "derp" never reaches "derpy". |
| 303 | seedApp(t, s, "bab", "derpy") |
| 304 | if err := TrashApp(ctx, s, "bab", "derp", "paul@keymail.dev", time.Now()); err != nil { |
| 305 | t.Fatal(err) |
| 306 | } |
| 307 | if err := PurgeApp(ctx, s, pub, "bab", "derp", time.Now()); err != nil { |
| 308 | t.Fatalf("PurgeApp: %v", err) |
| 309 | } |
| 310 | if got := listUnder(t, s, "apps/bab/derp/"); len(got) != 0 { |
| 311 | t.Fatalf("purge left objects behind: %v", got) |
| 312 | } |
| 313 | if got := listUnder(t, s, "apps/bab/derpy/"); len(got) != 4 { |
| 314 | t.Fatalf("purge reached the neighbouring app: %v", got) |
| 315 | } |
| 316 | marker := AppTombstoneKey("bab", "derp") |
| 317 | if len(deletes) == 0 || deletes[len(deletes)-1] != marker { |
| 318 | t.Fatalf("delete order %v — the marker must go LAST", deletes) |
| 319 | } |
| 320 | if slices.Index(deletes, marker) != len(deletes)-1 { |
| 321 | t.Fatalf("marker deleted more than once / early: %v", deletes) |
| 322 | } |
| 323 | } |
| 324 | |
| 325 | // Contract 4b (discussion #219, item 2): the app's open ledgers go too. They |
| 326 | // live under ledgers/<acct>/<app>/, outside the app's own prefix, and a purge |
| 327 | // that left them handed them to the next app of the same name. Swept before |
| 328 | // the marker, and a neighbouring app's ledgers stay. |
| 329 | func TestPurgeAppSweepsTheAppsLedgers(t *testing.T) { |
| 330 | base := NewDirStore(t.TempDir()) |
| 331 | var deletes []string |
| 332 | s := recordingStore{Store: base, deletes: &deletes} |
| 333 | _, pub := testKeys(t) |
| 334 | seedApp(t, s, "bab", "derp") |
| 335 | for _, key := range []string{ |
| 336 | "ledgers/bab/derp/ledgers.json", |
| 337 | "ledgers/bab/derp/carbon/HEAD.json", |
| 338 | "ledgers/bab/derp/carbon/entries/20261003T000000Z-0123456789ab.json", |
| 339 | "ledgers/bab/derp/carbon/blobs/" + strings.Repeat("a", 64), |
| 340 | "ledgers/bab/derpy/ledgers.json", |
| 341 | } { |
| 342 | if _, err := s.Put(ctx, key, []byte(`{}`), ""); err != nil { |
| 343 | t.Fatal(err) |
| 344 | } |
| 345 | } |
| 346 | if err := TrashApp(ctx, s, "bab", "derp", "paul@keymail.dev", time.Now()); err != nil { |
| 347 | t.Fatal(err) |
| 348 | } |
| 349 | if err := PurgeApp(ctx, s, pub, "bab", "derp", time.Now()); err != nil { |
| 350 | t.Fatalf("PurgeApp: %v", err) |
| 351 | } |
| 352 | if got := listUnder(t, s, LedgerAppPrefix("bab", "derp")); len(got) != 0 { |
| 353 | t.Fatalf("purge left the app's ledgers behind: %v", got) |
| 354 | } |
| 355 | if got := listUnder(t, s, LedgerAppPrefix("bab", "derpy")); len(got) != 1 { |
| 356 | t.Fatalf("purge reached the neighbouring app's ledgers: %v", got) |
| 357 | } |
| 358 | if marker := AppTombstoneKey("bab", "derp"); deletes[len(deletes)-1] != marker { |
| 359 | t.Fatalf("delete order %v — the marker must go LAST", deletes) |
| 360 | } |
| 361 | } |
| 362 | |
| 363 | // Contract 5: idempotent. A half-purged app converges on a second pass, and |
| 364 | // an already-purged one reports ErrNotTrashed — which the caller reads as |
| 365 | // "done", not as a failure. |
| 366 | func TestPurgeAppIsIdempotent(t *testing.T) { |
| 367 | s := NewDirStore(t.TempDir()) |
| 368 | _, pub := testKeys(t) |
| 369 | seedApp(t, s, "bab", "derp") |
| 370 | if err := TrashApp(ctx, s, "bab", "derp", "paul@keymail.dev", time.Now()); err != nil { |
| 371 | t.Fatal(err) |
| 372 | } |
| 373 | // Half-purged: some objects already gone, marker still standing. |
| 374 | if err := s.Delete(ctx, "apps/bab/derp/channels/stable.json"); err != nil { |
| 375 | t.Fatal(err) |
| 376 | } |
| 377 | if err := PurgeApp(ctx, s, pub, "bab", "derp", time.Now()); err != nil { |
| 378 | t.Fatalf("purge of a half-purged app: %v", err) |
| 379 | } |
| 380 | if got := listUnder(t, s, "apps/bab/derp/"); len(got) != 0 { |
| 381 | t.Fatalf("purge left objects behind: %v", got) |
| 382 | } |
| 383 | if err := PurgeApp(ctx, s, pub, "bab", "derp", time.Now()); !errors.Is(err, ErrNotTrashed) { |
| 384 | t.Fatalf("second purge = %v, want ErrNotTrashed", err) |
| 385 | } |
| 386 | } |
| 387 | |
| 388 | // storeJSON writes apps/<acct>/<app>/store.json, overwriting whatever is |
| 389 | // there — the purge guard's input, hand-rolled here because release cannot |
| 390 | // import objstore (objstore imports release). The bytes ARE the contract. |
| 391 | func storeJSON(t *testing.T, s Store, acct, app, body string) { |
| 392 | t.Helper() |
| 393 | key := "apps/" + acct + "/" + app + "/store.json" |
| 394 | _, etag, err := s.Get(ctx, key) |
| 395 | if err != nil && !errors.Is(err, os.ErrNotExist) { |
| 396 | t.Fatal(err) |
| 397 | } |
| 398 | if _, err := s.Put(ctx, key, []byte(body), etag); err != nil { |
| 399 | t.Fatal(err) |
| 400 | } |
| 401 | } |
| 402 | |
| 403 | // Contract 6: a store with backend estate refuses the purge. Auto-purge runs |
| 404 | // on boxes; boxes hold no backend authority, so a swept store.json is a paid |
| 405 | // bucket nothing remembers. BOTH witnesses count: `provisioned` (the finished |
| 406 | // store) and `grant` (a grant that may have crashed after creating the bucket |
| 407 | // and the IAM user but before recording them). A declared-only record has no |
| 408 | // estate behind it and is swept like any other object. |
| 409 | func TestPurgeAppRefusesProvisionedOrGrantedStore(t *testing.T) { |
| 410 | _, pub := testKeys(t) |
| 411 | |
| 412 | for _, tc := range []struct { |
| 413 | name string |
| 414 | body string |
| 415 | }{ |
| 416 | {"provisioned", `{"schema":1,"app":"derp","declared":{"env_prefix":"CARLOS_STORE"},"provisioned":{"bucket":"carlos-store-tito-bab-derp","key_id":"AKIA"}}`}, |
| 417 | // A grant block with NO provisioned block: the earliest bucket-visible |
| 418 | // witness that backend estate may already exist. |
| 419 | {"grant-only", `{"schema":1,"app":"derp","declared":{"env_prefix":"CARLOS_STORE"},"grant":{"backend":"aws","by":"paul@keymail.dev"}}`}, |
| 420 | // Unreadable is not "no store" — same direction as the production flag. |
| 421 | {"unparseable", `{"schema":1,`}, |
| 422 | } { |
| 423 | t.Run(tc.name, func(t *testing.T) { |
| 424 | s := NewDirStore(t.TempDir()) |
| 425 | keys := seedApp(t, s, "bab", "derp") |
| 426 | storeJSON(t, s, "bab", "derp", tc.body) |
| 427 | if err := TrashApp(ctx, s, "bab", "derp", "paul@keymail.dev", time.Now().Add(-31*24*time.Hour)); err != nil { |
| 428 | t.Fatal(err) |
| 429 | } |
| 430 | err := PurgeApp(ctx, s, pub, "bab", "derp", time.Now()) |
| 431 | if !errors.Is(err, ErrStoreProvisioned) { |
| 432 | t.Fatalf("PurgeApp = %v, want ErrStoreProvisioned", err) |
| 433 | } |
| 434 | // The refusal names the app: one line in the auto-purge log has to |
| 435 | // be enough to know which store needs tearing down. |
| 436 | if !strings.Contains(err.Error(), "bab/derp") { |
| 437 | t.Errorf("refusal %q does not name the app", err) |
| 438 | } |
| 439 | if got := listUnder(t, s, "apps/bab/derp/"); len(got) != len(keys)+2 { |
| 440 | t.Fatalf("a refused purge destroyed objects: %v", got) |
| 441 | } |
| 442 | }) |
| 443 | } |
| 444 | |
| 445 | // Declared-only: no backend estate exists, so the purge proceeds and |
| 446 | // sweeps store.json along with everything else. |
| 447 | t.Run("declared-only", func(t *testing.T) { |
| 448 | s := NewDirStore(t.TempDir()) |
| 449 | seedApp(t, s, "bab", "derp") |
| 450 | storeJSON(t, s, "bab", "derp", `{"schema":1,"app":"derp","declared":{"env_prefix":"CARLOS_STORE"}}`) |
| 451 | if err := TrashApp(ctx, s, "bab", "derp", "paul@keymail.dev", time.Now().Add(-31*24*time.Hour)); err != nil { |
| 452 | t.Fatal(err) |
| 453 | } |
| 454 | if err := PurgeApp(ctx, s, pub, "bab", "derp", time.Now()); err != nil { |
| 455 | t.Fatalf("PurgeApp of a declared-only store: %v", err) |
| 456 | } |
| 457 | if got := listUnder(t, s, "apps/bab/derp/"); len(got) != 0 { |
| 458 | t.Fatalf("purge left objects behind: %v", got) |
| 459 | } |
| 460 | }) |
| 461 | |
| 462 | // An explicitly null block is absent, not present: a record that has been |
| 463 | // torn down keeps its keys with null values and must not wedge the purge. |
| 464 | t.Run("null-blocks", func(t *testing.T) { |
| 465 | s := NewDirStore(t.TempDir()) |
| 466 | seedApp(t, s, "bab", "derp") |
| 467 | storeJSON(t, s, "bab", "derp", `{"schema":1,"app":"derp","grant":null,"provisioned":null}`) |
| 468 | if err := TrashApp(ctx, s, "bab", "derp", "paul@keymail.dev", time.Now().Add(-31*24*time.Hour)); err != nil { |
| 469 | t.Fatal(err) |
| 470 | } |
| 471 | if err := PurgeApp(ctx, s, pub, "bab", "derp", time.Now()); err != nil { |
| 472 | t.Fatalf("PurgeApp of a torn-down store: %v", err) |
| 473 | } |
| 474 | }) |
| 475 | } |
| 476 | |
| 477 | // erroringGetStore fails Get for one key with something that is NOT |
| 478 | // os.ErrNotExist — the transport-level "I cannot tell you whether this app |
| 479 | // has a store" the guard must refuse on. |
| 480 | type erroringGetStore struct { |
| 481 | Store |
| 482 | failKey string |
| 483 | } |
| 484 | |
| 485 | func (e erroringGetStore) Get(ctx context.Context, key string) ([]byte, string, error) { |
| 486 | if key == e.failKey { |
| 487 | return nil, "", errors.New("injected: get failed") |
| 488 | } |
| 489 | return e.Store.Get(ctx, key) |
| 490 | } |
| 491 | |
| 492 | // Contract 6b: a store record the box cannot READ refuses too. "I could not |
| 493 | // ask" is not "there is no store". |
| 494 | func TestPurgeAppRefusesUnreadableStoreRecord(t *testing.T) { |
| 495 | _, pub := testKeys(t) |
| 496 | base := NewDirStore(t.TempDir()) |
| 497 | s := erroringGetStore{Store: base, failKey: "apps/bab/derp/store.json"} |
| 498 | keys := seedApp(t, base, "bab", "derp") |
| 499 | if err := TrashApp(ctx, base, "bab", "derp", "paul@keymail.dev", time.Now().Add(-31*24*time.Hour)); err != nil { |
| 500 | t.Fatal(err) |
| 501 | } |
| 502 | err := PurgeApp(ctx, s, pub, "bab", "derp", time.Now()) |
| 503 | if err == nil { |
| 504 | t.Fatal("purge acted on an unreadable store record") |
| 505 | } |
| 506 | if got := listUnder(t, base, "apps/bab/derp/"); len(got) != len(keys)+1 { |
| 507 | t.Fatalf("a refused purge destroyed objects: %v", got) |
| 508 | } |
| 509 | } |
| 510 | |
amadan