| 1 | package console |
| 2 | |
| 3 | import ( |
| 4 | "encoding/json" |
| 5 | "errors" |
| 6 | "testing" |
| 7 | "time" |
| 8 | |
| 9 | "github.com/carlosframework/platform/internal/hostops" |
| 10 | "github.com/carlosframework/platform/internal/objstore" |
| 11 | "github.com/carlosframework/platform/internal/release" |
| 12 | ) |
| 13 | |
| 14 | func putNameClaim(t *testing.T, s release.Store, kind string, c objstore.NameClaim) { |
| 15 | t.Helper() |
| 16 | body, err := json.Marshal(c) |
| 17 | if err != nil { |
| 18 | t.Fatal(err) |
| 19 | } |
| 20 | if _, err = s.Put(t.Context(), "objstore/name-claims/"+kind+"/"+c.Name+".json", body, ""); err != nil { |
| 21 | t.Fatal(err) |
| 22 | } |
| 23 | } |
| 24 | |
| 25 | // Review P2-8: ownership comes only from the durable name claim in its exact |
| 26 | // deterministic form; app-writable store records prove nothing. |
| 27 | func TestResolveStoreRequiresProvenNameClaim(t *testing.T) { |
| 28 | ctx := t.Context() |
| 29 | data := release.NewDirStore(t.TempDir()) |
| 30 | d := objstore.Deployment{BucketPrefix: "cf-"} |
| 31 | g := backendGuard{data: data, deployment: d} |
| 32 | now := time.Date(2026, 10, 7, 12, 0, 0, 0, time.UTC) |
| 33 | |
| 34 | // Another tenant's unclaimed (legacy) bucket. v2 attributed it to any |
| 35 | // permitted app whose own (app-writable) store record named it; there is |
| 36 | // no record path any more, so no permit or record can reach it. |
| 37 | for _, m := range []string{"EmptyBucket", "DeleteBucket", "EnsureBucket", "EnsureEnabled", "Scan", "EnsureUser:bucket"} { |
| 38 | if _, err := g.resolveStore(ctx, "buckets", "legacy-victim", m); !errors.Is(err, errBackendUnproven) { |
| 39 | t.Fatalf("%s on an unclaimed bucket: %v", m, err) |
| 40 | } |
| 41 | } |
| 42 | if _, err := g.resolveStore(ctx, "users", "carlos-store-zed-web", "DeleteUser"); !errors.Is(err, errBackendUnproven) { |
| 43 | t.Fatalf("unclaimed user: %v", err) |
| 44 | } |
| 45 | |
| 46 | // Minted and claimed: owned by the claim holder. |
| 47 | minted := objstore.MintedBucketIn(d, "bab", "demo", "") |
| 48 | putNameClaim(t, data, "buckets", objstore.NameClaim{Schema: 1, Name: minted, Account: "bab", App: "demo", CreatedAt: now}) |
| 49 | scopes, err := g.resolveStore(ctx, "buckets", minted, "DeleteBucket") |
| 50 | if err != nil || len(scopes) != 1 || scopes[0] != (hostops.AppScope{Account: "bab", App: "demo"}) { |
| 51 | t.Fatalf("minted claimed bucket: %v %v", scopes, err) |
| 52 | } |
| 53 | |
| 54 | // Adopted (non-minted) and claimed: only create-if-absent. |
| 55 | putNameClaim(t, data, "buckets", objstore.NameClaim{Schema: 1, Name: "adopted-name", Account: "bab", App: "demo", CreatedAt: now}) |
| 56 | if _, err = g.resolveStore(ctx, "buckets", "adopted-name", "EnsureBucket"); err != nil { |
| 57 | t.Fatalf("EnsureBucket on an adopted claimed bucket: %v", err) |
| 58 | } |
| 59 | for _, m := range []string{"EmptyBucket", "DeleteBucket", "EnsureEnabled", "Scan", "EnsureUser:bucket"} { |
| 60 | if _, err = g.resolveStore(ctx, "buckets", "adopted-name", m); !errors.Is(err, errBackendUnproven) { |
| 61 | t.Fatalf("%s on an unproven adopted bucket: %v", m, err) |
| 62 | } |
| 63 | } |
| 64 | |
| 65 | // A user claim whose name is not the holder's deterministic name. |
| 66 | putNameClaim(t, data, "users", objstore.NameClaim{Schema: 1, Name: "carlos-store-zed-web", Account: "bab", App: "demo", CreatedAt: now}) |
| 67 | if _, err = g.resolveStore(ctx, "users", "carlos-store-zed-web", "DeleteUser"); !errors.Is(err, errBackendUnproven) { |
| 68 | t.Fatalf("forged user claim: %v", err) |
| 69 | } |
| 70 | } |
| 71 | |
| 72 | // Review P2-8: a mail user name is never parsed back at "+s+" onto its |
| 73 | // parent's record; with no caller index of its own it is unproven. |
| 74 | func TestResolveMailUserNoReverseParse(t *testing.T) { |
| 75 | ctx := t.Context() |
| 76 | data := release.NewDirStore(t.TempDir()) |
| 77 | g := backendGuard{data: data} |
| 78 | body, _ := json.Marshal(map[string]any{"schema": 1, "iam_user": "carlos-mail-bab-demo", "account": "bab", "app": "demo", "sender": "", "created_at": time.Now()}) |
| 79 | if _, err := data.Put(ctx, "email/callers/carlos-mail-bab-demo.json", body, ""); err != nil { |
| 80 | t.Fatal(err) |
| 81 | } |
| 82 | if _, err := g.resolveMailUser(ctx, "carlos-mail-bab-demo+s+evil"); !errors.Is(err, errBackendUnproven) { |
| 83 | t.Fatalf("standalone name resolved through its parent's record: %v", err) |
| 84 | } |
| 85 | scopes, err := g.resolveMailUser(ctx, "carlos-mail-bab-demo") |
| 86 | if err != nil || len(scopes) != 1 || scopes[0] != (hostops.AppScope{Account: "bab", App: "demo"}) { |
| 87 | t.Fatalf("exact caller index: %v %v", scopes, err) |
| 88 | } |
| 89 | } |
| 90 | |
amadan