| 1 | # Review brief: edge asset cache plans |
| 2 | |
| 3 | Plans: `docs/superpowers/plans/2026-10-24-edge-asset-cache-plan-1-declare-publish.md`, |
| 4 | `-plan-2-disk-store.md`, `-plan-3-serve.md`. Spec: |
| 5 | `docs/superpowers/specs/2026-10-24-edge-asset-cache-design.md` rev 9 (rev 8 |
| 6 | accepted in round 6; rev 9 only narrows the no-Content-Type rule, review it |
| 7 | too). |
| 8 | |
| 9 | You are an independent second reader of implementation plans. An engineer |
| 10 | who has not seen this codebase will build each task from the plan alone. |
| 11 | |
| 12 | ## Fixed points |
| 13 | |
| 14 | The spec as accepted, and Paul's rulings R1 to R3. Do not re-argue the |
| 15 | design; report where a plan fails to implement it. |
| 16 | |
| 17 | ## What to look for |
| 18 | |
| 19 | 1. A spec requirement no task implements, or implements differently. |
| 20 | 2. A named file, function, field, line range or helper that does not exist |
| 21 | or does not do what the plan says. Check against the tree. |
| 22 | 3. An interface used in a later task that no earlier task produces, or |
| 23 | produces with a different name or type, within and across the plans. |
| 24 | 4. A test that cannot fail for the reason it names, or cannot be written |
| 25 | as described with the helpers named. |
| 26 | 5. Ordering: a task that needs something only a later task or plan builds. |
| 27 | 6. Census, copy review, cross-compile or CI rules the plans state wrongly. |
| 28 | 7. Every new top-level identifier the plans name, checked against the |
| 29 | package it lands in for a collision. |
| 30 | |
| 31 | ## Output |
| 32 | |
| 33 | Numbered findings, most severe first: severity (P1 the plan cannot be |
| 34 | built as written, P2 must be fixed before building, P3 worth noting), the |
| 35 | plan and task, the evidence with file:line, and the smallest fix. End with |
| 36 | "accept" or "reject". |
| 37 | |
amadan