amadan

carlos / platform Public

Clone 
git clone https://amadan.net/carlos/platform

Plain git — no account needed to clone.

Download

Download this file

Three new findings:

  1. P1 — Operator approval does not remove the AWS identity requirement. Spec:557 delegates non-AWS enrolment to existing hostactors.Enroll. That path still requires AWSRegion and verifies an AWS-signed identity (enroll.go:29). Roster validation explicitly requires Cloud.Provider == "aws" (roster.go:111), and hosting re-verifies the AWS evidence (identity.go:45).

Failure scenario: an operator approves a bare-metal host with MinIO and configured addresses, but it cannot enrol or enter hosting mode. The membership-confirmer interface does not cover this separate identity dependency. Specify a provider-neutral identity contract through enrolment and admission, preserving reference uniqueness and replacement isolation.

  1. P2 — “Unchanged” placement still excludes non-AWS hosts. Spec:554 treats placement as provider-neutral because it calls no cloud API. However, boxchoice.Eligible:110 requires an AWS region and Cloud.Complete(), which explicitly requires provider aws (verify.go:30).

Failure scenario: even after adding non-AWS enrolment, both healthy hosts remain ineligible and every create stays pending. Separate placement-region membership from AWS evidence. These checks already import no AWS SDK, so the proposed import test cannot enforce that distinction.

  1. P2 — The no-AWS test omits a lifecycle write that still targets AWS. Spec:575 requires enrolment, placement, forwarding and health checks, but no actual generation publication. The production marker client uses plain s3.NewFromConfig, without the s3compat.Options() that applies CARLOS_S3_ENDPOINT (claimproduction_marker.go:21).

Failure scenario: with MinIO configured through CARLOS_S3_ENDPOINT, ordinary bucket operations succeed, but generation publication sends its write to AWS and fails (claimowners.go:586). Classify compatible-store transport explicitly and require the no-AWS test to exercise production admission, generation publication and relocation, with unexpected AWS/IMDS requests rejected.

Reviewed platform d2361b2a and flagship 7c99ff8f. No files changed; no builds, tests or infrastructure commands run.

---

FIRST PROMPT: Review spec 2 round 13 at the pinned HEAD against flagship tofu, read-only.

WHAT: Check the provider boundary and no-AWS fallback.

STATUS: Review complete: one P1 and two P2 findings.

NEEDED: Nothing.

RECOMMENDED: Resolve the identity, placement and compatible-store gaps before planning.

SESSION: Safe to close; nothing modified or started.

Verdict: not ready for a plan.