carlos / platform Public

Clone
git clone https://amadan.net/carlos/platform

Plain git — no account needed to clone.

Download

Download this file

No P1/P2 findings. One nonblocking P3:

P3 — The rule catalogue still describes the rejected landing boundary. rules_test.go:211 says source protection lasts “until the target’s probe is admitted.” The implementation now correctly retains it until op.Committed. Update that description and mention the post-admission rollback witness.

The brief’s substantive questions are resolved:

  • Commit boundary: the record’s landing → committed transition rules out rollback; both transitions require landing. Using op.Committed in filesHome safely retains source files slightly longer. The claim transition setting it also queues the source’s whole-location park at moves_test.go:974.
  • INV-30’s region set: appropriate for this preservation property. Moves §5.1 describes current-generation authority; rollback additionally requires preserving the source. After a dirty target releases, recovery proceeds in the source region, so dropping the target is appropriate.
  • Independence: servableRegions and checkFilesPreserved consult neither filesHome nor mutation flags. Remembering the previous manifest prevents deletion from silently redefining the expected state. This adequately covers J1’s preservation defect.
  • Regression evidence: the new witness follows the requested delayed-park, clean-rollback, no-republication, source-failover sequence. The separate INV-30-disabled tests retain INV-3 liveness evidence. The matcher correctly distinguishes INV-3 from INV-30.
  • J2/J3: unchanged against stage A fe144bab; this fix does not close them.

git diff --check and package formatting passed. Go tests could not start because the read-only sandbox refused the build directory. The reported sweeps and identity hashes remain supplied evidence, not independently rerun results.

---

FIRST PROMPT: Review J1 fix round 2 at 00bd0abe against the R3 brief and stage A fe144bab.

WHAT: Check J1 closure, rollback preservation and regressions.

STATUS: Review complete: one nonblocking P3; test execution blocked by sandbox restrictions.

NEEDED: Nothing from you.

RECOMMENDED: Correct the stale rule description.

SESSION: Safe to close. No files changed or processes left running; read-only access prevented saving a handoff file.

Verdict: J1 is closed at 00bd0abe, with the nonblocking wording correction above.