carlos / platform Public

Clone
git clone https://amadan.net/carlos/platform

Plain git — no account needed to clone.

Download

Download this file

1**P2 — Source files lose protection before rollback is ruled out.** [regionha_test.go:2141](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/region-ha-two-box-build/internal/sim/hostlife/regionha_test.go:2141)
2
3The `landing` branch stops protecting the source region when the target’s admission changes `holder.Gen`. Admission does not commit the move; a clean rollback remains possible.
4
5The reachable sequence is:
6
71. Use the new stopped-move witness’s setup: a source restart queues a generation park, while the older generation holds the keyed manifest.
82. Delay that park until the target probe is admitted, before commit. `filesHome` now returns false for the source, allowing the sibling to archive its manifest and referenced object.
93. Roll back cleanly. [moves_test.go:1509](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/region-ha-two-box-build/internal/sim/hostlife/moves_test.go:1509) restores the source generation.
104. The unchanged-files publisher can skip republication at [regionha_test.go:2014](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/region-ha-two-box-build/internal/sim/hostlife/regionha_test.go:2014). A subsequent source failure leaves failover without the keyed manifest.
11
12At `a2ef0203`, the region-blind chain lookup preserved that source manifest. This is a regression introduced by the regional restriction. It is established by static tracing, **not an executed reproduction**.
13
14**Fix:** preserve the source rollback files and their references until rollback is ruled out. Add a witness that delays the queued park until after target admission, rolls back cleanly, then requires source-region failover to succeed.
15
16The other answers to the brief:
17
18- **Original late-PUT defect:** the region-qualified lookup addresses it, and the revised witness covers both the manifest and object.
19- **Phase table:** “no home” for creating, deleting, parking and purging agrees with §5.1. Keeping the source region throughout relocation agrees with claim §6.2a’s unchanged-region rule, including pinning without an executor. The landing condition follows the table’s current-generation authority, but that alone does not preserve the files needed for rollback.
20- **Optional invariant:** add independent preservation coverage, including rollback files. Keep the existing INV-3 scenarios as separate liveness evidence; their expected failure strings should not prevent a safety check. An invariant derived from the same `filesHome` predicate would miss this defect.
21- **J2/J3:** unchanged by this fix.
22
23`git diff --check` and package formatting passed. Go tests could not run because the sandbox refused creation of the build directory. The supplied sweep results and identity hashes remain independently unverified.
24
25---
26
27**FIRST PROMPT:**
28Review the J1 fix at dfab457c against the R2 brief and stage A fe144bab.
29
30**WHAT:**
31Check J1 closure, phase semantics and regressions.
32
33**STATUS:**
34Review complete; one P2 rollback-preservation finding.
35
36**NEEDED:**
37Nothing from you.
38
39**RECOMMENDED:**
40Preserve rollback files and add the post-admission rollback witness.
41
42**SESSION:**
43Safe to close. No files changed or processes left running; the read-only workspace prevented saving a handoff file.
44
45**Verdict: J1 is not closed.**