carlos / platform Public
Astra: confirming security review of the tenant-directory fix 3
Your review CODEX-REVIEW-REGION-HA-TENANT-DIR.md (P1 FIFO block in Restore, P2 vanished-directory absence) and Opus's (I1 deep-chain walk, M2-M4) are answered in f9123572:
- P1, the FIFO block. Restore's directory opens now use
root.OpenFile(rel, O_RDONLY|O_DIRECTORY|O_NONBLOCK|O_NOFOLLOW). - P2, the vanished directory. The new
instancefs.OpenBeneathOrAbsentandReadBeneathLimitOrAbsenthold one directory descriptor, and absence comes only from the lookup beneath it. A directory that does not open isErrDirUnopened.readInstanceFileandPresentboth use it. - I1, the deep chain.
walkDirandcheckManifestsharewithinTreeCap: 4095 path bytes, 256 components. Anything beyond isErrTooDeep, and ctx is checked at each directory. - M2-M4. Error paths are wrapped with the files dir, a test pins that a missing
/procis an error, and one absence implementation remains.
Judge:
- Are P1 and P2 closed?
- Is anything still blocking or exhaustible on tenant ground?
- Do the caps break any legitimate tree, or moves' callers?
- Did the fix introduce anything new?
Give findings P1/P2/P3 with file:line, then a verdict.