carlos / platform Public

Clone
git clone https://amadan.net/carlos/platform

Plain git — no account needed to clone.

Download

Download this file

Astra: L18 joint round, round 5 (confirming)

Round 4 (CODEX-REVIEW-L18-JOINT-ROUND-FINAL-4.md) closed finding 1 and raised two P2s. Both are now fixed.

  1. The relocation probe dropped Staged. Fixed in 3320b9ce on this branch. RelocationWakeInputs.Select (internal/host/relocationwake.go) now forwards Staged: l.Staged. Every path through Select shares that one value.

The builder found no other place that drops it: - the serving wake after completion uses claimowners.go, which already forwards it; - ColdHandover builds no launch inputs; - relocationinstall.go and relocationassembly.go construct only DBPath.

The test TestTheRelocationProbeStartNamesTheBuildItHashed drives the real activator.ClaimRuntime. It fails without the fix. It copies claimedBuild's condition rather than calling it, because that function is unexported.

  1. The model's dirty return ignored target admission. Fixed in region-ha-two-box-build at 3b895b42. Three places now require the claim to record the target's admission of this move, mirroring movesinstall.go's targetAdmitted: - filesHome; - the INV-30 oracle servableRegions; - the install park.

The new witness wDirtyReturnWithoutAdmission covers this, and the new mutation dirty-return-needs-admission is killed by INV-30. TestFilesWitnessesStuckWithoutINV30 now skips the new witness: that scenario has no liveness consequence, so INV-30 is its only oracle. The unmutated 3000-seed run had no failures.

Judge:

  1. Are both round-4 items closed?
  2. Is the TestFilesWitnessesStuckWithoutINV30 exclusion sound?
  3. Anything new? Only report what these two diffs introduce. Do not re-review settled rulings or the main merge again.
  4. Verdict: may relocation merge dormant?

Give findings P1/P2/P3 with file:line.