carlos / platform Public

Clone
git clone https://amadan.net/carlos/platform

Plain git — no account needed to clone.

Download

Download this file

1**Verdict: no—two new P2 findings block the dormant merge.** Reviewed build `5fbe1824` against model `eaa08175`.
2
31. **P2 — Relocation probes lose the newly required staged identity.** [relocationwake.go:146](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/region-ha-1b-next-build/internal/host/relocationwake.go:146) copies `l.Version` but omits `Staged: l.Staged`. With production’s `BeforeExec` hook enabled, the merged activator rejects the empty staged version before restore or execution ([beforeexec.go:90](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/region-ha-1b-next-build/internal/activator/beforeexec.go:90)). Relocation probes therefore cannot start. Forward the identity and cover the launch with `BeforeExec` enabled.
4
52. **P2 — The model drops source protection for dirty returns without target admission.** [regionha_test.go:2641](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/region-ha-two-box-build/internal/sim/hostlife/regionha_test.go:2641) treats every dirty return as having a target admission. However, `SrcCovered=false` makes a return dirty even when the target never admitted. The helper then removes source-files protection and excludes the interval from INV-30. Built code explicitly preserves those generations when `targetAdmitted` is false ([movesinstall.go:406](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/region-ha-1b-next-build/internal/host/movesinstall.go:406)). Require admission evidence in the model and add the complementary witness; the new witness always admits the target first.
6
7**Finding 1 is closed:** [movessources.go:502](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/region-ha-1b-next-build/internal/host/movessources.go:502) preserves source authority through `releasing` and `released`, until the return CAS. The merged callers retain that protection.
8
9No further regression established in the completion barriers, `EndProbe`/`flushStopped`, verified completion-fence exemption, or census/copy gate changes. Targeted tests failed before execution because Go could not create its build directory on the read-only filesystem. The full `internal/host` suite was not run.
10
11---
12
13**FIRST PROMPT:**
14Review the round-4 brief at build `5fbe1824` against model `eaa08175`, read-only.
15
16**WHAT:**
17Determine whether relocation may merge dormant.
18
19**STATUS:**
20Review complete: two new P2 findings; finding 1 closed.
21
22**NEEDED:**
23Nothing for this review.
24
25**RECOMMENDED:**
26Fix both findings, add targeted regression coverage, and rerun the required gates.
27
28**SESSION:**
29Safe to close; no files changed or background processes started.