| 1 | # Review brief: temporary static sites implementation plan |
| 2 | |
| 3 | You are an independent second reader of an implementation plan for the |
| 4 | CARLOS platform (this repository). Read cold and adversarially. |
| 5 | |
| 6 | **Plan:** `docs/superpowers/plans/2026-09-26-temporary-static-sites.md` |
| 7 | at the commit named in the prompt. |
| 8 | **Spec it implements:** `docs/superpowers/specs/2026-09-25-temporary-static-sites-design.md` |
| 9 | (rev 9). The spec was reviewed by you over nine rounds and accepted, and |
| 10 | the product owner has approved it. **Do not re-review the design.** Its |
| 11 | rulings (§1) and mechanisms are fixed. |
| 12 | |
| 13 | ## What to check |
| 14 | |
| 15 | The plan will be executed task by task by implementers who see only |
| 16 | their own task. Check: |
| 17 | |
| 18 | 1. **Fidelity.** Does each task implement the spec's mechanism as |
| 19 | written? Flag any place where the plan weakens, reorders or omits |
| 20 | something the spec requires, especially the orderings (§6 restore |
| 21 | steps, §5 expire steps, settle-first, the tripwire rules) and every |
| 22 | row of the §3 and §4 refusal tables. |
| 23 | 2. **Will it compile and pass?** Code in the plan is written against |
| 24 | this repo but has not been compiled. Check signatures, imports, |
| 25 | receiver types, helper names and test fixtures against the real |
| 26 | code. Cite `file:line`. |
| 27 | 3. **Cross-task consistency.** Names and types a later task consumes |
| 28 | must match what an earlier task produces. |
| 29 | 4. **Tests that would pass for the wrong reason**, or that do not |
| 30 | exercise the ordering or race they claim to. |
| 31 | 5. **Existing behaviour broken.** Box code must not change, and no |
| 32 | bucket object may change shape. Flag any existing test the plan |
| 33 | would break without saying so. |
| 34 | |
| 35 | ## Output |
| 36 | |
| 37 | A numbered list of findings. Give each one a severity (P1 means the |
| 38 | build is wrong or a spec guarantee is lost, P2 means wrong behaviour or |
| 39 | a test that proves nothing, P3 means clarity), the task and step, the |
| 40 | evidence with `file:line`, and a concrete fix. Then give a one-line |
| 41 | verdict: accept or revise. Do not rewrite the plan, and leave out |
| 42 | praise. |
| 43 | |
| 44 | In later rounds you will be given your earlier findings files. Start |
| 45 | with a disposition table, then list only new findings. |
| 46 | |
amadan