carlos / platform Public

Clone
git clone https://amadan.net/carlos/platform

Plain git — no account needed to clone.

Download

Download this file

Review brief: region HA plan 1b, round 3

You are an independent second reader. Review the implementation plan docs/superpowers/plans/2026-10-06-region-ha-1b-claim-readers.md at the commit named in the prompt, against the tree at the working directory (Go, module github.com/carlosframework/platform) and the approved spec docs/superpowers/specs/2026-10-04-region-ha-box-placement-design.md (rev 5.4; rulings H1–H19 in §0). Your round 2 findings are in CODEX-PLAN-REGION-HA-1B-R2.md; the author's answers are the table "Astra plan round 2: dispositions" at the end of the plan.

Fixed: do not re-argue

  • The spec's rulings H1 to H19, and Paul's approval of rev 5.4.
  • The scope rule: plan 1b builds only what needs none of the spec's L1–L20 claim/moves changes; everything under "Waits for the claim" is out of scope.
  • The controller rulings in the plan's header (six, unchanged).
  • Everything stays dormant behind CARLOSREGIONHA and changes nothing on a one-box region.
  • Round 1 findings you marked resolved in round 2 (R1-1 to R1-4, R1-7), and round 1 and 2 findings the dispositions mark fixed, unless the fix itself is wrong; say which, and why.

What changed since round 2

  • Task 6, edgesLoopState (in internal/host/edgesclaims.go): a claim pass now waits for the schedule's retryAt, and every pass, claim passes included, records its outcome through edgesFileSchedule.done. New test TestEdgesLoopClaimPassesObeyTheRetryBackoff.
  • Task 5, TestDischargeRefusesStoredRecordsThatAreNotEvidence: three new stored cases, one per check (empty mapping, terminated state with a mapping, a volume with no device).

Nothing else changed.

What to check

  1. The round 2 table first: are R2-1 and R2-2 (and so R1-5 and R1-6) resolved, partly resolved (say what is left), or not resolved?
  2. Then only new findings, in the two changed places or anything they break. In particular: can recording a claim pass's success through edgesFileSchedule.done advance the change-detection baseline past a registry change that pass did not publish? Does the backoff gate delay a timer pass or a change pass that would not have been delayed before, with the flag off or on?
  3. As before: the code compiles, the tests pass as written, and each new test fails with its mechanism removed.

Output

Findings ranked P1 (would not compile, a test fails, or unsafe), P2 (wrong or missing), P3 (clarity). Each: task and step, the problem, the evidence (file:line, or the plan's own line), and a concrete fix. Start with the round 2 table, then new findings only. End with a verdict: ready to build, or not ready.