carlos / platform Public

| Earlier finding | Disposition | |---|---| | R1.1 — Manual purge omits settlement | Fixed: settlement precedes purge prerequisites and teardown. | | R1.2 — Destructive handlers retain pre-lock decisions | Fixed: existence and protection are rechecked under the lock. | | R1.3 — ErrNotTrashed tests bypass recovery | Fixed: marker removal occurs between reads; recovery execution is asserted. | | R1.4 — Static-instance test accepts unrelated failures | Fixed: requires 201 and verifies the stored record. | | R1.5 — Empty --ttl selects ordinary deployment | Fixed: explicit flag presence is checked and tested. | | R2.1 — Required implementation file omitted from commit | Fixed: Task 5 stages svcprincipal.go. | | R2.2 — Settlement breaks trash retries | Fixed: an existing marker permits idempotent success. | | R2.3 — Refusal wording breaks existing assertions | Fixed: existing wording is retained. | | R3.1 — Delete confirmation promises 30 days | Fixed: confirmation selects three or 30 days, with tests. | | R3.2 — Refusal test decodes plain-text 404 as JSON | Fixed: uses rawReq and checks unchanged state. | | R4.1 — Restore guidance names a forbidden command | Fixed in the previously cited responses; another affected surface remains below. | | R5.1 — CLI documentation promises restored temporary sites remain unrouted | Fixed: Task 11 explains automatic route recreation, within C11.26. |

Reviewed 62839303. Static review only; no tests run or files changed.

1. P2 — Task 10, Step 3: CLI usage still directs restored temporary apps to a forbidden command. The instruction at plan:5323 updates only the restore window in appsUsage. It leaves apps.go:96 saying “NO routes come back” and directing users to carlos add <host>. Running carlos apps prints this text. Task 3 makes that command refuse every tmp- app, while retained instance records recreate its routes automatically.

Fix: update the restore usage paragraph to explain automatic route recreation for tmp- apps, including kept ones. Include the paragraph in C10.13 and add a usage-text regression assertion.

Verdict: revise.

---

FIRST PROMPT: Review the temporary-sites plan at 62839303, round 6, dispositioning round 5 findings first.

WHAT: Check plan fidelity, implementation contracts and tests.

STATUS: Review complete: one new P2 finding in CLI usage.

NEEDED: Nothing.

RECOMMENDED: Correct Task 10’s restore usage paragraph.

SESSION: Safe to close. Existing untracked files remain untouched. Handoff file not written because the workspace is read-only.