carlos / platform Public

| Earlier finding | Disposition | |---|---| | R1.1 — Manual purge omits settlement | Fixed: settlement precedes purge prerequisites and teardown. | | R1.2 — Destructive handlers retain pre-lock decisions | Fixed: existence and protection are rechecked under the lock. | | R1.3 — ErrNotTrashed tests bypass recovery | Fixed: marker removal occurs between reads; recovery execution is asserted. | | R1.4 — Static-instance test accepts unrelated failures | Fixed: requires 201 and verifies the stored record. | | R1.5 — Empty --ttl selects ordinary deployment | Fixed: explicit flag presence is checked and tested. | | R2.1 — Required implementation file omitted from commit | Fixed: Task 5 stages svcprincipal.go. | | R2.2 — Settlement breaks trash retries | Fixed: an existing marker permits idempotent success. | | R2.3 — Refusal wording breaks existing assertions | Fixed: existing refusal wording is retained. | | R3.1 — Delete confirmation promises 30 days | Fixed: confirmation selects three or 30 days, with tests. | | R3.2 — Refusal test decodes plain-text 404 as JSON | Fixed: uses rawReq, checks the canonical 404 and unchanged state. | | R4.1 — Restore guidance names a forbidden command | Fixed in the cited CLI/API/browser responses, with a provisioned-site regression. A separate documentation inconsistency remains below. |

Reviewed 8d850c17. Static review only; no tests run or files changed.

1. P2 — Task 11, Step 3: CLI documentation promises that restored temporary sites remain unrouted. The replacement documentation at plan:6079 explicitly includes temporary apps, then says restore returns “no routes at all, not even the platform apex” and instructs users to add them again. This contradicts Task 7’s revised guidance at plan:3526: retained instance records cause routes to return automatically. That behavior is exercised by reconcile_test.go:1382. Someone following the documentation could restore a site expecting it to remain offline.

Fix: update Task 11’s restore paragraph to explain automatic route recreation from retained instance records for temporary sites. Include the correction in Task 0’s C11.26 copy review.

Verdict: revise.

---

FIRST PROMPT: Review the temporary-sites plan at 8d850c17, round 5, dispositioning earlier findings first.

WHAT: Check plan fidelity, correctness, integration and tests.

STATUS: Review complete: one new P2 documentation finding.

NEEDED: Nothing.

RECOMMENDED: Correct Task 11’s restore documentation.

SESSION: Safe to close. No processes started or files changed; existing untracked files remain. Handoff file not written because the workspace is read-only.