carlos / platform Public

| Earlier finding | Disposition | |---|---| | R1.1 — Manual purge omits settlement | Fixed: settlement precedes purge prerequisites and teardown. | | R1.2 — Destructive handlers retain pre-lock decisions | Fixed: existence and protection are rechecked under the lock. | | R1.3 — ErrNotTrashed tests bypass recovery | Fixed: marker removal occurs between reads; recovery execution is asserted. | | R1.4 — Static-instance test accepts unrelated failures | Fixed: requires 201 and verifies the stored record. | | R1.5 — Empty --ttl selects ordinary deployment | Fixed: explicit flag presence is checked and tested. | | R2.1 — Required implementation file omitted from commit | Fixed: Task 5 stages svcprincipal.go. | | R2.2 — Settlement breaks trash retries | Fixed: an existing marker permits idempotent success. | | R2.3 — Refusal wording breaks existing assertions | Fixed: the existing refusal wording is retained. | | R3.1 — Delete confirmation promises 30 days | Fixed: Task 10 selects three or 30 days, inventories the copy, and tests both. | | R3.2 — Refusal test decodes plain-text 404 as JSON | Fixed: uses rawReq, checks the canonical 404, and asserts unchanged state. |

Reviewed 240feb1b. Static review only; no tests run or files changed.

1. P2 — Tasks 7 and 10, Step 3: restore guidance names a command the plan now forbids. Plan:5138 tells users that carlos add <host> serves a restored app again. But Task 3’s appRail rejects every tmp- app at plan:1320, including kept apps. Task 7 also retains this instruction in the restore API response (apicli.go:1354) and browser flash (ownership.go:274). Following the advertised recovery path therefore fails.

Fix: update the delete and restore guidance for temporary apps and include it in Task 0. Explain that retained instance records allow reconciliation to recreate their routes after restore—the existing mint path does this at reconcile.go:903. Add a restore regression covering a provisioned temporary static app and its guidance, without changing box behavior.

Verdict: revise.

---

FIRST PROMPT: Review the temporary-sites plan at 240feb1b, round 4, dispositioning earlier findings first.

WHAT: Check plan fidelity, correctness, integration and tests.

STATUS: Review complete: earlier findings fixed; one new P2.

NEEDED: Nothing.

RECOMMENDED: Correct temporary-app recovery guidance and test the restore path.

SESSION: Safe to close. No processes started or files changed; existing untracked files remain. Handoff file not written because the workspace is read-only.