carlos / platform Public

Download this file

1	# Astra review r6: settings-5-surfaces task 8 (tenant change resolves fresh)
2
3	Range 3e24809f..8837f20a.
4
5	Verdict: ACCEPT
6
7	Reviewed only `git diff 3e24809f..8837f20a`. **I cannot run Go here; I ran no Go commands and modified no files.**
8
9	## r5 finding
10
11	**N1 ADDRESSED.** [registry.go:1127](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/settings-5-surfaces/internal/registry/registry.go:1127) adds `instr(col, char(0)) = 0`. SQLite’s `instr` searches using the value’s byte length, so it detects embedded NULs without stopping at them. [SQLite implementation](https://sqlite.org/src/doc/trunk/src/func.c)
12
13	By inspection, the combined predicate accepts exactly 3–16 lowercase ASCII letters and maps every other account string to `bab`, matching `controlname.ValidAccount` and `release.RouteAccount`. The same expression applies to both stored and incoming accounts.
14
15	The tests pin the reported failure:
16
17	- [updatesettings_test.go:160](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/settings-5-surfaces/internal/registry/updatesettings_test.go:160) adds seven SQL/Go equivalence cases covering leading, embedded, trailing and repeated NULs, including one after a 16-letter prefix.
18	- [updatesettings_test.go:124](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/settings-5-surfaces/internal/registry/updatesettings_test.go:124) adds six upsert transitions, including `"abc\x00x"` ↔ `"bab"`; line 132 asserts that both settings columns survive.
19
20	These are regression cases, not exhaustive enumeration. The general equivalence follows from the predicate. “Fix round 2” reports red-before/green-after results; I have not independently reproduced them.
21
22	## New findings in the fix diff
23
24	None found.
25
26	## Out of scope
27
28	Changes outside `3e24809f..8837f20a`, broader branch correctness, and landing gates.