| 1 | | Previous finding | Disposition at `29455f24` | |
| 2 | |---|---| |
| 3 | | R1-1 — Readiness without established database state | **Resolved.** Unknown pointers block readiness; off and expired pointers require empty mirrors. | |
| 4 | | R1-2 — `off` waits behind publication | **Resolved.** `TryLock` returns 409 while publication holds the slot. | |
| 5 | | R1-3 — Unbounded console pointer reads | **Resolved for reads.** Pointer reads are streamed and capped. | |
| 6 | | R1-4 — Recovery generation deleted after failed synchronization | **Resolved for the reported paths.** Installation failures preserve loaded and retained generations. | |
| 7 | | R1-5 — Rejected-upload test does not establish zero reads | **Resolved at the reservation boundary.** The panicking-reader test detects reads before reservation. | |
| 8 | | R1-6 — Countries overflow ordering | **Resolved.** `_other` remains intact until rendering and sorts last. | |
| 9 | | R2-1 — Feed status writes bypass the read cap | **Partly resolved; P2 remains.** `geoipfeed.go:174` still calls `Put`; `release/store.go:408` reads the entire existing object before checking its precondition. An oversized `feed.json` can still exhaust memory. Apply the stat/streamed-hash checks used by `PutFrom`. | |
| 10 | | R2-2 — Timed-out checks never persist failures | **Resolved for download timeouts.** Status persistence gets a separate bounded context. | |
| 11 | | R2-3 — Unreadable feed status clears an alert | **Resolved.** Read and parse failures preserve established feed state. | |
| 12 | | R2-4 — Unusable directory prevents “not loaded” alert | **Resolved.** Pointer state is retained before directory preparation. | |
| 13 | | R2-5 — Published alert reasons never change while unhealthy | **Resolved.** Reason changes update `Value` and emit an event. | |
| 14 | | R3-1 — Console follower keeps serving an expired database | **Resolved.** Loaded-reader expiry is checked independently of local state and candidate loading. | |
| 15 | | R3-2 — Transient status-read failure erases feed history | **Resolved.** Unknown history is not overwritten. | |
| 16 | | R4-1 — Unbounded bucket operations block startup or publication | **Resolved for the reported bucket operations.** Startup cleanup is asynchronous; maintenance and staging reads have deadlines. | |
| 17 | | R4-2 — Restart falsely clears a persisted GeoIP alert | **Resolved.** Unknown inputs cannot establish recovery. | |
| 18 | | R4-3 — Email delivery suppresses active reason changes | **Resolved.** Successful delivery records the last reason per recipient and resets other reason markers. | |
| 19 | | R4-4 — Region guesses carry another generation’s attribution | **Resolved.** Location and source are captured under one reader lock. | |
| 20 | | R5-1 — Unknown feed state suppresses confirmed expiry | **Resolved.** Established unhealthy conditions are evaluated before the unknown-state guard. | |
| 21 | | R6-1 — Failed startup deletion leaves a disabled feed alert firing indefinitely | **Resolved.** Deletion retries with bounded attempts and capped exponential backoff. | |
| 22 | | R7-1 — Unbounded feed edition metadata makes control records unreadable | **Resolved for the reported input.** MaxMind editions must parse as HTTP dates and are normalized; publication rejects oversized serialized pointers. | |
| 23 | | R7-2 — Unchanged-edition checks leave the feed reported as “not run yet” | **Resolved.** Both providers return the confirmed edition, allowing `Check` to record success and edition history. | |
| 24 | |
| 25 | New findings: |
| 26 | |
| 27 | 1. **P1 — MMDB verification can indefinitely hold the publish slot despite its deadline.** |
| 28 | [internal/console/geoippublish.go:216](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/geoip-for-apps/internal/console/geoippublish.go:216), [internal/geo/mmdb.go:41](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/geoip-for-apps/internal/geo/mmdb.go:41): `Commit` calls `OpenMMDB` synchronously while holding the publication mutex. The pinned `maxminddb-golang` verifier enumerates every network path without checking a context or limiting traversal work. A compact IPv6 database containing 128 nodes, with both children of each node pointing to the next and the final children pointing to one data record, causes enumeration of \(2^{128}\) paths. It passes the byte caps; verification runs before the country, type and shrink checks. |
| 29 | |
| 30 | A hostile feed response—or an operator uploading such a downloaded file—therefore leaves verification consuming CPU, publication and `off` returning 409, and staging retained beyond the 15-minute deadline. For the feed, `Check` never returns to persist a failure or schedule another check. Bound verification itself through a cancellable, work-limited verifier or a killable worker process. A timeout around an uncancelled goroutine is insufficient. Add a pathological-tree regression proving timely termination, slot release, staging cleanup and preservation of the previous pointer. |
| 31 | |
| 32 | Validation was static, including inspection of the pinned verifier. Targeted Go tests could not start because the work directory is read-only; cross-compilation remains unverified. |
| 33 | |
| 34 | Verdict: revise. |
| 35 | |
amadan