carlos / platform Public

Clone
git clone https://amadan.net/carlos/platform

Plain git — no account needed to clone.

Download

Download this file

Reviewed 4433a788..2fe0238c9a945e7ceb26235b82f2f7e755c305d1.

| Finding / before-merge item | Status and evidence | |---|---| | Finding 1: stalled membership read | ADDRESSED — membershipread.go:113 applies the 15-second deadline and classifies cancellation as unknown. The attempt and backoff remain unchanged; subsequent boxes continue. Regression coverage: autoenroll_test.go:256. | | Finding 2 / before-merge status mismatch | ADDRESSED — all three status overrides are excluded from hostenv.go:70. hostenv_test.go:398 checks rejection through both assembly and seeding. | | Finding 3 / before-merge webhook exclusion | ADDRESSED — CARLOS_ALERT_WEBHOOK is excluded from hostenv.go:70; the same regression checks refusal without exposing its value. | | Before merge: obsolete DNSimple allowance | ADDRESSED — the plan’s allowlist snippet:1152 excludes the token. | | Before merge: CheckConfirmed references | ADDRESSED — plan:2734 specifies unexported checkConfirmed and its internal confirmation. Remaining uppercase occurrences are historical census comments or the test rejecting that exported method. | | Before merge: bootstrap binary placement | ADDRESSED — plan:8456 explicitly requires a separate file outside both protected slots, with no link to either. |

The additional 2c notes are ADDRESSED: explicit AWS region at plan:8449, no launch lifecycle hook at plan:8466, and obsolete evidence-prefix removal at plan:8469.

The activation-gate triage is ADDRESSED at plan:132: stop/start versus reboot remains; the fresh-box guard-arm → recovery → guard-exec rehearsal and deployed allowlist audit are explicit gates. Their execution was not verified.

New breakage in the fix range: none found. Static review only; no builds or tests run, no files changed. The external #288 hold is excluded.

Verdict: ready to merge