carlos / platform Public

Clone
git clone https://amadan.net/carlos/platform

Plain git — no account needed to clone.

Download

Download this file

1# Astra brief: whole-branch review of moves into the home region, part 2 (build R1)
2
3Branch `moves-home-part2-plan`. Review the diff `git diff origin/main...HEAD`; main ee35dee is merged in. This is a review only; edit nothing.
4
5The plan is docs/superpowers/plans/2026-10-15-moves-home-region-part2.md, rev 4.1, which you judged READY. Paul's rulings: R2(a), R1 and R3 to R7 accepted. The SDD ledger is .superpowers/sdd/2026-10-15-moves-home-region-part2/progress.md. Every task has had a scoped task review. This is the one broad pass, against Review Focus 1 to 6.
6
7The branch also fixes two defects that were already on main, both found by its witnesses:
8- The probe env pin (Task 2b). There is one box-owned list in internal/moves. `moves.Pinned` pins a box variable only when the instance supplies it. EnvReport is now v2 (`env2:` pins), and v1 is refused at T3 (MV-N513) and at the probe. The probe owners' Launch returns the env report from the same LaunchLayers read; Select keeps the digest in memory, tied to the wake's context, and Materialize requires it. Recovery owners keep the full local digest. ClaimLaunchDigest, the claim structs, root and hostbox are byte-identical to main.
9- The revert probed-CAS stale read (Task 4). revertRun.probing re-reads the claim after the probe answers.
10
11The claim-runtime stale read was fixed on main by platform-1e (FS-R11, ee35dee). The witnesses go through the real runtime order.
12
13Report:
141. Findings against Review Focus 1 to 6. Look especially for anything the per-task reviews could not see: interactions between tasks, the env-pin change against the door and T3 rules, the census overlay's consistency, and the copy record (MV-N510 to 513 pending, MV-N21 withdrawn).
152. Any place the branch changes behaviour for moves that do not touch home, or for non-moves claim launches. The intent is none, apart from the two pre-existing fixes.
163. For each P1/P2/P3 finding: file:line and a concrete scenario.
174. A verdict: READY TO MERGE (pending copy and census) or NOT READY.
18