amadan
Add the round nine review brief
Documents only. The code tip is 3d4104cb.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
1 file changed,
+30
−0
docs/superpowers/specs/CODEX-REVIEW-BRIEF-carloku-paid-launch-overnight-round9.md+30 −0
CI cancelled — superseded by a newer push — run details
diff --git a/docs/superpowers/specs/CODEX-REVIEW-BRIEF-carloku-paid-launch-overnight-round9.md b/docs/superpowers/specs/CODEX-REVIEW-BRIEF-carloku-paid-launch-overnight-round9.md| new file mode 100644 |
| index 000000000..6541df4f4 |
| --- /dev/null |
| +++ b/docs/superpowers/specs/CODEX-REVIEW-BRIEF-carloku-paid-launch-overnight-round9.md |
| @@ -0,0 +1,30 @@ |
| +# Review brief, round 9: Carloku paid launch, overnight changes of 2026-10-01 |
| + |
| +Read the round 1 brief (`CODEX-REVIEW-BRIEF-carloku-paid-launch-overnight.md`) for the fixed rulings and the output rules, the round 3 to 8 briefs for rulings 6 to 12, then `CODEX-DISPOSITIONS-carloku-paid-launch-overnight.md` (its last section covers round 8), `docs/superpowers/specs/2026-10-01-stripe-idempotency-evidence.md` and `implementation/carloku-paid-launch/OUTSTANDING.md`. |
| + |
| +Review the commit named in the prompt. Read source only with `git show <commit>:<path>`. The changes since round 8 are `git diff c3e87a94 <commit>`. |
| + |
| +Still the fixed snapshot: round 8's findings, nothing else. Nothing may attest. The quantity worker has two switches, both unset. Billing is off. |
| + |
| +Do not report again, as findings, what `OUTSTANDING.md` already lists as open: items 7 and 9 (the two late-request defects), 19b (the app's user versus the name's lease; a far-ahead clock), 19c (conditional delete unverified on a real backend), 19d (the fence observed on AWS only). Do report anything that makes one of them worse than the document says, and any claim about them the code contradicts. |
| + |
| +## First: a disposition table |
| + |
| +For every round 8 finding (Astra F1 to F5 and its simulation and claim items; Opus N1 to N8 and N13's remainder): closed, partly closed, not closed, or accepted and left open as the dispositions say. File and line of the fix and of the test, and whether the test would pass without the fix. |
| + |
| +## Then: new findings only |
| + |
| +- **Estate identity** (`internal/objstore/walk.go` `estateOf`, `Teardown`, `leaseForRotation`, `Grant` `bucketFor`). Find a walk that acts on a store other than the one its request was made against: an estate that compares equal and is not the same, a field the comparison should include and does not, a verb that compares names only. |
| +- **The lease key** (`walklock.go` `walkLeaseKey`). Find two walks that should exclude each other and take different keys, or two unrelated stores that share one. Find a record shape that still reaches the provisioner unleased. |
| +- **The purge** (`internal/release/trash.go` `PurgeApp`, `purgeStoreDeclaration`; the console's purge door in `internal/console/ownership.go`; the box-side auto-purge). Find a purge that deletes a record carrying estate, at any landing point, on any caller. Find a purge that can now never finish. |
| +- **Reviews by serial** (`internal/console/billingquantity.go`). Find an operation settled by a review that was not about it, and a serial that is not what the code believes (a row rewritten, a migration from a database that has operations with serial 0). |
| +- **Holds without an exit.** Every state in which the worker or a walk stops and waits for a person: is a review or an error filed, once, and does resolving it move things on? |
| +- **The simulations' models.** The storage model has had five bookkeeping faults. Look for a sixth, and for a rule that would hide a real violation. |
| +- **Claims** in `AGENT_HANDOFF.md`, `OUTSTANDING.md`, the evidence document and the comments named in the round 8 brief. |
| + |
| +## What to return |
| + |
| +1. The disposition table. |
| +2. New findings, most severe first, in the round 1 format. |
| +3. Claims the code contradicts. |
| +4. A one-line verdict: accept, accept with fixes, or reject. |