carlos / platform Public

plan 1: Astra plan review R7 (test placement, template constant)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude 5 hours ago f112bfeaa3e4b1fbc8d1cddd97c6886e491065e1 parent 25e9b58

2 files changed, +21 −5

docs/superpowers/plans/2026-10-21-instance-policy-1-foundation.md +12 −5
docs/superpowers/plans/CODEX-FINDINGS-instance-policy-plans-R7.md +9 −0

CI passed — run details

CI log

=== gate ===
.amadan/test-gate.sh
=== launchctx (1 s)
ok  	amadan.net/carlos/platform.git/launchctx	0.014s
?   	amadan.net/carlos/platform.git/launchctx/controlname	[no test files]
?   	amadan.net/carlos/platform.git/launchctx/wireid	[no test files]
=== vet (2 s)
=== gofmt (1 s)
gofmt -l .: clean
=== rest (158 s)
?   	github.com/carlosframework/platform/cmd/changelog	[no test files]
ok  	github.com/carlosframework/platform/cmd/console	9.056s
ok  	github.com/carlosframework/platform/cmd/moveprobe	13.638s
ok  	github.com/carlosframework/platform/cmd/zddprobe	1.144s
ok  	github.com/carlosframework/platform/internal/activator	60.860s
ok  	github.com/carlosframework/platform/internal/agentsock	0.036s
ok  	github.com/carlosframework/platform/internal/alerting	0.007s
ok  	github.com/carlosframework/platform/internal/analytics	0.051s
ok  	github.com/carlosframework/platform/internal/appconfig	6.183s
ok  	github.com/carlosframework/platform/internal/apperr	0.790s
ok  	github.com/carlosframework/platform/internal/applog	0.528s
ok  	github.com/carlosframework/platform/internal/assetcache	0.267s
ok  	github.com/carlosframework/platform/internal/awsinv	0.004s
ok  	github.com/carlosframework/platform/internal/boxchoice	0.422s
ok  	github.com/carlosframework/platform/internal/boxid	1.485s
?   	github.com/carlosframework/platform/internal/boxid/boxidtest	[no test files]
?   	github.com/carlosframework/platform/internal/boxid/internal/signtest	[no test files]
ok  	github.com/carlosframework/platform/internal/boxvolumes	0.014s
ok  	github.com/carlosframework/platform/internal/caps	0.017s
ok  	github.com/carlosframework/platform/internal/certwarm	0.003s
ok  	github.com/carlosframework/platform/internal/cgroup	1.172s
ok  	github.com/carlosframework/platform/internal/changelog	0.948s
ok  	github.com/carlosframework/platform/internal/claimactivation	2.347s
ok  	github.com/carlosframework/platform/internal/clamd	0.063s
?   	github.com/carlosframework/platform/internal/cliflag	[no test files]
?   	github.com/carlosframework/platform/internal/controlname	[no test files]
?   	github.com/carlosframework/platform/internal/controlsock	[no test files]
ok  	github.com/carlosframework/platform/internal/dbdoor	8.147s
ok  	github.com/carlosframework/platform/internal/dbdoor/dbdoortest	0.013s
ok  	github.com/carlosframework/platform/internal/dbquery	0.009s
ok  	github.com/carlosframework/platform/internal/dbreads	2.533s
?   	github.com/carlosframework/platform/internal/dbreads/dbreadstest	[no test files]
ok  	github.com/carlosframework/platform/internal/dbverify	0.007s
ok  	github.com/carlosframework/platform/internal/dnsrec	0.012s
ok  	github.com/carlosframework/platform/internal/docsite	0.006s
ok  	github.com/carlosframework/platform/internal/domains	5.258s
ok  	github.com/carlosframework/platform/internal/doorkey	0.010s
ok  	github.com/carlosframework/platform/internal/economics	0.020s
ok  	github.com/carlosframework/platform/internal/edge	48.976s
?   	github.com/carlosframework/platform/internal/edgeproof	[no test files]
ok  	github.com/carlosframework/platform/internal/edgesfile	0.011s
ok  	github.com/carlosframework/platform/internal/fleetapi	0.460s
ok  	github.com/carlosframework/platform/internal/gate	2.263s
ok  	github.com/carlosframework/platform/internal/genselect	0.034s
ok  	github.com/carlosframework/platform/internal/geo	0.206s
ok  	github.com/carlosframework/platform/internal/geoip	0.090s
ok  	github.com/carlosframework/platform/internal/historyreadback	0.596s
ok  	github.com/carlosframework/platform/internal/host	151.526s
ok  	github.com/carlosframework/platform/internal/hostactors	8.970s
ok  	github.com/carlosframework/platform/internal/hostactors/awsmembership	0.009s
ok  	github.com/carlosframework/platform/internal/hostbox	5.256s
ok  	github.com/carlosframework/platform/internal/hostclaim	2.880s
ok  	github.com/carlosframework/platform/internal/hostenv	0.010s
ok  	github.com/carlosframework/platform/internal/hostevidence	0.008s
ok  	github.com/carlosframework/platform/internal/hostexec	10.937s
ok  	github.com/carlosframework/platform/internal/hostfence	0.135s
ok  	github.com/carlosframework/platform/internal/hostfiles	11.318s
ok  	github.com/carlosframework/platform/internal/hostfloor	0.026s
ok  	github.com/carlosframework/platform/internal/hostguard	1.193s
ok  	github.com/carlosframework/platform/internal/hostops	6.089s
?   	github.com/carlosframework/platform/internal/hostops/fencerelease	[no test files]
ok  	github.com/carlosframework/platform/internal/hostops/internal/fencerelease	0.070s
ok  	github.com/carlosframework/platform/internal/hostquarantine	0.075s
ok  	github.com/carlosframework/platform/internal/hostrelocate	2.070s
ok  	github.com/carlosframework/platform/internal/hostresolve	0.320s
ok  	github.com/carlosframework/platform/internal/hostwrite	0.006s
ok  	github.com/carlosframework/platform/internal/infraview	0.004s
ok  	github.com/carlosframework/platform/internal/instancectl	5.282s
ok  	github.com/carlosframework/platform/internal/instanceexec	3.239s
ok  	github.com/carlosframework/platform/internal/instancefs	0.064s
ok  	github.com/carlosframework/platform/internal/instancekey	0.008s
ok  	github.com/carlosframework/platform/internal/instanceupdates	0.013s
ok  	github.com/carlosframework/platform/internal/layout	3.978s
ok  	github.com/carlosframework/platform/internal/lbhealth	0.005s
ok  	github.com/carlosframework/platform/internal/lease	10.456s
ok  	github.com/carlosframework/platform/internal/lease/leasetest	0.599s
ok  	github.com/carlosframework/platform/internal/ledger	0.017s
ok  	github.com/carlosframework/platform/internal/mail	0.567s
ok  	github.com/carlosframework/platform/internal/maintenance	0.113s
ok  	github.com/carlosframework/platform/internal/maintenanceexec	6.448s
ok  	github.com/carlosframework/platform/internal/maintenanceguard	0.285s
ok  	github.com/carlosframework/platform/internal/metrics	0.031s
ok  	github.com/carlosframework/platform/internal/moves	26.327s
ok  	github.com/carlosframework/platform/internal/moves/archive	2.210s
ok  	github.com/carlosframework/platform/internal/objstore	0.702s
ok  	github.com/carlosframework/platform/internal/ops	0.788s
ok  	github.com/carlosframework/platform/internal/park	0.830s
ok  	github.com/carlosframework/platform/internal/plans	0.012s
ok  	github.com/carlosframework/platform/internal/privatefile	0.005s
ok  	github.com/carlosframework/platform/internal/provision	23.965s
ok  	github.com/carlosframework/platform/internal/publicrelease	0.013s
?   	github.com/carlosframework/platform/internal/regionname	[no test files]
ok  	github.com/carlosframework/platform/internal/registry	7.935s
ok  	github.com/carlosframework/platform/internal/relay	7.265s
ok  	github.com/carlosframework/platform/internal/release	34.874s
ok  	github.com/carlosframework/platform/internal/rollout	5.225s
ok  	github.com/carlosframework/platform/internal/rolloutwords	0.005s
ok  	github.com/carlosframework/platform/internal/rootaws	0.073s
ok  	github.com/carlosframework/platform/internal/rootparticipation	0.069s
ok  	github.com/carlosframework/platform/internal/rootstate	0.042s
ok  	github.com/carlosframework/platform/internal/runs	0.619s
ok  	github.com/carlosframework/platform/internal/s3compat	0.006s
ok  	github.com/carlosframework/platform/internal/safefile	0.005s
ok  	github.com/carlosframework/platform/internal/schedule	4.343s
ok  	github.com/carlosframework/platform/internal/seeds	0.056s
ok  	github.com/carlosframework/platform/internal/sim/engines	7.190s
ok  	github.com/carlosframework/platform/internal/sim/hostlife	24.906s
ok  	github.com/carlosframework/platform/internal/sim/litestreamfacts	3.835s
ok  	github.com/carlosframework/platform/internal/status	0.153s
ok  	github.com/carlosframework/platform/internal/steering	0.010s
ok  	github.com/carlosframework/platform/internal/stopevidence	0.414s
ok  	github.com/carlosframework/platform/internal/svcrole	0.002s
ok  	github.com/carlosframework/platform/internal/telemetry	0.005s
ok  	github.com/carlosframework/platform/internal/termfence	0.008s
ok  	github.com/carlosframework/platform/internal/tunnelclient	0.007s
ok  	github.com/carlosframework/platform/internal/unixdial	0.003s
ok  	github.com/carlosframework/platform/internal/updatewords	0.004s
ok  	github.com/carlosframework/platform/internal/usage	0.006s
ok  	github.com/carlosframework/platform/internal/version	0.003s
ok  	github.com/carlosframework/platform/internal/vet	2.281s
=== internal_console@0 (86 s)
ok  	github.com/carlosframework/platform/internal/console	81.880s
=== internal_console@1 (49 s)
ok  	github.com/carlosframework/platform/internal/console	43.237s
=== internal_console@2 (52 s)
ok  	github.com/carlosframework/platform/internal/console	46.863s
=== internal_console@3 (53 s)
ok  	github.com/carlosframework/platform/internal/console	47.422s
=== internal_console@4 (50 s)
ok  	github.com/carlosframework/platform/internal/console	45.733s
=== internal_console@5 (47 s)
ok  	github.com/carlosframework/platform/internal/console	41.315s
=== internal_console@6 (52 s)
ok  	github.com/carlosframework/platform/internal/console	46.953s
=== internal_console@7 (55 s)
ok  	github.com/carlosframework/platform/internal/console	50.286s
=== root@0 (116 s)
ok  	github.com/carlosframework/platform	112.184s
=== root@1 (107 s)
ok  	github.com/carlosframework/platform	103.871s
=== root@2 (85 s)
ok  	github.com/carlosframework/platform	81.299s
=== cross ===
--- shard 0 of 5 ---
cross-compiling darwin/arm64
--- shard 1 of 5 ---
cross-compiling darwin/amd64
--- shard 2 of 5 ---
cross-compiling linux/arm64
linux/arm64 carlos binary: 50725026 bytes (ceiling 52000000)
--- shard 3 of 5 ---
cross-compiling windows/amd64
--- shard 4 of 5 ---
cross-compiling windows/arm64
=== minio-contract ===
minio contract: arm64, minio RELEASE.2025-09-07T16-13-09Z, mc RELEASE.2025-08-13T08-35-41Z
  minio: cached, digest verified
  mc: cached, digest verified
  minio healthy on 127.0.0.1:20999
Added `local` successfully.
Bucket created successfully `local/contract-bucket`.
Bucket created successfully `local/denied-bucket`.
Created policy `contract-only` successfully.
Added user `scopeduser` successfully.
Attached Policies: [contract-only]
To User: scopeduser
  buckets and scoped user ready
=== RUN   TestDeliveredContractMinio
=== RUN   TestDeliveredContractMinio/put
=== RUN   TestDeliveredContractMinio/get_round-trips_the_body
=== RUN   TestDeliveredContractMinio/list_shows_the_key
=== RUN   TestDeliveredContractMinio/head_and_list_agree_on_the_version
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_its_own_object
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/not_by_PutObjectTagging
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/and_not_by_x-amz-tagging_on_upload
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CreateMultipartUpload
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CopyObject_with_a_REPLACE_tagging_directive
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/but_multipart_itself_is_allowed
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_copy_itself_is_allowed
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/a_POST-policy_forged_tag_with_a_matching_version_is_still_not_a_verdict
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_an_ordinary_tagged-with-something-else_upload_is_allowed
=== RUN   TestDeliveredContractMinio/delete_removes_it
=== RUN   TestDeliveredContractMinio/cross-bucket_denial
--- PASS: TestDeliveredContractMinio (0.02s)
    --- PASS: TestDeliveredContractMinio/put (0.00s)
    --- PASS: TestDeliveredContractMinio/get_round-trips_the_body (0.00s)
    --- PASS: TestDeliveredContractMinio/list_shows_the_key (0.00s)
    --- PASS: TestDeliveredContractMinio/head_and_list_agree_on_the_version (0.00s)
    --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object (0.00s)
        --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/not_by_PutObjectTagging (0.00s)
        --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/and_not_by_x-amz-tagging_on_upload (0.00s)
    --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route (0.01s)
        --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CreateMultipartUpload (0.00s)
        --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CopyObject_with_a_REPLACE_tagging_directive (0.00s)
        --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/but_multipart_itself_is_allowed (0.00s)
        --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_copy_itself_is_allowed (0.00s)
        --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/a_POST-policy_forged_tag_with_a_matching_version_is_still_not_a_verdict (0.00s)
        --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_an_ordinary_tagged-with-something-else_upload_is_allowed (0.00s)
    --- PASS: TestDeliveredContractMinio/delete_removes_it (0.00s)
    --- PASS: TestDeliveredContractMinio/cross-bucket_denial (0.00s)
PASS
ok  	github.com/carlosframework/platform/internal/objstore	0.029s
=== RUN   TestT4StorageProbeMinio
2026/10/25 00:47:01 moves: T4: STORE: list: operation error S3: ListObjectsV2, https response error StatusCode: 403, RequestID: 18E19F3F59A8A5CD, HostID: 7c420053e0fbcd7f41653fdd92ffa2802c903d05303b1aa15adc2e8bb65d183f, api error SignatureDoesNotMatch: The request signature we calculated does not match the signature you provided. Check your key and signing method.
--- PASS: TestT4StorageProbeMinio (0.01s)
PASS
ok  	github.com/carlosframework/platform/internal/host	0.024s
=== RUN   TestS3StoreMinioContract
=== RUN   TestS3StoreMinioContract/conditional_get_and_etag_listing
=== RUN   TestS3StoreMinioContract/bump_through_every_mutation_path
--- PASS: TestS3StoreMinioContract (0.03s)
    --- PASS: TestS3StoreMinioContract/conditional_get_and_etag_listing (0.01s)
    --- PASS: TestS3StoreMinioContract/bump_through_every_mutation_path (0.02s)
PASS
ok  	github.com/carlosframework/platform/internal/release	0.034s
Bucket created successfully `local/dbf-deploy`.
Bucket created successfully `local/dbf-data-ie`.
Bucket created successfully `local/dbf-data-uk`.
local/dbf-deploy versioning is enabled
Created policy `dbf-console` successfully.
Created policy `dbf-ukbox` successfully.
Added user `dbfconsole` successfully.
Added user `dbfukbox` successfully.
Attached Policies: [dbf-console]
To User: dbfconsole
Attached Policies: [dbf-ukbox]
To User: dbfukbox
=== RUN   TestDBForwardMinio
2026/10/25 00:47:03 INFO replica sync system=store db=source.db replica=file txid.replica=0000000000000000 txid.db=0000000000000001
2026/10/25 00:47:03 INFO ltx file uploaded system=store db=source.db replica=file level=0 minTXID=0000000000000001 maxTXID=0000000000000001 size=720
2026/10/25 00:47:03 INFO replica sync system=store db=source.db replica=file txid.replica=0000000000000001 txid.db=0000000000000001
2026/10/25 00:47:03 INFO replica sync system=store db=source.db replica=file txid.replica=0000000000000001 txid.db=0000000000000002
2026/10/25 00:47:03 INFO ltx file uploaded system=store db=source.db replica=file level=0 minTXID=0000000000000002 maxTXID=0000000000000002 size=370
2026/10/25 00:47:03 INFO replica sync system=store db=source.db replica=file txid.replica=0000000000000002 txid.db=0000000000000002
2026/10/25 00:47:03 INFO replica sync system=store db=source.db replica=file txid.replica=0000000000000002 txid.db=0000000000000003
2026/10/25 00:47:03 INFO ltx file uploaded system=store db=source.db replica=file level=0 minTXID=0000000000000003 maxTXID=0000000000000003 size=454
2026/10/25 00:47:03 INFO replica sync system=store db=source.db replica=file txid.replica=0000000000000003 txid.db=0000000000000003
2026/10/25 00:47:03 INFO replica sync system=store db=source.db replica=file txid.replica=0000000000000000 txid.db=0000000000000001
2026/10/25 00:47:03 INFO ltx file uploaded system=store db=source.db replica=file level=0 minTXID=0000000000000001 maxTXID=0000000000000001 size=720
2026/10/25 00:47:03 INFO replica sync system=store db=source.db replica=file txid.replica=0000000000000001 txid.db=0000000000000001
2026/10/25 00:47:03 console: CARLOS_SECRETS_PUBKEY is unset, so no region outside the home can be chosen automatically
2026/10/25 00:47:03 console: could not notify member@example.com of a CLI token issue: keymail: lookup member@example.com: keymail: GET /api/federation/lookup?addr=member%40example.com&from=console%40127.0.0.1%3A41767: could not determine target mailbox
    agent.go:135: dbreads: dbr_mk2bxrvlnxlfmegbic4ed7tdoq: planned 3 files (1544 bytes) and restored to 3 in 11ms
    agent.go:135: dbreads: dbr_mk2bxrvlnxlfmegbic4ed7tdoq: output 5 bytes in 1 confirmed chunks in 1ms
2026/10/25 00:47:04 console: db read dbr_mk2bxrvlnxlfmegbic4ed7tdoq: relayed 1 chunks (102 bytes) in 1.005s, ended done
    agent.go:135: dbreads: dbr_n2vmfl6ynm5dl2toxzuynjyfly: planned 1 files (720 bytes) and restored to 1 in 10ms
    agent.go:135: dbreads: dbr_n2vmfl6ynm5dl2toxzuynjyfly: output 5 bytes in 1 confirmed chunks in 1ms
2026/10/25 00:47:05 console: db read dbr_n2vmfl6ynm5dl2toxzuynjyfly: relayed 1 chunks (102 bytes) in 1.004s, ended done
    agent.go:135: dbreads: dbr_a4ase74sl5mhi6hv2di27ahz4y: planned 3 files (1544 bytes) and held through 3 in 10ms
    agent.go:135: dbreads: dbr_a4ase74sl5mhi6hv2di27ahz4y: output 1544 bytes in 1 confirmed chunks in 1ms
2026/10/25 00:47:06 console: db read dbr_a4ase74sl5mhi6hv2di27ahz4y: relayed 1 chunks (1641 bytes) in 1.005s, ended done
=== RUN   TestDBForwardMinio/by_disconnect
=== NAME  TestDBForwardMinio
    agent.go:135: dbreads: dbr_dma2fe3m4wazynaur7b2bjzbra: planned 3 files (1544 bytes) and restored to 3 in 11ms
2026/10/25 00:47:06 console: db read dbr_dma2fe3m4wazynaur7b2bjzbra: relayed 0 chunks (0 bytes) in 43ms, ended client gone
    agent.go:135: dbreads: dbr_dma2fe3m4wazynaur7b2bjzbra: output 5 bytes in 1 confirmed chunks in 105ms
=== RUN   TestDBForwardMinio/by_timeout
=== NAME  TestDBForwardMinio
    agent.go:135: dbreads: dbr_ln47t7jmh5iqvyw7y6fwgrb7nm: planned 3 files (1544 bytes) and restored to 3 in 11ms
2026/10/25 00:47:26 console: db read dbr_ln47t7jmh5iqvyw7y6fwgrb7nm: relayed 0 chunks (0 bytes) in 19.106s, ended no-result
    agent.go:135: dbreads: dbr_ln47t7jmh5iqvyw7y6fwgrb7nm: output 5 bytes in 1 confirmed chunks in 19.075s
--- PASS: TestDBForwardMinio (22.56s)
    --- PASS: TestDBForwardMinio/by_disconnect (0.23s)
    --- PASS: TestDBForwardMinio/by_timeout (19.22s)
PASS
ok  	github.com/carlosframework/platform/internal/console	22.577s
minio contract: PASS

diff --git a/docs/superpowers/plans/2026-10-21-instance-policy-1-foundation.md b/docs/superpowers/plans/2026-10-21-instance-policy-1-foundation.md

index a17bef0d3..33a45f0d3 100644

--- a/docs/superpowers/plans/2026-10-21-instance-policy-1-foundation.md

+++ b/docs/superpowers/plans/2026-10-21-instance-policy-1-foundation.md

@@ -145,7 +145,7 @@ In `internal/host/units_hardening_test.go`:

func TestInstanceFenceIsEgressaddrFenceDeny(t *testing.T) {

t.Parallel()

// For each of the six template names in TestNamespaceBlockCarriesTheHardening,

- // and for claimUnitTemplate's text (claimunit_template.go:48): take the

+ // and for claimBoundTemplate's text (claimunit_template.go:48): take the

// IPAddressDeny= line's fields, expand "localhost" -> 127.0.0.0/8 ::1/128 and

// "multicast" -> 224.0.0.0/4 ff00::/8, parse each with netip.ParsePrefix, and

// assert the set equals the set of egressaddr.FenceDeny exactly.

@@ -224,7 +224,7 @@ func TestSizesTableIsLiteral(t *testing.T) {

- Modify: `internal/release/release.go:255-266` (add `AppPolicyPrefix`, `AppPolicyKey` beside `LedgerAppPrefix`; extend `AppPrefix`'s comment to name it)

- Modify: `internal/release/changeindex.go:50-75` (`ChangeScope`: the policy row; its doc comment's scope list)

- Create: `internal/apppolicy/apppolicy.go` (the object, store calls), `internal/apppolicy/signed.go` (sign and verify)

-- Test: `internal/apppolicy/apppolicy_test.go`, `internal/apppolicy/signed_test.go`, `internal/release/changeindex_test.go` (`TestChangeScope`'s table), `internal/release/changeindex_store_test.go`

+- Test: `internal/apppolicy/apppolicy_test.go`, `internal/apppolicy/signed_test.go`, `internal/release/changeindex_test.go` (`TestChangeScope`'s table), `internal/apppolicy/changeindex_test.go` (package `apppolicy`: it calls `apppolicy.PutIfMatch`, and `apppolicy` imports `release`, so it cannot live in `package release`, Astra plan R7-1)

**Interfaces:**

- Consumes: Task 1 `egressaddr.Parse`, `MaxAllow`; Task 2 `cgroup.SizeByName`; `release.ValidAccount`, `release.ValidApp`.

@@ -352,7 +352,7 @@ func TestListETagsIsOneListing(t *testing.T) {

"control/app-policy/bab/shop.txt", "control/app-policy//shop.json", "control/app-policy-lease/lock.json",

```

-`changeindex_store_test.go`:

+`internal/apppolicy/changeindex_test.go`:

```go

func TestAPolicyWriteBumpsTheAppScope(t *testing.T) {

@@ -361,9 +361,9 @@ func TestAPolicyWriteBumpsTheAppScope(t *testing.T) {

}

```

-- [ ] **Step 2: Run, fail:** `go test ./internal/apppolicy -run . && go test ./internal/release -run 'TestChangeScope|TestAPolicyWriteBumpsTheAppScope'` → FAIL (package missing; the policy key in no scope).

+- [ ] **Step 2: Run, fail:** `go test ./internal/apppolicy -run . && go test ./internal/release -run 'TestChangeScope'` → FAIL (package missing; the policy key in no scope).

- [ ] **Step 3: Implement** the release additions, the `ChangeScope` row (its comment: spec §3a, so a policy write moves the app's generation and the agent re-reads only that app), `signed.go` (file comment: the door-key precedent, spec §3; why the domain line; why `Account`/`App` are inside the signature) and `apppolicy.go` (package comment: one operator-only object per app, spec §3; written only by the console's policy door and re-sign loop, under the writer lease; verified by the agent before it converges; root reads none of it in this build, ruling 9).

-- [ ] **Step 4: Run, pass:** `go test ./internal/apppolicy -run . && go test ./internal/release -run 'TestPurge|TestTrash|TestChangeScope|TestAPolicyWriteBumpsTheAppScope|TestBumpChangeIndex'` (the release edits must not break purge or the index).

+- [ ] **Step 4: Run, pass:** `go test ./internal/apppolicy -run . && go test ./internal/release -run 'TestPurge|TestTrash|TestChangeScope|TestBumpChangeIndex'` (the release edits must not break purge or the index).

- [ ] **Step 5: Commit** `apppolicy: the signed operator policy record (#328, #329)`.

---

@@ -1393,3 +1393,10 @@ All three findings' citations were checked against the code and hold: `server.go

|---|---|

| R6-2 best-effort purge delete loses the retry | Task 11: purge GETs first; absent sends no delete; a present policy that cannot be deleted fails the purge and keeps the marker, so it retries. Tests `TestPurgeKeepsTheMarkerWhenThePolicyDeleteIsDenied`, `TestPurgeOfAnAppWithNoPolicySendsNoPolicyDelete` (replaces R5's best-effort test). |

| R6-3 the create helper broke Task 6's source test | Task 11: the helper reads through `apppolicy.Key`. |

+## Review dispositions (Astra plan R7)

+| Finding | Change |

+|---|---|

+| R7-1 the change-index store test would make `release` import `apppolicy` | Task 3: the test moves to `internal/apppolicy/changeindex_test.go`; the release run commands drop it (the `apppolicy -run .` run covers it). |

+| R7-2 `claimUnitTemplate` does not exist | Task 1: the fence test names `claimBoundTemplate` (`internal/host/claimunit_template.go:3`). |

diff --git a/docs/superpowers/plans/CODEX-FINDINGS-instance-policy-plans-R7.md b/docs/superpowers/plans/CODEX-FINDINGS-instance-policy-plans-R7.md

new file mode 100644

index 000000000..9a003ac3a

--- /dev/null

+++ b/docs/superpowers/plans/CODEX-FINDINGS-instance-policy-plans-R7.md

@@ -0,0 +1,9 @@

+R6-1 — RESOLVED: the refusal arm updates `e.route.Size`, preserving the captured tier and unsettled state.

+R6-2 — RESOLVED: a failed policy deletion retains the purge marker for retry.

+R6-3 — RESOLVED: the cleanup helper reads through `apppolicy.Key`.

+1. **P1 — Plan 1, Task 3: the change-index test introduces an import cycle.** [Foundation:355](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/instance-egress-sizes-328-329/docs/superpowers/plans/2026-10-21-instance-policy-1-foundation.md:355) places a test calling `apppolicy.PutIfMatch` and `apppolicy.Delete` in `internal/release/changeindex_store_test.go`. That file declares [package release:1](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/instance-egress-sizes-328-329/internal/release/changeindex_store_test.go:1), while the planned `apppolicy` package imports `release`. Implementing this creates `release → apppolicy → release`, preventing the release tests from compiling. **Smallest fix:** place this integration test in `internal/apppolicy`, or a new external `package release_test` file, and update its run command.

+2. **P2 — Plan 1, Task 1: the fence test names a nonexistent template constant.** [Foundation:148](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/instance-egress-sizes-328-329/docs/superpowers/plans/2026-10-21-instance-policy-1-foundation.md:148) requires checking `claimUnitTemplate`, but the constant is [claimBoundTemplate:3](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/instance-egress-sizes-328-329/internal/host/claimunit_template.go:3); `claimUnitTemplate` does not exist. **Smallest fix:** name `claimBoundTemplate` in the test instructions.

+REJECT

\ No newline at end of file