spec: Astra review brief for the edge asset cache
Summary
Committed brief for the adversarial review round, so an interrupted run restarts from the same instructions.
1 file changed,
+41
−0
docs/superpowers/specs/CODEX-REVIEW-BRIEF-ASSET-CACHE.md+41 −0
CI passed — run details
CI log
=== gate ===
.amadan/test-gate.sh
=== launchctx (1 s)
ok amadan.net/carlos/platform.git/launchctx 0.016s
? amadan.net/carlos/platform.git/launchctx/controlname [no test files]
? amadan.net/carlos/platform.git/launchctx/wireid [no test files]
=== vet (28 s)
=== gofmt (1 s)
gofmt -l .: clean
=== rest (183 s)
? github.com/carlosframework/platform/cmd/changelog [no test files]
ok github.com/carlosframework/platform/cmd/console 3.551s
ok github.com/carlosframework/platform/cmd/moveprobe 11.615s
ok github.com/carlosframework/platform/cmd/zddprobe 0.753s
ok github.com/carlosframework/platform/internal/activator 58.753s
ok github.com/carlosframework/platform/internal/agentsock 0.017s
ok github.com/carlosframework/platform/internal/alerting 0.004s
ok github.com/carlosframework/platform/internal/analytics 0.042s
ok github.com/carlosframework/platform/internal/appconfig 2.833s
ok github.com/carlosframework/platform/internal/apperr 0.098s
ok github.com/carlosframework/platform/internal/applog 0.241s
ok github.com/carlosframework/platform/internal/awsinv 0.005s
ok github.com/carlosframework/platform/internal/boxchoice 0.008s
ok github.com/carlosframework/platform/internal/boxid 0.861s
? github.com/carlosframework/platform/internal/boxid/boxidtest [no test files]
? github.com/carlosframework/platform/internal/boxid/internal/signtest [no test files]
ok github.com/carlosframework/platform/internal/boxvolumes 0.010s
ok github.com/carlosframework/platform/internal/caps 0.018s
ok github.com/carlosframework/platform/internal/certwarm 0.003s
ok github.com/carlosframework/platform/internal/cgroup 0.771s
ok github.com/carlosframework/platform/internal/changelog 0.443s
ok github.com/carlosframework/platform/internal/claimactivation 1.147s
ok github.com/carlosframework/platform/internal/clamd 0.057s
? github.com/carlosframework/platform/internal/cliflag [no test files]
? github.com/carlosframework/platform/internal/controlname [no test files]
? github.com/carlosframework/platform/internal/controlsock [no test files]
ok github.com/carlosframework/platform/internal/dbdoor 7.978s
ok github.com/carlosframework/platform/internal/dbdoor/dbdoortest 0.012s
ok github.com/carlosframework/platform/internal/dbquery 0.005s
ok github.com/carlosframework/platform/internal/dbreads 2.054s
? github.com/carlosframework/platform/internal/dbreads/dbreadstest [no test files]
ok github.com/carlosframework/platform/internal/dbverify 0.020s
ok github.com/carlosframework/platform/internal/dnsrec 0.016s
ok github.com/carlosframework/platform/internal/docsite 0.024s
ok github.com/carlosframework/platform/internal/domains 2.754s
ok github.com/carlosframework/platform/internal/doorkey 0.020s
ok github.com/carlosframework/platform/internal/economics 0.017s
ok github.com/carlosframework/platform/internal/edge 49.390s
? github.com/carlosframework/platform/internal/edgeproof [no test files]
ok github.com/carlosframework/platform/internal/edgesfile 0.009s
ok github.com/carlosframework/platform/internal/fleetapi 0.182s
ok github.com/carlosframework/platform/internal/gate 1.709s
ok github.com/carlosframework/platform/internal/genselect 0.032s
ok github.com/carlosframework/platform/internal/geo 0.017s
ok github.com/carlosframework/platform/internal/geoip 0.034s
ok github.com/carlosframework/platform/internal/historyreadback 0.205s
ok github.com/carlosframework/platform/internal/host 144.579s
ok github.com/carlosframework/platform/internal/hostactors 6.655s
ok github.com/carlosframework/platform/internal/hostactors/awsmembership 0.005s
ok github.com/carlosframework/platform/internal/hostbox 3.169s
ok github.com/carlosframework/platform/internal/hostclaim 0.733s
ok github.com/carlosframework/platform/internal/hostenv 0.006s
ok github.com/carlosframework/platform/internal/hostevidence 0.006s
ok github.com/carlosframework/platform/internal/hostexec 5.716s
ok github.com/carlosframework/platform/internal/hostfence 0.041s
ok github.com/carlosframework/platform/internal/hostfiles 10.618s
ok github.com/carlosframework/platform/internal/hostfloor 0.021s
ok github.com/carlosframework/platform/internal/hostguard 1.040s
ok github.com/carlosframework/platform/internal/hostops 2.066s
? github.com/carlosframework/platform/internal/hostops/fencerelease [no test files]
ok github.com/carlosframework/platform/internal/hostops/internal/fencerelease 0.006s
ok github.com/carlosframework/platform/internal/hostquarantine 0.007s
ok github.com/carlosframework/platform/internal/hostrelocate 0.668s
ok github.com/carlosframework/platform/internal/hostresolve 0.202s
ok github.com/carlosframework/platform/internal/hostwrite 0.005s
ok github.com/carlosframework/platform/internal/infraview 0.005s
ok github.com/carlosframework/platform/internal/instancectl 5.285s
ok github.com/carlosframework/platform/internal/instanceexec 2.868s
ok github.com/carlosframework/platform/internal/instancefs 0.009s
ok github.com/carlosframework/platform/internal/instancekey 0.003s
ok github.com/carlosframework/platform/internal/instanceupdates 0.007s
ok github.com/carlosframework/platform/internal/layout 1.872s
ok github.com/carlosframework/platform/internal/lbhealth 0.005s
ok github.com/carlosframework/platform/internal/lease 10.086s
ok github.com/carlosframework/platform/internal/lease/leasetest 0.572s
ok github.com/carlosframework/platform/internal/ledger 0.027s
ok github.com/carlosframework/platform/internal/mail 0.248s
ok github.com/carlosframework/platform/internal/maintenance 0.103s
ok github.com/carlosframework/platform/internal/maintenanceexec 5.614s
ok github.com/carlosframework/platform/internal/maintenanceguard 0.100s
ok github.com/carlosframework/platform/internal/metrics 0.007s
ok github.com/carlosframework/platform/internal/moves 28.830s
ok github.com/carlosframework/platform/internal/moves/archive 1.050s
ok github.com/carlosframework/platform/internal/objstore 0.290s
ok github.com/carlosframework/platform/internal/ops 0.214s
ok github.com/carlosframework/platform/internal/park 0.325s
ok github.com/carlosframework/platform/internal/plans 0.007s
ok github.com/carlosframework/platform/internal/privatefile 0.004s
ok github.com/carlosframework/platform/internal/provision 50.787s
ok github.com/carlosframework/platform/internal/publicrelease 0.011s
? github.com/carlosframework/platform/internal/regionname [no test files]
ok github.com/carlosframework/platform/internal/registry 5.787s
ok github.com/carlosframework/platform/internal/relay 7.246s
ok github.com/carlosframework/platform/internal/release 30.272s
ok github.com/carlosframework/platform/internal/rollout 4.176s
ok github.com/carlosframework/platform/internal/rolloutwords 0.007s
ok github.com/carlosframework/platform/internal/rootaws 0.007s
ok github.com/carlosframework/platform/internal/rootparticipation 0.062s
ok github.com/carlosframework/platform/internal/rootstate 0.032s
ok github.com/carlosframework/platform/internal/runs 0.605s
ok github.com/carlosframework/platform/internal/s3compat 0.009s
ok github.com/carlosframework/platform/internal/safefile 0.008s
ok github.com/carlosframework/platform/internal/schedule 2.864s
ok github.com/carlosframework/platform/internal/seeds 0.013s
ok github.com/carlosframework/platform/internal/sim/engines 3.042s
ok github.com/carlosframework/platform/internal/sim/hostlife 10.717s
ok github.com/carlosframework/platform/internal/sim/litestreamfacts 4.000s
ok github.com/carlosframework/platform/internal/status 0.070s
ok github.com/carlosframework/platform/internal/steering 0.006s
ok github.com/carlosframework/platform/internal/stopevidence 0.052s
ok github.com/carlosframework/platform/internal/svcrole 0.003s
ok github.com/carlosframework/platform/internal/telemetry 0.005s
ok github.com/carlosframework/platform/internal/termfence 0.005s
ok github.com/carlosframework/platform/internal/tunnelclient 0.007s
ok github.com/carlosframework/platform/internal/unixdial 0.005s
ok github.com/carlosframework/platform/internal/updatewords 0.007s
ok github.com/carlosframework/platform/internal/usage 0.006s
ok github.com/carlosframework/platform/internal/version 0.002s
ok github.com/carlosframework/platform/internal/vet 1.669s
=== internal_console@0 (88 s)
ok github.com/carlosframework/platform/internal/console 86.634s
=== internal_console@1 (49 s)
ok github.com/carlosframework/platform/internal/console 47.408s
=== internal_console@2 (45 s)
ok github.com/carlosframework/platform/internal/console 43.390s
=== internal_console@3 (48 s)
ok github.com/carlosframework/platform/internal/console 46.554s
=== internal_console@4 (48 s)
ok github.com/carlosframework/platform/internal/console 46.039s
=== internal_console@5 (48 s)
ok github.com/carlosframework/platform/internal/console 46.814s
=== internal_console@6 (44 s)
ok github.com/carlosframework/platform/internal/console 42.416s
=== internal_console@7 (51 s)
ok github.com/carlosframework/platform/internal/console 49.708s
=== root@0 (118 s)
ok github.com/carlosframework/platform 116.363s
=== root@1 (84 s)
ok github.com/carlosframework/platform 82.675s
=== root@2 (98 s)
ok github.com/carlosframework/platform 96.342s
=== cross ===
--- shard 0 of 5 ---
cross-compiling darwin/arm64
--- shard 1 of 5 ---
cross-compiling darwin/amd64
--- shard 2 of 5 ---
cross-compiling linux/arm64
linux/arm64 carlos binary: 50528418 bytes (ceiling 52000000)
--- shard 3 of 5 ---
cross-compiling windows/amd64
--- shard 4 of 5 ---
cross-compiling windows/arm64
=== minio-contract ===
minio contract: arm64, minio RELEASE.2025-09-07T16-13-09Z, mc RELEASE.2025-08-13T08-35-41Z
minio: downloading https://github.com/minio/minio/releases/download/RELEASE.2025-09-07T16-13-09Z/minio.linux-arm64.RELEASE.2025-09-07T16-13-09Z
minio: downloaded, digest verified
mc: downloading https://github.com/minio/mc/releases/download/RELEASE.2025-08-13T08-35-41Z/mc.linux-arm64.RELEASE.2025-08-13T08-35-41Z
mc: downloaded, digest verified
minio healthy on 127.0.0.1:20999
Added `local` successfully.
Bucket created successfully `local/contract-bucket`.
Bucket created successfully `local/denied-bucket`.
Created policy `contract-only` successfully.
Added user `scopeduser` successfully.
Attached Policies: [contract-only]
To User: scopeduser
buckets and scoped user ready
=== RUN TestDeliveredContractMinio
=== RUN TestDeliveredContractMinio/put
=== RUN TestDeliveredContractMinio/get_round-trips_the_body
=== RUN TestDeliveredContractMinio/list_shows_the_key
=== RUN TestDeliveredContractMinio/head_and_list_agree_on_the_version
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_its_own_object
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/not_by_PutObjectTagging
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/and_not_by_x-amz-tagging_on_upload
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CreateMultipartUpload
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CopyObject_with_a_REPLACE_tagging_directive
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/but_multipart_itself_is_allowed
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_copy_itself_is_allowed
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/a_POST-policy_forged_tag_with_a_matching_version_is_still_not_a_verdict
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_an_ordinary_tagged-with-something-else_upload_is_allowed
=== RUN TestDeliveredContractMinio/delete_removes_it
=== RUN TestDeliveredContractMinio/cross-bucket_denial
--- PASS: TestDeliveredContractMinio (0.02s)
--- PASS: TestDeliveredContractMinio/put (0.00s)
--- PASS: TestDeliveredContractMinio/get_round-trips_the_body (0.00s)
--- PASS: TestDeliveredContractMinio/list_shows_the_key (0.00s)
--- PASS: TestDeliveredContractMinio/head_and_list_agree_on_the_version (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/not_by_PutObjectTagging (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/and_not_by_x-amz-tagging_on_upload (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route (0.01s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CreateMultipartUpload (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CopyObject_with_a_REPLACE_tagging_directive (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/but_multipart_itself_is_allowed (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_copy_itself_is_allowed (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/a_POST-policy_forged_tag_with_a_matching_version_is_still_not_a_verdict (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_an_ordinary_tagged-with-something-else_upload_is_allowed (0.00s)
--- PASS: TestDeliveredContractMinio/delete_removes_it (0.00s)
--- PASS: TestDeliveredContractMinio/cross-bucket_denial (0.00s)
PASS
ok github.com/carlosframework/platform/internal/objstore 0.024s
=== RUN TestT4StorageProbeMinio
2026/10/24 17:57:24 moves: T4: STORE: list: operation error S3: ListObjectsV2, https response error StatusCode: 403, RequestID: 18E188E53BA1E638, HostID: 7c420053e0fbcd7f41653fdd92ffa2802c903d05303b1aa15adc2e8bb65d183f, api error SignatureDoesNotMatch: The request signature we calculated does not match the signature you provided. Check your key and signing method.
--- PASS: TestT4StorageProbeMinio (0.01s)
PASS
ok github.com/carlosframework/platform/internal/host 0.022s
=== RUN TestS3StoreMinioContract
=== RUN TestS3StoreMinioContract/conditional_get_and_etag_listing
=== RUN TestS3StoreMinioContract/bump_through_every_mutation_path
--- PASS: TestS3StoreMinioContract (0.03s)
--- PASS: TestS3StoreMinioContract/conditional_get_and_etag_listing (0.01s)
--- PASS: TestS3StoreMinioContract/bump_through_every_mutation_path (0.02s)
PASS
ok github.com/carlosframework/platform/internal/release 0.032s
Bucket created successfully `local/dbf-deploy`.
Bucket created successfully `local/dbf-data-ie`.
Bucket created successfully `local/dbf-data-uk`.
local/dbf-deploy versioning is enabled
Created policy `dbf-console` successfully.
Created policy `dbf-ukbox` successfully.
Added user `dbfconsole` successfully.
Added user `dbfukbox` successfully.
Attached Policies: [dbf-console]
To User: dbfconsole
Attached Policies: [dbf-ukbox]
To User: dbfukbox
=== RUN TestDBForwardMinio
2026/10/24 17:57:27 INFO replica sync system=store db=source.db replica=file txid.replica=0000000000000000 txid.db=0000000000000001
2026/10/24 17:57:27 INFO ltx file uploaded system=store db=source.db replica=file level=0 minTXID=0000000000000001 maxTXID=0000000000000001 size=720
2026/10/24 17:57:27 INFO replica sync system=store db=source.db replica=file txid.replica=0000000000000001 txid.db=0000000000000001
2026/10/24 17:57:27 INFO replica sync system=store db=source.db replica=file txid.replica=0000000000000001 txid.db=0000000000000002
2026/10/24 17:57:27 INFO ltx file uploaded system=store db=source.db replica=file level=0 minTXID=0000000000000002 maxTXID=0000000000000002 size=370
2026/10/24 17:57:27 INFO replica sync system=store db=source.db replica=file txid.replica=0000000000000002 txid.db=0000000000000002
2026/10/24 17:57:27 INFO replica sync system=store db=source.db replica=file txid.replica=0000000000000002 txid.db=0000000000000003
2026/10/24 17:57:27 INFO ltx file uploaded system=store db=source.db replica=file level=0 minTXID=0000000000000003 maxTXID=0000000000000003 size=454
2026/10/24 17:57:27 INFO replica sync system=store db=source.db replica=file txid.replica=0000000000000003 txid.db=0000000000000003
2026/10/24 17:57:27 INFO replica sync system=store db=source.db replica=file txid.replica=0000000000000000 txid.db=0000000000000001
2026/10/24 17:57:27 INFO ltx file uploaded system=store db=source.db replica=file level=0 minTXID=0000000000000001 maxTXID=0000000000000001 size=720
2026/10/24 17:57:27 INFO replica sync system=store db=source.db replica=file txid.replica=0000000000000001 txid.db=0000000000000001
2026/10/24 17:57:27 console: CARLOS_SECRETS_PUBKEY is unset, so no region outside the home can be chosen automatically
2026/10/24 17:57:27 console: could not notify member@example.com of a CLI token issue: keymail: lookup member@example.com: keymail: GET /api/federation/lookup?addr=member%40example.com&from=console%40127.0.0.1%3A34271: could not determine target mailbox
agent.go:135: dbreads: dbr_ad3tjm2lrxbq6726oyjkzsvlh4: planned 1 files (720 bytes) and restored to 1 in 9ms
agent.go:135: dbreads: dbr_ad3tjm2lrxbq6726oyjkzsvlh4: output 5 bytes in 1 confirmed chunks in 1ms
2026/10/24 17:57:28 console: db read dbr_ad3tjm2lrxbq6726oyjkzsvlh4: relayed 1 chunks (102 bytes) in 1.004s, ended done
agent.go:135: dbreads: dbr_j3u44rakgzmbbjhyzfp3mpr6lm: planned 3 files (1544 bytes) and restored to 3 in 9ms
agent.go:135: dbreads: dbr_j3u44rakgzmbbjhyzfp3mpr6lm: output 5 bytes in 1 confirmed chunks in 1ms
2026/10/24 17:57:29 console: db read dbr_j3u44rakgzmbbjhyzfp3mpr6lm: relayed 1 chunks (102 bytes) in 1.004s, ended done
agent.go:135: dbreads: dbr_j2rxyinrvixumrclhskquhxlou: planned 3 files (1544 bytes) and held through 3 in 9ms
agent.go:135: dbreads: dbr_j2rxyinrvixumrclhskquhxlou: output 1544 bytes in 1 confirmed chunks in 1ms
2026/10/24 17:57:30 console: db read dbr_j2rxyinrvixumrclhskquhxlou: relayed 1 chunks (1641 bytes) in 1.004s, ended done
=== RUN TestDBForwardMinio/by_disconnect
=== NAME TestDBForwardMinio
agent.go:135: dbreads: dbr_i6slifmnxmw2kxtdsaliiajlku: planned 3 files (1544 bytes) and restored to 3 in 9ms
2026/10/24 17:57:30 console: db read dbr_i6slifmnxmw2kxtdsaliiajlku: relayed 0 chunks (0 bytes) in 18ms, ended client gone
agent.go:135: dbreads: dbr_i6slifmnxmw2kxtdsaliiajlku: output 5 bytes in 1 confirmed chunks in 44ms
=== RUN TestDBForwardMinio/by_timeout
=== NAME TestDBForwardMinio
agent.go:135: dbreads: dbr_feqm35slsnk5pg7ssyiyvxas34: planned 3 files (1544 bytes) and restored to 3 in 10ms
2026/10/24 17:57:50 console: db read dbr_feqm35slsnk5pg7ssyiyvxas34: relayed 0 chunks (0 bytes) in 19.53s, ended no-result
agent.go:135: dbreads: dbr_feqm35slsnk5pg7ssyiyvxas34: output 5 bytes in 1 confirmed chunks in 19.51s
--- PASS: TestDBForwardMinio (22.91s)
--- PASS: TestDBForwardMinio/by_disconnect (0.17s)
--- PASS: TestDBForwardMinio/by_timeout (19.64s)
PASS
ok github.com/carlosframework/platform/internal/console 22.931s
minio contract: PASS
diff --git a/docs/superpowers/specs/CODEX-REVIEW-BRIEF-ASSET-CACHE.md b/docs/superpowers/specs/CODEX-REVIEW-BRIEF-ASSET-CACHE.md| new file mode 100644 |
| index 000000000..e9613e826 |
| --- /dev/null |
| +++ b/docs/superpowers/specs/CODEX-REVIEW-BRIEF-ASSET-CACHE.md |
| @@ -0,0 +1,41 @@ |
| +# Review brief: edge asset cache spec |
| + |
| +Spec: `docs/superpowers/specs/2026-10-24-edge-asset-cache-design.md` (rev 3). |
| +Repository: carlos/platform at the commit named in the run prompt. |
| + |
| +You are an independent second reader. The author is another model. Review |
| +the spec adversarially against the code in this tree and report what is |
| +wrong, not what is good. |
| + |
| +## Fixed points (do not re-argue) |
| + |
| +- Paul's rulings R1 to R3 in spec §13. |
| +- The scope in §0 and §2: pull-through only, build assets only, not the |
| + media roadmap's stage 1, no third-party CDN. |
| +- The author's calls marked "my call" may be challenged only with a |
| + concrete failure (a mechanism that breaks, an attack that works, a |
| + cost that is unbounded), not on taste. |
| + |
| +## What to look for |
| + |
| +1. Mechanisms that cannot do what the spec says against the current code. |
| + Cite file:line. |
| +2. Attacks that work: cross-tenant reads, a personalised response cached |
| + for someone else, a stale or wrong owner's bytes served, a cache that |
| + one tenant can use to hurt another, a gate or import gate bypassed, a |
| + client forging the fill marker. |
| +3. Interleavings: deploys with generation-managed routes, moves of a host |
| + between boxes (instance moves), replicas, aliases, a home disarmed or |
| + restarted, a purge racing a fill, an edge offline then back. |
| +4. Cost: anything that adds per-app or per-box reads of the deployment |
| + bucket beyond what §4.2 states, or unbounded disk, memory or fills. |
| +5. Provider boundary (§9) and rollout safety in a mixed fleet (§10). |
| +6. Gaps in §12's tests that would let one of the above ship. |
| + |
| +## Output |
| + |
| +Numbered findings, most severe first. For each: severity (P1 blocks the |
| +design, P2 must be fixed in the spec, P3 worth noting), the claim, the |
| +evidence with file:line, and the smallest change to the spec that fixes |
| +it. End with one line: "accept" if no P1 or P2 remain, otherwise |
| +"reject". |