amadan
offline-move: comment fixes after T1 re-review
1 file changed,
+2
−5
internal/moves/offline.go+2 −5
CI cancelled — superseded by a newer push — run details
CI log
=== gate === cd launchctx && go vet ./... && go test ./... -count=1 ok amadan.net/carlos/platform.git/launchctx 0.012s ? amadan.net/carlos/platform.git/launchctx/controlname [no test files] ? amadan.net/carlos/platform.git/launchctx/wireid [no test files] go vet ./... gofmt -l .: clean go test ./... -count=1 -timeout 30m amadan: job cancelled — a newer push superseded it
diff --git a/internal/moves/offline.go b/internal/moves/offline.go| index a51bdbbe1..a7fb5d577 100644 |
| --- a/internal/moves/offline.go |
| +++ b/internal/moves/offline.go |
| @@ -217,9 +217,6 @@ var ( |
| offlineRoles = map[string]bool{OfflineRoleSource: true, OfflineRoleSealer: true, OfflineRoleTarget: true} |
| offlinePhases = map[string]bool{OfflinePhaseStopped: true, OfflinePhaseSealed: true, OfflinePhaseLanded: true, OfflinePhaseOpened: true, |
| OfflinePhaseParked: true, OfflinePhaseGone: true, OfflinePhaseLifted: true, OfflinePhaseReverted: true, OfflinePhaseFailed: true} |
| - // The Checks a role's report may carry: the source side's (the sealer |
| - // and the stopped source boxes) carry items with Source "seal", the target |
| - // carries items it owns ("landing"). |
| ) |
| // offlineCarries reports whether a role's report may carry the item. |
| @@ -261,8 +258,8 @@ func ValidateOfflineReport(r OfflineReport) error { |
| // ItemsOK says whether the report holds an OK Check for every manifest |
| // item the owner decides, and names the ones that are missing or not OK, in |
| -// manifest order. The doors use it: flip needs the sealer's report OK for |
| -// owner seal, open the target's for owner landing. |
| +// manifest order. The open door uses it for owner landing; flip checks the |
| +// sealer's source values with SourceItemsOK. |
| func (r OfflineReport) ItemsOK(owner string) (ok bool, bad []string) { |
| for _, it := range OfflineOwned(owner) { |
| if c, found := r.Items[it.ID]; !found || !c.OK { |