amadan
Astra L18 joint round, round 5 brief: confirm the round-4 items closed
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 file changed,
+26
−0
docs/superpowers/plans/CODEX-REVIEW-L18-JOINT-ROUND-FINAL-BRIEF-5.md+26 −0
CI cancelled — superseded by a newer push — run details
CI log
=== gate === cd launchctx && go vet ./... && go test ./... -count=1 ok amadan.net/carlos/platform.git/launchctx 0.012s ? amadan.net/carlos/platform.git/launchctx/controlname [no test files] ? amadan.net/carlos/platform.git/launchctx/wireid [no test files] go vet ./... gofmt -l .: clean go test ./... -count=1 -timeout 30m amadan: job cancelled — a newer push superseded it
diff --git a/docs/superpowers/plans/CODEX-REVIEW-L18-JOINT-ROUND-FINAL-BRIEF-5.md b/docs/superpowers/plans/CODEX-REVIEW-L18-JOINT-ROUND-FINAL-BRIEF-5.md| new file mode 100644 |
| index 000000000..4d849b01e |
| --- /dev/null |
| +++ b/docs/superpowers/plans/CODEX-REVIEW-L18-JOINT-ROUND-FINAL-BRIEF-5.md |
| @@ -0,0 +1,26 @@ |
| +# Astra: L18 joint round, round 5 (confirming) |
| + |
| +Round 4 (`CODEX-REVIEW-L18-JOINT-ROUND-FINAL-4.md`) closed finding 1 and raised two P2s. Both are now fixed. |
| + |
| +1. **The relocation probe dropped `Staged`. Fixed in 3320b9ce on this branch.** `RelocationWakeInputs.Select` (`internal/host/relocationwake.go`) now forwards `Staged: l.Staged`. Every path through `Select` shares that one value. |
| + |
| + The builder found no other place that drops it: |
| + - the serving wake after completion uses `claimowners.go`, which already forwards it; |
| + - `ColdHandover` builds no launch inputs; |
| + - `relocationinstall.go` and `relocationassembly.go` construct only `DBPath`. |
| + |
| + The test `TestTheRelocationProbeStartNamesTheBuildItHashed` drives the real `activator.ClaimRuntime`. It fails without the fix. It copies `claimedBuild`'s condition rather than calling it, because that function is unexported. |
| +2. **The model's dirty return ignored target admission. Fixed in `region-ha-two-box-build` at 3b895b42.** Three places now require the claim to record the target's admission of this move, mirroring `movesinstall.go`'s `targetAdmitted`: |
| + - `filesHome`; |
| + - the INV-30 oracle `servableRegions`; |
| + - the install park. |
| + |
| + The new witness `wDirtyReturnWithoutAdmission` covers this, and the new mutation `dirty-return-needs-admission` is killed by INV-30. `TestFilesWitnessesStuckWithoutINV30` now skips the new witness: that scenario has no liveness consequence, so INV-30 is its only oracle. The unmutated 3000-seed run had no failures. |
| + |
| +**Judge:** |
| +1. Are both round-4 items closed? |
| +2. Is the `TestFilesWitnessesStuckWithoutINV30` exclusion sound? |
| +3. Anything new? Only report what these two diffs introduce. Do not re-review settled rulings or the main merge again. |
| +4. **Verdict:** may relocation merge dormant? |
| + |
| +Give findings P1/P2/P3 with file:line. |