amadan
Astra brief: hostfiles path cap, round 5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 file changed,
+20
−0
docs/superpowers/plans/CODEX-REVIEW-HOSTFILES-CAP-BRIEF-5.md+20 −0
CI cancelled — superseded by a newer push — run details
CI log
=== gate === cd launchctx && go vet ./... && go test ./... -count=1 ok amadan.net/carlos/platform.git/launchctx 0.011s ? amadan.net/carlos/platform.git/launchctx/controlname [no test files] ? amadan.net/carlos/platform.git/launchctx/wireid [no test files] go vet ./... gofmt -l .: clean go test ./... -count=1 -timeout 30m ok github.com/carlosframework/platform 284.415s ? github.com/carlosframework/platform/cmd/changelog [no test files] ok github.com/carlosframework/platform/cmd/console 2.618s ok github.com/carlosframework/platform/cmd/moveprobe 93.175s ok github.com/carlosframework/platform/cmd/zddprobe 0.701s ok github.com/carlosframework/platform/internal/activator 249.536s ok github.com/carlosframework/platform/internal/agentsock 0.018s ok github.com/carlosframework/platform/internal/alerting 0.003s ok github.com/carlosframework/platform/internal/analytics 0.021s ok github.com/carlosframework/platform/internal/appconfig 2.388s ok github.com/carlosframework/platform/internal/apperr 0.072s ok github.com/carlosframework/platform/internal/applog 0.132s ok github.com/carlosframework/platform/internal/awsinv 0.004s ok github.com/carlosframework/platform/internal/boxchoice 0.004s ok github.com/carlosframework/platform/internal/boxid 0.740s ? github.com/carlosframework/platform/internal/boxid/boxidtest [no test files] ? github.com/carlosframework/platform/internal/boxid/internal/signtest [no test files] ok github.com/carlosframework/platform/internal/boxvolumes 0.008s ok github.com/carlosframework/platform/internal/caps 0.013s ok github.com/carlosframework/platform/internal/certwarm 0.003s ok github.com/carlosframework/platform/internal/cgroup 0.697s ok github.com/carlosframework/platform/internal/changelog 0.302s ok github.com/carlosframework/platform/internal/clamd 0.055s ? github.com/carlosframework/platform/internal/cliflag [no test files] amadan: job cancelled — a newer push superseded it
diff --git a/docs/superpowers/plans/CODEX-REVIEW-HOSTFILES-CAP-BRIEF-5.md b/docs/superpowers/plans/CODEX-REVIEW-HOSTFILES-CAP-BRIEF-5.md| new file mode 100644 |
| index 000000000..3c552027a |
| --- /dev/null |
| +++ b/docs/superpowers/plans/CODEX-REVIEW-HOSTFILES-CAP-BRIEF-5.md |
| @@ -0,0 +1,20 @@ |
| +# Astra: hostfiles path cap, round 5 (confirming) |
| + |
| +Round 4 (`CODEX-REVIEW-HOSTFILES-CAP-4.md`) raised two P2s. Both are fixed; see the commit after c6dc57d0. |
| + |
| +1. **Deleted and skipped together.** An entry marked both no longer gets the exemption: only `Skipped != "" && !Deleted` is exempt. |
| +2. **Ancestor walk in `superseded()`.** `superseded()` now skips a path past the cap. Only a skipped entry can be one, and any live entry beneath it is refused. |
| + |
| +Tests: |
| +- `TestATombstoneMarkedSkippedPastTheCapIsRefused`. |
| +- `TestAVeryDeepSkippedEntryCostsRestoreNoAncestorWalk`: a 200,000-byte skipped path. Restore and Present complete at once; without the skip, Restore takes 15s. |
| + |
| +The census envelope is updated, with no unit or seal change. Main hasn't moved since f97898f1. |
| + |
| +**Judge:** |
| +1. Are both round-4 P2s closed? |
| +2. Is any other code still walking or cleaning an exempt skipped path's ancestors, or doing per-component work on it? Look across hostfiles and its callers in moves and relocation. |
| +3. Anything new? |
| +4. **Verdict:** is it ready to merge? |
| + |
| +Give findings P1/P2/P3 with file:line. Read-only; run nothing heavy. |