amadan
db-region-forward: review brief for the three plans
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 file changed,
+174
−0
docs/superpowers/specs/CODEX-REVIEW-BRIEF-DB-REGION-FORWARD-PLANS.md+174 −0
CI passed — run details
CI log
=== gate ===
.amadan/test-gate.sh
=== launchctx (1 s)
ok amadan.net/carlos/platform.git/launchctx 0.012s
? amadan.net/carlos/platform.git/launchctx/controlname [no test files]
? amadan.net/carlos/platform.git/launchctx/wireid [no test files]
=== vet (5 s)
=== gofmt (0 s)
gofmt -l .: clean
=== rest (150 s)
? github.com/carlosframework/platform/cmd/changelog [no test files]
ok github.com/carlosframework/platform/cmd/console 3.966s
ok github.com/carlosframework/platform/cmd/moveprobe 11.586s
ok github.com/carlosframework/platform/cmd/zddprobe 0.711s
ok github.com/carlosframework/platform/internal/activator 59.982s
ok github.com/carlosframework/platform/internal/agentsock 0.017s
ok github.com/carlosframework/platform/internal/alerting 0.017s
ok github.com/carlosframework/platform/internal/analytics 0.019s
ok github.com/carlosframework/platform/internal/appconfig 2.905s
ok github.com/carlosframework/platform/internal/apperr 0.073s
ok github.com/carlosframework/platform/internal/applog 0.134s
ok github.com/carlosframework/platform/internal/awsinv 0.016s
ok github.com/carlosframework/platform/internal/boxchoice 0.016s
ok github.com/carlosframework/platform/internal/boxid 0.424s
? github.com/carlosframework/platform/internal/boxid/boxidtest [no test files]
? github.com/carlosframework/platform/internal/boxid/internal/signtest [no test files]
ok github.com/carlosframework/platform/internal/boxvolumes 0.016s
ok github.com/carlosframework/platform/internal/caps 0.019s
ok github.com/carlosframework/platform/internal/certwarm 0.016s
ok github.com/carlosframework/platform/internal/cgroup 0.708s
ok github.com/carlosframework/platform/internal/changelog 0.358s
ok github.com/carlosframework/platform/internal/claimactivation 0.899s
ok github.com/carlosframework/platform/internal/clamd 0.055s
? github.com/carlosframework/platform/internal/cliflag [no test files]
? github.com/carlosframework/platform/internal/controlname [no test files]
? github.com/carlosframework/platform/internal/controlsock [no test files]
ok github.com/carlosframework/platform/internal/dbdoor 5.662s
ok github.com/carlosframework/platform/internal/dbdoor/dbdoortest 0.024s
ok github.com/carlosframework/platform/internal/dbverify 0.016s
ok github.com/carlosframework/platform/internal/dnsrec 0.018s
ok github.com/carlosframework/platform/internal/docsite 0.022s
ok github.com/carlosframework/platform/internal/domains 2.956s
ok github.com/carlosframework/platform/internal/doorkey 0.020s
ok github.com/carlosframework/platform/internal/economics 0.018s
ok github.com/carlosframework/platform/internal/edge 45.242s
? github.com/carlosframework/platform/internal/edgeproof [no test files]
ok github.com/carlosframework/platform/internal/edgesfile 0.008s
ok github.com/carlosframework/platform/internal/fleetapi 0.135s
ok github.com/carlosframework/platform/internal/gate 1.901s
ok github.com/carlosframework/platform/internal/genselect 0.015s
ok github.com/carlosframework/platform/internal/geo 0.027s
ok github.com/carlosframework/platform/internal/geoip 0.030s
ok github.com/carlosframework/platform/internal/historyreadback 0.156s
ok github.com/carlosframework/platform/internal/host 139.621s
ok github.com/carlosframework/platform/internal/hostactors 6.265s
ok github.com/carlosframework/platform/internal/hostactors/awsmembership 0.010s
ok github.com/carlosframework/platform/internal/hostbox 3.303s
ok github.com/carlosframework/platform/internal/hostclaim 0.911s
ok github.com/carlosframework/platform/internal/hostenv 0.020s
ok github.com/carlosframework/platform/internal/hostevidence 0.010s
ok github.com/carlosframework/platform/internal/hostexec 5.777s
ok github.com/carlosframework/platform/internal/hostfence 0.042s
ok github.com/carlosframework/platform/internal/hostfiles 10.405s
ok github.com/carlosframework/platform/internal/hostfloor 0.051s
ok github.com/carlosframework/platform/internal/hostguard 1.130s
ok github.com/carlosframework/platform/internal/hostops 2.236s
? github.com/carlosframework/platform/internal/hostops/fencerelease [no test files]
ok github.com/carlosframework/platform/internal/hostops/internal/fencerelease 0.004s
ok github.com/carlosframework/platform/internal/hostquarantine 0.004s
ok github.com/carlosframework/platform/internal/hostrelocate 0.718s
ok github.com/carlosframework/platform/internal/hostresolve 0.201s
ok github.com/carlosframework/platform/internal/hostwrite 0.006s
ok github.com/carlosframework/platform/internal/infraview 0.005s
ok github.com/carlosframework/platform/internal/instancectl 5.261s
ok github.com/carlosframework/platform/internal/instanceexec 2.810s
ok github.com/carlosframework/platform/internal/instancefs 0.029s
ok github.com/carlosframework/platform/internal/instancekey 0.005s
ok github.com/carlosframework/platform/internal/instanceupdates 0.007s
ok github.com/carlosframework/platform/internal/layout 1.950s
ok github.com/carlosframework/platform/internal/lbhealth 0.004s
ok github.com/carlosframework/platform/internal/lease 10.101s
ok github.com/carlosframework/platform/internal/lease/leasetest 0.711s
ok github.com/carlosframework/platform/internal/ledger 0.029s
ok github.com/carlosframework/platform/internal/mail 0.260s
ok github.com/carlosframework/platform/internal/maintenance 0.095s
ok github.com/carlosframework/platform/internal/maintenanceexec 5.694s
ok github.com/carlosframework/platform/internal/maintenanceguard 0.105s
ok github.com/carlosframework/platform/internal/metrics 0.015s
ok github.com/carlosframework/platform/internal/moves 21.532s
ok github.com/carlosframework/platform/internal/moves/archive 1.162s
ok github.com/carlosframework/platform/internal/objstore 0.342s
ok github.com/carlosframework/platform/internal/ops 0.192s
ok github.com/carlosframework/platform/internal/park 0.316s
ok github.com/carlosframework/platform/internal/plans 0.006s
ok github.com/carlosframework/platform/internal/privatefile 0.008s
ok github.com/carlosframework/platform/internal/provision 14.559s
ok github.com/carlosframework/platform/internal/publicrelease 0.014s
? github.com/carlosframework/platform/internal/regionname [no test files]
ok github.com/carlosframework/platform/internal/registry 5.709s
ok github.com/carlosframework/platform/internal/relay 7.244s
ok github.com/carlosframework/platform/internal/release 25.940s
ok github.com/carlosframework/platform/internal/rollout 3.950s
ok github.com/carlosframework/platform/internal/rolloutwords 0.005s
ok github.com/carlosframework/platform/internal/rootaws 0.008s
ok github.com/carlosframework/platform/internal/rootparticipation 0.068s
ok github.com/carlosframework/platform/internal/rootstate 0.029s
ok github.com/carlosframework/platform/internal/runs 0.537s
ok github.com/carlosframework/platform/internal/s3compat 0.006s
ok github.com/carlosframework/platform/internal/safefile 0.005s
ok github.com/carlosframework/platform/internal/schedule 2.759s
ok github.com/carlosframework/platform/internal/seeds 0.014s
ok github.com/carlosframework/platform/internal/sim/engines 2.793s
ok github.com/carlosframework/platform/internal/sim/hostlife 11.323s
ok github.com/carlosframework/platform/internal/sim/litestreamfacts 4.332s
ok github.com/carlosframework/platform/internal/status 0.085s
ok github.com/carlosframework/platform/internal/steering 0.006s
ok github.com/carlosframework/platform/internal/stopevidence 0.178s
ok github.com/carlosframework/platform/internal/svcrole 0.002s
ok github.com/carlosframework/platform/internal/telemetry 0.004s
ok github.com/carlosframework/platform/internal/termfence 0.006s
ok github.com/carlosframework/platform/internal/tunnelclient 0.004s
ok github.com/carlosframework/platform/internal/unixdial 0.003s
ok github.com/carlosframework/platform/internal/updatewords 0.004s
ok github.com/carlosframework/platform/internal/usage 0.008s
ok github.com/carlosframework/platform/internal/version 0.002s
ok github.com/carlosframework/platform/internal/vet 1.720s
=== internal_console@0 (83 s)
ok github.com/carlosframework/platform/internal/console 80.300s
=== internal_console@1 (34 s)
ok github.com/carlosframework/platform/internal/console 32.001s
=== internal_console@2 (42 s)
ok github.com/carlosframework/platform/internal/console 39.649s
=== internal_console@3 (37 s)
ok github.com/carlosframework/platform/internal/console 34.738s
=== internal_console@4 (38 s)
ok github.com/carlosframework/platform/internal/console 36.058s
=== internal_console@5 (40 s)
ok github.com/carlosframework/platform/internal/console 37.433s
=== internal_console@6 (42 s)
ok github.com/carlosframework/platform/internal/console 39.313s
=== internal_console@7 (43 s)
ok github.com/carlosframework/platform/internal/console 40.284s
=== root@0 (32 s)
ok github.com/carlosframework/platform 30.909s
=== root@1 (44 s)
ok github.com/carlosframework/platform 42.504s
=== root@2 (41 s)
ok github.com/carlosframework/platform 39.848s
=== cross ===
--- shard 0 of 5 ---
cross-compiling darwin/arm64
--- shard 1 of 5 ---
cross-compiling darwin/amd64
--- shard 2 of 5 ---
cross-compiling linux/arm64
linux/arm64 carlos binary: 50069666 bytes (ceiling 52000000)
--- shard 3 of 5 ---
cross-compiling windows/amd64
--- shard 4 of 5 ---
cross-compiling windows/arm64
=== minio-contract ===
minio contract: arm64, minio RELEASE.2025-09-07T16-13-09Z, mc RELEASE.2025-08-13T08-35-41Z
minio: cached, digest verified
mc: cached, digest verified
minio healthy on 127.0.0.1:20999
Added `local` successfully.
Bucket created successfully `local/contract-bucket`.
Bucket created successfully `local/denied-bucket`.
Created policy `contract-only` successfully.
Added user `scopeduser` successfully.
Attached Policies: [contract-only]
To User: scopeduser
buckets and scoped user ready
=== RUN TestDeliveredContractMinio
=== RUN TestDeliveredContractMinio/put
=== RUN TestDeliveredContractMinio/get_round-trips_the_body
=== RUN TestDeliveredContractMinio/list_shows_the_key
=== RUN TestDeliveredContractMinio/head_and_list_agree_on_the_version
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_its_own_object
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/not_by_PutObjectTagging
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/and_not_by_x-amz-tagging_on_upload
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CreateMultipartUpload
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CopyObject_with_a_REPLACE_tagging_directive
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/but_multipart_itself_is_allowed
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_copy_itself_is_allowed
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/a_POST-policy_forged_tag_with_a_matching_version_is_still_not_a_verdict
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_an_ordinary_tagged-with-something-else_upload_is_allowed
=== RUN TestDeliveredContractMinio/delete_removes_it
=== RUN TestDeliveredContractMinio/cross-bucket_denial
--- PASS: TestDeliveredContractMinio (0.02s)
--- PASS: TestDeliveredContractMinio/put (0.00s)
--- PASS: TestDeliveredContractMinio/get_round-trips_the_body (0.00s)
--- PASS: TestDeliveredContractMinio/list_shows_the_key (0.00s)
--- PASS: TestDeliveredContractMinio/head_and_list_agree_on_the_version (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/not_by_PutObjectTagging (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/and_not_by_x-amz-tagging_on_upload (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route (0.01s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CreateMultipartUpload (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CopyObject_with_a_REPLACE_tagging_directive (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/but_multipart_itself_is_allowed (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_copy_itself_is_allowed (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/a_POST-policy_forged_tag_with_a_matching_version_is_still_not_a_verdict (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_an_ordinary_tagged-with-something-else_upload_is_allowed (0.00s)
--- PASS: TestDeliveredContractMinio/delete_removes_it (0.00s)
--- PASS: TestDeliveredContractMinio/cross-bucket_denial (0.00s)
PASS
ok github.com/carlosframework/platform/internal/objstore 0.024s
=== RUN TestT4StorageProbeMinio
2026/10/22 15:25:01 moves: T4: STORE: list: operation error S3: ListObjectsV2, https response error StatusCode: 403, RequestID: 18E0E36B260AC74C, HostID: 7c420053e0fbcd7f41653fdd92ffa2802c903d05303b1aa15adc2e8bb65d183f, api error SignatureDoesNotMatch: The request signature we calculated does not match the signature you provided. Check your key and signing method.
--- PASS: TestT4StorageProbeMinio (0.01s)
PASS
ok github.com/carlosframework/platform/internal/host 0.022s
minio contract: PASS
diff --git a/docs/superpowers/specs/CODEX-REVIEW-BRIEF-DB-REGION-FORWARD-PLANS.md b/docs/superpowers/specs/CODEX-REVIEW-BRIEF-DB-REGION-FORWARD-PLANS.md| new file mode 100644 |
| index 000000000..292a9b584 |
| --- /dev/null |
| +++ b/docs/superpowers/specs/CODEX-REVIEW-BRIEF-DB-REGION-FORWARD-PLANS.md |
| @@ -0,0 +1,174 @@ |
| +# Review brief: the implementation plans for `carlos db` region forward |
| + |
| +You are an independent second reader of three implementation plans for the |
| +CARLOS platform (this repository). Read them cold and adversarially, against |
| +the spec they implement and against the code on `main`. Nothing is built. |
| + |
| +**Plans:** |
| + |
| +- `docs/superpowers/plans/2026-10-22-db-region-forward-plan-1-box.md`: the |
| + box side and the wire format, shipped dark behind the `db-read-1` |
| + capability (17 tasks); |
| +- `docs/superpowers/plans/2026-10-22-db-region-forward-plan-2-query.md`: the |
| + console and the CLI for `query` and `query --at` (14 tasks); |
| +- `docs/superpowers/plans/2026-10-22-db-region-forward-plan-3-pull.md`: |
| + `pull` and `pull --at` (10 tasks). |
| + |
| +**Spec:** `docs/superpowers/specs/2026-10-22-db-region-forward-design.md`, |
| +rev 5 plus the ruling commit `fe27bd9c`, at the commit named in the prompt. |
| +Astra accepted rev 5 in round 5 (`CODEX-FINDINGS-DB-REGION-FORWARD-R5.md`). |
| +Read `AGENTS.md` first, then the spec, then the plans. |
| + |
| +Each plan is written to be executed task by task by an engineer who knows |
| +Go and nothing about this repository. A task's code is meant to compile |
| +and its tests to pass as written, against `main` plus the plans before it. |
| + |
| +## Fixed: do not re-argue |
| + |
| +- **The spec's design.** It was reviewed over five rounds and accepted. Do |
| + not propose a different design. Report a plan that fails to build what the |
| + spec says, or builds something the spec rules out. |
| +- **Paul's rulings (spec §16, 2026-10-22).** Ruling 1: the feature ships |
| + through the deployment bucket as designed, with the true storage |
| + statement; a per-region bucket for this traffic is plan 5, a follow-up |
| + after the feature works. Rulings 2 to 5 stand as written (the limits, the |
| + audit row, the copy casing, in-region reads moving to the box path in plan |
| + 4). Plans 4 and 5 are listed, not written; do not review their absence. |
| +- **The repository's rules**, which every plan carries as Global |
| + Constraints: production-wired acceptance (real constructors, the real |
| + units through the real `ensureSystemUnits`, real stores; stand-ins only in |
| + unit tests and labelled); targeted local test runs and CI as the full run; |
| + `//go:build linux` plus a `!linux` stub for Linux-only code; copy reviewed |
| + before it ships, with no em dashes; no tenant names; the default |
| + `GOCACHE`; a census overlay per branch, loaded last after main's; merge |
| + main first; test weights for new slow console or root tests; no CI-only |
| + scripts under `scripts/`; `t.Parallel()` in new host tests unless they |
| + touch env, cwd, umask or package vars. |
| + |
| +## What to check |
| + |
| +Check against the code, not the plans' description of it. Cite `file:line` |
| +for every claim about existing code. |
| + |
| +1. **Coverage.** Every item of spec §14's plans 1, 2 and 3 has a task. |
| + Every test T1 to T18 of §11.4 is built by the plan §14 assigns it to, as |
| + the spec describes it, and every mutation check of §11.4 appears in a |
| + plan's mutation table with a test that would actually turn red. Every |
| + number in §5.7 reaches code verbatim. J1 to J5 (§5.3) each hold in the |
| + code the plans write: in particular nothing the console writes or keeps |
| + outlives the request except one `cancel` (J1), every protocol write is a |
| + conditional create (J2), the `picked` read-back (J3), no protocol delete |
| + (J4), admission released only by the handler's return and box |
| + reservations held until the worker unit is gone (J5). |
| +2. **Code that cannot build or does not do what it says.** Names and |
| + signatures the plans call on `main`: `release.Store` and `Put`'s |
| + create-only `ifMatch ""`, `release.SignRootEnvelope`, |
| + `release.VerifyRootEnvelope`, `release.MintKeyGrant`, `release.RootSigner`, |
| + `dbdoor`'s unexported `restoreOnce`, `removeCopy`, `checkDB`, |
| + `fileIterator`, `errReadOnly`, `litestream.CalcRestorePlan`, |
| + `lease.ReadReplicaClient`, `hostclaim.Incarnation`, |
| + `registry.FleetPlacement`, `edgesfile.ReadLiveSnapshot` and the |
| + `PlacementView` fields, the console's `dbGate`, `resolveDBSource`, |
| + `apiAccountApp`, `readJSONLimit`, `cliRoute`, `auditActivity`, |
| + `fx.st.Events`, `newConsoleFixture`, `cliToken`, `putShopRecord`, |
| + `rawReq`, the root package's `buildCarlos`, `useTempCredentials`, |
| + `e2eDeviceLogin`, `replicaS3`, `carlosTestEnv`, `edge.New`, |
| + `registry.Open`, and the edge package's backhaul harness |
| + (`newBackhaulEdge`, `refreshHomeMap`, `MintMeshKey`, `putJSON`). Where a |
| + plan's test or code would not compile, fail for the wrong reason, or |
| + pass while proving nothing, say which. |
| +3. **Consistency across plans.** A name, field or signature defined in one |
| + task and used in another, or in a later plan, must match: for example |
| + `newChunkWriter`'s parameters (plan 1 Task 11, plan 3 Task 3), |
| + `readDBForward` and `openDBForward` (plan 2 Task 8, plan 3 Task 7), |
| + `dbForwardAuditDetail` (plan 2 Task 6, plan 3 Task 6), the fixture |
| + helpers each plan's tests reuse, and the copy gate's inventory and built |
| + list as rows are added and swapped. |
| +4. **Isolation and the identity bracket, as built.** Does the unit file in |
| + plan 1 Task 13 match spec §8.3 option by option, and do the witnesses in |
| + Task 15 actually exercise each one from inside the installed unit? Does |
| + anything the agent sends the worker, or anything the worker can open, |
| + come from the request rather than the fresh record and the box's config? |
| + Is there any path where output (a chunk) can exist before check B, for a |
| + query or for a pull (plan 3's hold mode)? |
| +5. **The long request, as built.** Does plan 2's handler extend the read |
| + deadline before anything that could block, flush every line under a |
| + write deadline, bound everything before the `200` at 20 s, and give up at |
| + the owner's deadline plus a minute but never past 22 minutes? Does the |
| + CLI's 23-minute context and its line bound fit a pull's 1 MiB chunks |
| + (plan 3)? |
| +6. **Tests that prove what they claim.** For each acceptance test, is it |
| + production-wired where the spec says so, and does it fail if the |
| + property it names breaks? Are stand-ins (the in-process worker, scripted |
| + boxes, the edge test's upstream) labelled, and is each one where the |
| + spec allows a stand-in? |
| +7. **Census and CI mechanics.** Are the overlay rows in the format |
| + `loadRootReadInventory` accepts (`internal/provision/plan14_root_reads_test.go:399`), |
| + with legacy fingerprints and the seal handled as the existing overlays |
| + handle them, and the H3 removal in the form the loader allows? Is the |
| + 9B8 inventory layering right? Does the MinIO step addition in plan 2 |
| + Task 12 work with the existing `.amadan/ci.d/30-minio-contract`? |
| +8. **The plans' interpretations of the spec.** These were judgement calls. |
| + Say whether each is sound; challenge any that changes behaviour the spec |
| + fixes: |
| + - an additive `ended` line (`not-picked`, `no-result`) so the CLI can |
| + tell DBF-3 from DBF-12 (plan 2 Task 2); |
| + - the reads route answers 404 for an in-region instance, and today's |
| + residency sentence when forwarding is off, on a host-claim console, with |
| + a key that is not the root's, or for a home-region record seen from a |
| + regional console (plan 2 Tasks 5 and 6); |
| + - a class, pool or fleet change seen by the box is `record-changed` |
| + (plan 1 Task 10); |
| + - a box that fails the disk floor at admission does not pick the read |
| + (spec §7.1), so `no-room` comes only from the plan's growth; the root |
| + runner's T12 shows the floor holding a second read back and admitting |
| + it once the first unit is gone, and the `no-room` code itself is a unit |
| + test (plan 1 Tasks 9, 11, 15); |
| + - a finished read's reservation is released only when no |
| + `carlos-dbread@` unit is left at all (plan 1 Task 9); |
| + - output past the cap is cut at the byte; the result is `done` with |
| + `output-cap`, and the CLI prints the kept rows and then fails with |
| + DBF-6 on stderr (plan 1 Task 11, plan 2 Task 8); |
| + - a planning or restore overrun, or a worker that fails to start, is |
| + `interrupted` (DBF-12); |
| + - T7 is split: a scaled run through the real edge and the console's real |
| + `http.Server` with `ReadTimeout` set to 2 s in CI, an unscaled |
| + 21-minute run with a scripted box behind `CARLOS_DBF_LONG=1` run once |
| + before handoff, and the backhaul hop in package `edge` with a stand-in |
| + upstream, because `internal/edge` tests cannot import the console |
| + (plan 2 Tasks 10 and 11); |
| + - T8's "old CLI" is `dbRestoreError` over the door's 409, the function |
| + every CLI before plan 2 runs on a door refusal; |
| + - the two unit files enter the root-read census as `external` rows, the |
| + form `carlos-instance-cmd@.service` took, which the plans read as spec |
| + §13's "Plan 14 write census"; and the overlay loads after whatever main |
| + loads last (at `5f341f33` that is `console-brand-name`, not |
| + `securelisten-337`); |
| + - the copy record is created whole in plan 1, and each plan reviews and |
| + builds its own rows; |
| + - plan 3 keeps the 22-minute bound and sizes the pull's cap to fit a |
| + measured relay rate (at most 2 GiB; `CARLOS_DB_PULL_MAX_BYTES` only |
| + lowers it), with 1 MiB pull chunks and a 2 MiB line bound; |
| + - plan 3's worker holds and verifies the files and sends them back only |
| + after check B, because the agent writes no files and no output may |
| + precede check B; |
| + - `LimitFSIZE` is fixed at the default 2 GiB cap in the unit file, and |
| + `InaccessiblePaths` marks `/run/carlos-control` optional. |
| +9. **Missing pieces.** Anything a plan relies on that does not exist on |
| + `main` or in an earlier task, or exists in a different shape. |
| + |
| +## Output |
| + |
| +A numbered list of findings. Each one gives: |
| + |
| +- **severity:** P0 the plan cannot be executed as written (a task that |
| + cannot build or whose gate cannot pass); P1 the built code would break a |
| + spec invariant or ruling, cross a tenant, or expose box credentials; P2 |
| + wrong behaviour, a missing spec item, or a test that proves nothing; P3 |
| + clarity or a gap; |
| +- the plan and task; |
| +- the evidence, with `file:line` in the code or `plan:Task N` in the plans; |
| +- a concrete fix to the plan. |
| + |
| +Then a verdict per plan: accept, or revise. Do not rewrite the plans. No |
| +praise. |