carlos / platform Public

db-region-forward: review brief for round 2

Lists the round 1 findings and rev 2's answer to each, asks for a
disposition table first and then only new findings, and points at the
mechanisms rev 2 added.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude 2 days ago 8c118ae76f7fde5202c8afc096df3eda1111440f parent 2cf4a88

1 file changed, +47 −3

docs/superpowers/specs/CODEX-REVIEW-BRIEF-DB-REGION-FORWARD.md +47 −3

CI passed — run details

CI log

=== gate ===
.amadan/test-gate.sh
=== launchctx (0 s)
ok  	amadan.net/carlos/platform.git/launchctx	0.012s
?   	amadan.net/carlos/platform.git/launchctx/controlname	[no test files]
?   	amadan.net/carlos/platform.git/launchctx/wireid	[no test files]
=== vet (17 s)
=== gofmt (0 s)
gofmt -l .: clean
=== rest (164 s)
?   	github.com/carlosframework/platform/cmd/changelog	[no test files]
ok  	github.com/carlosframework/platform/cmd/console	3.709s
ok  	github.com/carlosframework/platform/cmd/moveprobe	12.084s
ok  	github.com/carlosframework/platform/cmd/zddprobe	0.825s
ok  	github.com/carlosframework/platform/internal/activator	60.211s
ok  	github.com/carlosframework/platform/internal/agentsock	0.036s
ok  	github.com/carlosframework/platform/internal/alerting	0.014s
ok  	github.com/carlosframework/platform/internal/analytics	0.038s
ok  	github.com/carlosframework/platform/internal/appconfig	3.009s
ok  	github.com/carlosframework/platform/internal/apperr	0.216s
ok  	github.com/carlosframework/platform/internal/applog	0.343s
ok  	github.com/carlosframework/platform/internal/awsinv	0.010s
ok  	github.com/carlosframework/platform/internal/boxchoice	0.014s
ok  	github.com/carlosframework/platform/internal/boxid	0.764s
?   	github.com/carlosframework/platform/internal/boxid/boxidtest	[no test files]
?   	github.com/carlosframework/platform/internal/boxid/internal/signtest	[no test files]
ok  	github.com/carlosframework/platform/internal/boxvolumes	0.016s
ok  	github.com/carlosframework/platform/internal/caps	0.020s
ok  	github.com/carlosframework/platform/internal/certwarm	0.008s
ok  	github.com/carlosframework/platform/internal/cgroup	0.835s
ok  	github.com/carlosframework/platform/internal/changelog	0.618s
ok  	github.com/carlosframework/platform/internal/claimactivation	1.373s
ok  	github.com/carlosframework/platform/internal/clamd	0.063s
?   	github.com/carlosframework/platform/internal/cliflag	[no test files]
?   	github.com/carlosframework/platform/internal/controlname	[no test files]
?   	github.com/carlosframework/platform/internal/controlsock	[no test files]
ok  	github.com/carlosframework/platform/internal/dbdoor	5.784s
ok  	github.com/carlosframework/platform/internal/dbdoor/dbdoortest	0.038s
ok  	github.com/carlosframework/platform/internal/dbverify	0.016s
ok  	github.com/carlosframework/platform/internal/dnsrec	0.008s
ok  	github.com/carlosframework/platform/internal/docsite	0.013s
ok  	github.com/carlosframework/platform/internal/domains	2.965s
ok  	github.com/carlosframework/platform/internal/doorkey	0.016s
ok  	github.com/carlosframework/platform/internal/economics	0.010s
ok  	github.com/carlosframework/platform/internal/edge	45.537s
?   	github.com/carlosframework/platform/internal/edgeproof	[no test files]
ok  	github.com/carlosframework/platform/internal/edgesfile	0.008s
ok  	github.com/carlosframework/platform/internal/fleetapi	0.141s
ok  	github.com/carlosframework/platform/internal/gate	1.655s
ok  	github.com/carlosframework/platform/internal/genselect	0.015s
ok  	github.com/carlosframework/platform/internal/geo	0.014s
ok  	github.com/carlosframework/platform/internal/geoip	0.034s
ok  	github.com/carlosframework/platform/internal/historyreadback	0.164s
ok  	github.com/carlosframework/platform/internal/host	136.311s
ok  	github.com/carlosframework/platform/internal/hostactors	6.960s
ok  	github.com/carlosframework/platform/internal/hostactors/awsmembership	0.008s
ok  	github.com/carlosframework/platform/internal/hostbox	2.927s
ok  	github.com/carlosframework/platform/internal/hostclaim	0.818s
ok  	github.com/carlosframework/platform/internal/hostenv	0.005s
ok  	github.com/carlosframework/platform/internal/hostevidence	0.009s
ok  	github.com/carlosframework/platform/internal/hostexec	5.296s
ok  	github.com/carlosframework/platform/internal/hostfence	0.039s
ok  	github.com/carlosframework/platform/internal/hostfiles	10.432s
ok  	github.com/carlosframework/platform/internal/hostfloor	0.017s
ok  	github.com/carlosframework/platform/internal/hostguard	1.065s
ok  	github.com/carlosframework/platform/internal/hostops	2.000s
?   	github.com/carlosframework/platform/internal/hostops/fencerelease	[no test files]
ok  	github.com/carlosframework/platform/internal/hostops/internal/fencerelease	0.003s
ok  	github.com/carlosframework/platform/internal/hostquarantine	0.002s
ok  	github.com/carlosframework/platform/internal/hostrelocate	0.642s
ok  	github.com/carlosframework/platform/internal/hostresolve	0.215s
ok  	github.com/carlosframework/platform/internal/hostwrite	0.005s
ok  	github.com/carlosframework/platform/internal/infraview	0.005s
ok  	github.com/carlosframework/platform/internal/instancectl	5.232s
ok  	github.com/carlosframework/platform/internal/instanceexec	2.799s
ok  	github.com/carlosframework/platform/internal/instancefs	0.008s
ok  	github.com/carlosframework/platform/internal/instancekey	0.018s
ok  	github.com/carlosframework/platform/internal/instanceupdates	0.020s
ok  	github.com/carlosframework/platform/internal/layout	1.648s
ok  	github.com/carlosframework/platform/internal/lbhealth	0.004s
ok  	github.com/carlosframework/platform/internal/lease	10.316s
ok  	github.com/carlosframework/platform/internal/lease/leasetest	0.517s
ok  	github.com/carlosframework/platform/internal/ledger	0.032s
ok  	github.com/carlosframework/platform/internal/mail	0.241s
ok  	github.com/carlosframework/platform/internal/maintenance	0.105s
ok  	github.com/carlosframework/platform/internal/maintenanceexec	5.585s
ok  	github.com/carlosframework/platform/internal/maintenanceguard	0.104s
ok  	github.com/carlosframework/platform/internal/metrics	0.005s
ok  	github.com/carlosframework/platform/internal/moves	22.980s
ok  	github.com/carlosframework/platform/internal/moves/archive	0.990s
ok  	github.com/carlosframework/platform/internal/objstore	0.270s
ok  	github.com/carlosframework/platform/internal/ops	0.280s
ok  	github.com/carlosframework/platform/internal/park	0.344s
ok  	github.com/carlosframework/platform/internal/plans	0.012s
ok  	github.com/carlosframework/platform/internal/privatefile	0.004s
ok  	github.com/carlosframework/platform/internal/provision	22.990s
ok  	github.com/carlosframework/platform/internal/publicrelease	0.008s
?   	github.com/carlosframework/platform/internal/regionname	[no test files]
ok  	github.com/carlosframework/platform/internal/registry	5.641s
ok  	github.com/carlosframework/platform/internal/relay	7.249s
ok  	github.com/carlosframework/platform/internal/release	26.498s
ok  	github.com/carlosframework/platform/internal/rollout	3.768s
ok  	github.com/carlosframework/platform/internal/rolloutwords	0.005s
ok  	github.com/carlosframework/platform/internal/rootaws	0.009s
ok  	github.com/carlosframework/platform/internal/rootparticipation	0.064s
ok  	github.com/carlosframework/platform/internal/rootstate	0.028s
ok  	github.com/carlosframework/platform/internal/runs	0.514s
ok  	github.com/carlosframework/platform/internal/s3compat	0.008s
ok  	github.com/carlosframework/platform/internal/safefile	0.005s
ok  	github.com/carlosframework/platform/internal/schedule	2.690s
ok  	github.com/carlosframework/platform/internal/seeds	0.016s
ok  	github.com/carlosframework/platform/internal/sim/engines	2.606s
ok  	github.com/carlosframework/platform/internal/sim/hostlife	12.536s
ok  	github.com/carlosframework/platform/internal/sim/litestreamfacts	3.452s
ok  	github.com/carlosframework/platform/internal/status	0.081s
ok  	github.com/carlosframework/platform/internal/steering	0.007s
ok  	github.com/carlosframework/platform/internal/stopevidence	0.294s
ok  	github.com/carlosframework/platform/internal/svcrole	0.002s
ok  	github.com/carlosframework/platform/internal/telemetry	0.004s
ok  	github.com/carlosframework/platform/internal/termfence	0.004s
ok  	github.com/carlosframework/platform/internal/tunnelclient	0.004s
ok  	github.com/carlosframework/platform/internal/unixdial	0.005s
ok  	github.com/carlosframework/platform/internal/updatewords	0.006s
ok  	github.com/carlosframework/platform/internal/usage	0.006s
ok  	github.com/carlosframework/platform/internal/version	0.003s
ok  	github.com/carlosframework/platform/internal/vet	1.698s
=== internal_console@0 (81 s)
ok  	github.com/carlosframework/platform/internal/console	78.619s
=== internal_console@1 (36 s)
ok  	github.com/carlosframework/platform/internal/console	33.501s
=== internal_console@2 (42 s)
ok  	github.com/carlosframework/platform/internal/console	40.045s
=== internal_console@3 (37 s)
ok  	github.com/carlosframework/platform/internal/console	35.272s
=== internal_console@4 (39 s)
ok  	github.com/carlosframework/platform/internal/console	36.839s
=== internal_console@5 (40 s)
ok  	github.com/carlosframework/platform/internal/console	38.488s
=== internal_console@6 (42 s)
ok  	github.com/carlosframework/platform/internal/console	40.277s
=== internal_console@7 (43 s)
ok  	github.com/carlosframework/platform/internal/console	41.421s
=== root@0 (34 s)
ok  	github.com/carlosframework/platform	32.078s
=== root@1 (45 s)
ok  	github.com/carlosframework/platform	43.146s
=== root@2 (42 s)
ok  	github.com/carlosframework/platform	40.470s
=== cross ===
--- shard 0 of 5 ---
cross-compiling darwin/arm64
--- shard 1 of 5 ---
cross-compiling darwin/amd64
--- shard 2 of 5 ---
cross-compiling linux/arm64
linux/arm64 carlos binary: 50069666 bytes (ceiling 52000000)
--- shard 3 of 5 ---
cross-compiling windows/amd64
--- shard 4 of 5 ---
cross-compiling windows/arm64
=== minio-contract ===
minio contract: arm64, minio RELEASE.2025-09-07T16-13-09Z, mc RELEASE.2025-08-13T08-35-41Z
  minio: downloading https://github.com/minio/minio/releases/download/RELEASE.2025-09-07T16-13-09Z/minio.linux-arm64.RELEASE.2025-09-07T16-13-09Z
  minio: downloaded, digest verified
  mc: downloading https://github.com/minio/mc/releases/download/RELEASE.2025-08-13T08-35-41Z/mc.linux-arm64.RELEASE.2025-08-13T08-35-41Z
  mc: downloaded, digest verified
  minio healthy on 127.0.0.1:20999
Added `local` successfully.
Bucket created successfully `local/contract-bucket`.
Bucket created successfully `local/denied-bucket`.
Created policy `contract-only` successfully.
Added user `scopeduser` successfully.
Attached Policies: [contract-only]
To User: scopeduser
  buckets and scoped user ready
=== RUN   TestDeliveredContractMinio
=== RUN   TestDeliveredContractMinio/put
=== RUN   TestDeliveredContractMinio/get_round-trips_the_body
=== RUN   TestDeliveredContractMinio/list_shows_the_key
=== RUN   TestDeliveredContractMinio/head_and_list_agree_on_the_version
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_its_own_object
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/not_by_PutObjectTagging
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/and_not_by_x-amz-tagging_on_upload
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CreateMultipartUpload
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CopyObject_with_a_REPLACE_tagging_directive
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/but_multipart_itself_is_allowed
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_copy_itself_is_allowed
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/a_POST-policy_forged_tag_with_a_matching_version_is_still_not_a_verdict
=== RUN   TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_an_ordinary_tagged-with-something-else_upload_is_allowed
=== RUN   TestDeliveredContractMinio/delete_removes_it
=== RUN   TestDeliveredContractMinio/cross-bucket_denial
--- PASS: TestDeliveredContractMinio (0.02s)
    --- PASS: TestDeliveredContractMinio/put (0.00s)
    --- PASS: TestDeliveredContractMinio/get_round-trips_the_body (0.00s)
    --- PASS: TestDeliveredContractMinio/list_shows_the_key (0.00s)
    --- PASS: TestDeliveredContractMinio/head_and_list_agree_on_the_version (0.00s)
    --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object (0.00s)
        --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/not_by_PutObjectTagging (0.00s)
        --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/and_not_by_x-amz-tagging_on_upload (0.00s)
    --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route (0.01s)
        --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CreateMultipartUpload (0.00s)
        --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CopyObject_with_a_REPLACE_tagging_directive (0.00s)
        --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/but_multipart_itself_is_allowed (0.00s)
        --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_copy_itself_is_allowed (0.00s)
        --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/a_POST-policy_forged_tag_with_a_matching_version_is_still_not_a_verdict (0.00s)
        --- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_an_ordinary_tagged-with-something-else_upload_is_allowed (0.00s)
    --- PASS: TestDeliveredContractMinio/delete_removes_it (0.00s)
    --- PASS: TestDeliveredContractMinio/cross-bucket_denial (0.00s)
PASS
ok  	github.com/carlosframework/platform/internal/objstore	0.025s
=== RUN   TestT4StorageProbeMinio
2026/10/22 11:24:00 moves: T4: STORE: list: operation error S3: ListObjectsV2, https response error StatusCode: 403, RequestID: 18E0D644640F03B9, HostID: 7c420053e0fbcd7f41653fdd92ffa2802c903d05303b1aa15adc2e8bb65d183f, api error SignatureDoesNotMatch: The request signature we calculated does not match the signature you provided. Check your key and signing method.
--- PASS: TestT4StorageProbeMinio (0.01s)
PASS
ok  	github.com/carlosframework/platform/internal/host	0.023s
minio contract: PASS

diff --git a/docs/superpowers/specs/CODEX-REVIEW-BRIEF-DB-REGION-FORWARD.md b/docs/superpowers/specs/CODEX-REVIEW-BRIEF-DB-REGION-FORWARD.md

index 738d00eb5..16add9656 100644

--- a/docs/superpowers/specs/CODEX-REVIEW-BRIEF-DB-REGION-FORWARD.md

+++ b/docs/superpowers/specs/CODEX-REVIEW-BRIEF-DB-REGION-FORWARD.md

@@ -7,6 +7,50 @@ yet; you are reviewing the design against the code on `main`.

**Spec:** `docs/superpowers/specs/2026-10-22-db-region-forward-design.md`,

at the commit named in the prompt. Read `AGENTS.md` first.

+## Round 2

+This is round 2. Rev 2 of the spec answers your round 1 findings,

+`docs/superpowers/specs/CODEX-FINDINGS-DB-REGION-FORWARD.md` (reviewed at

+`a12757a1`). Each change is marked **(codex N)** where it lands, and §18

+gives the reasons for the two parts that were declined.

+| # | Round 1 finding | Spec's answer |

+|---|---|---|

+| 1 | P1: the incarnation check does not cover the replica reads | accepted in part: the identity bracket, §8.2 (checks A and B around the download; no output before B). Version pinning declined, §18 |

+| 2 | `Accept=yes` does not put the connection on stdin | accepted: `StandardInput=socket`, `StandardOutput=socket`, `StandardError=journal`, §8.3 |

+| 3 | progress acks indistinguishable from the final ack | accepted: separate `ack` and `done` routes; `done` carries the result's SHA-256, §5.4, §9.1 |

+| 4 | a lost result does not stop a late writer | accepted: heartbeat removed; a box deadline in `picked`, a 60 s bound on each PUT, and a fence before `lost`, §5.8 |

+| 5 | immediate cleanup reopens the election | accepted: `picked` is a tombstone kept until the read has ended and the acceptance window has passed, §5.8, §5.9 |

+| 6 | the CLI cannot promise it showed none of a rejected answer | accepted: the CLI buffers up to 64 MiB and writes nothing until the summary checks out, §5.4 |

+| 7 | the window does not bound stored ciphertext | accepted: acknowledged chunks are deleted on each progress ack, §5.7 |

+| 8 | disk checks can spend the same space twice | accepted: one reservation table in the agent; restart waits for old workers, §5.7 |

+| 9 | a socket inode does not prove a worker can run | accepted: capability from the armed loop and a readiness probe through the real units, §7.1 |

+| 10 | snapshot-load failure is not in the error return | accepted: refuse up front only on `Complete` and `BoxesComplete` evidence, §7.1 |

+| 11 | separate regional store servers need per-store endpoints | accepted in part: the overclaim is withdrawn and the supported shape stated, §12. Per-store endpoints declined, §18 |

+| 12 | "non-root" is not a census class; the runner stays CLI-reachable | accepted: a class per declaration with both callers named, §13 |

+Rev 2 also folds in the coordinator's provisional answers to rev 1's open

+questions (§16). They await Paul. Do not argue them; report only a

+mechanism that fails to honour one.

+**Start with a disposition table** for findings 1 to 12: fixed, declined

+with an acceptable reason, or not fixed. Check each answer against the code,

+not against the spec's summary of it. Then give **only new findings**. Do

+not repeat a round 1 finding unless its fix is wrong or incomplete; then

+say so in the table and give the new evidence.

+Worth extra attention in round 2, because rev 2 added them:

+- the write fence (§5.8): can any box write land after the console's

+ `lost`, given clock skew and the SDK's retry behaviour inside a 60 s

+ PUT timeout?

+- the tombstone's deletion rule against a read that runs the full 20

+ minutes;

+- the reservation table across an agent restart (§5.7);

+- the readiness probe: what it proves, and whether a probe can itself be

+ abused or leak a worker;

+- the worker protocol's `ready` and `run` split (§8.2, §8.3).

## Fixed rulings: do not re-argue them

The product owner approved this direction:

@@ -29,9 +73,9 @@ connection). Report only:

- a mechanism that breaks something else in the platform;

- a mechanism that cannot be built as described against `main`.

-The spec's own decisions (§4, D1 to D8) are open to challenge. Its open

-questions (§16) are for the product owner; comment on them only where the

-spec's answer is unsafe.

+The spec's own decisions (§4, D1 to D8) are open to challenge. The

+provisional rulings in §16 are for the product owner; comment on them only

+where the spec's mechanism fails to honour one or is unsafe.

## What to check