amadan
S3 change index: whole-branch review brief (#336)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 file changed,
+62
−0
docs/superpowers/specs/CODEX-REVIEW-BRIEF-S3-CHANGE-INDEX-CODE.md+62 −0
CI passed — run details
CI log
=== gate ===
.amadan/test-gate.sh
=== launchctx (1 s)
ok amadan.net/carlos/platform.git/launchctx 0.015s
? amadan.net/carlos/platform.git/launchctx/controlname [no test files]
? amadan.net/carlos/platform.git/launchctx/wireid [no test files]
=== vet (28 s)
=== gofmt (1 s)
gofmt -l .: clean
=== rest (179 s)
? github.com/carlosframework/platform/cmd/changelog [no test files]
ok github.com/carlosframework/platform/cmd/console 3.909s
ok github.com/carlosframework/platform/cmd/moveprobe 11.856s
ok github.com/carlosframework/platform/cmd/zddprobe 0.767s
ok github.com/carlosframework/platform/internal/activator 60.399s
ok github.com/carlosframework/platform/internal/agentsock 0.038s
ok github.com/carlosframework/platform/internal/alerting 0.016s
ok github.com/carlosframework/platform/internal/analytics 0.038s
ok github.com/carlosframework/platform/internal/appconfig 2.951s
ok github.com/carlosframework/platform/internal/apperr 0.156s
ok github.com/carlosframework/platform/internal/applog 0.249s
ok github.com/carlosframework/platform/internal/awsinv 0.019s
ok github.com/carlosframework/platform/internal/boxchoice 0.022s
ok github.com/carlosframework/platform/internal/boxid 1.257s
? github.com/carlosframework/platform/internal/boxid/boxidtest [no test files]
? github.com/carlosframework/platform/internal/boxid/internal/signtest [no test files]
ok github.com/carlosframework/platform/internal/boxvolumes 0.022s
ok github.com/carlosframework/platform/internal/caps 0.033s
ok github.com/carlosframework/platform/internal/certwarm 0.007s
ok github.com/carlosframework/platform/internal/cgroup 0.784s
ok github.com/carlosframework/platform/internal/changelog 0.551s
ok github.com/carlosframework/platform/internal/claimactivation 1.255s
ok github.com/carlosframework/platform/internal/clamd 0.059s
? github.com/carlosframework/platform/internal/cliflag [no test files]
? github.com/carlosframework/platform/internal/controlname [no test files]
? github.com/carlosframework/platform/internal/controlsock [no test files]
ok github.com/carlosframework/platform/internal/dbdoor 6.077s
ok github.com/carlosframework/platform/internal/dbdoor/dbdoortest 0.011s
ok github.com/carlosframework/platform/internal/dbverify 0.022s
ok github.com/carlosframework/platform/internal/dnsrec 0.005s
ok github.com/carlosframework/platform/internal/docsite 0.032s
ok github.com/carlosframework/platform/internal/domains 3.094s
ok github.com/carlosframework/platform/internal/doorkey 0.006s
ok github.com/carlosframework/platform/internal/economics 0.004s
ok github.com/carlosframework/platform/internal/edge 45.711s
? github.com/carlosframework/platform/internal/edgeproof [no test files]
ok github.com/carlosframework/platform/internal/edgesfile 0.009s
ok github.com/carlosframework/platform/internal/fleetapi 0.208s
ok github.com/carlosframework/platform/internal/gate 1.679s
ok github.com/carlosframework/platform/internal/genselect 0.022s
ok github.com/carlosframework/platform/internal/geo 0.023s
ok github.com/carlosframework/platform/internal/geoip 0.052s
ok github.com/carlosframework/platform/internal/historyreadback 0.287s
ok github.com/carlosframework/platform/internal/host 140.404s
ok github.com/carlosframework/platform/internal/hostactors 5.393s
ok github.com/carlosframework/platform/internal/hostactors/awsmembership 0.006s
ok github.com/carlosframework/platform/internal/hostbox 3.090s
ok github.com/carlosframework/platform/internal/hostclaim 0.885s
ok github.com/carlosframework/platform/internal/hostenv 0.005s
ok github.com/carlosframework/platform/internal/hostevidence 0.006s
ok github.com/carlosframework/platform/internal/hostexec 5.364s
ok github.com/carlosframework/platform/internal/hostfence 0.075s
ok github.com/carlosframework/platform/internal/hostfiles 10.309s
ok github.com/carlosframework/platform/internal/hostfloor 0.026s
ok github.com/carlosframework/platform/internal/hostguard 1.044s
ok github.com/carlosframework/platform/internal/hostops 2.010s
? github.com/carlosframework/platform/internal/hostops/fencerelease [no test files]
ok github.com/carlosframework/platform/internal/hostops/internal/fencerelease 0.002s
ok github.com/carlosframework/platform/internal/hostquarantine 0.002s
ok github.com/carlosframework/platform/internal/hostrelocate 0.710s
ok github.com/carlosframework/platform/internal/hostresolve 0.195s
ok github.com/carlosframework/platform/internal/hostwrite 0.005s
ok github.com/carlosframework/platform/internal/infraview 0.006s
ok github.com/carlosframework/platform/internal/instancectl 5.246s
ok github.com/carlosframework/platform/internal/instanceexec 2.841s
ok github.com/carlosframework/platform/internal/instancefs 0.006s
ok github.com/carlosframework/platform/internal/instancekey 0.007s
ok github.com/carlosframework/platform/internal/instanceupdates 0.007s
ok github.com/carlosframework/platform/internal/layout 1.812s
ok github.com/carlosframework/platform/internal/lbhealth 0.004s
ok github.com/carlosframework/platform/internal/lease 10.229s
ok github.com/carlosframework/platform/internal/lease/leasetest 0.555s
ok github.com/carlosframework/platform/internal/ledger 0.067s
ok github.com/carlosframework/platform/internal/mail 0.266s
ok github.com/carlosframework/platform/internal/maintenance 0.124s
ok github.com/carlosframework/platform/internal/maintenanceexec 5.645s
ok github.com/carlosframework/platform/internal/maintenanceguard 0.107s
ok github.com/carlosframework/platform/internal/metrics 0.010s
ok github.com/carlosframework/platform/internal/moves 22.395s
ok github.com/carlosframework/platform/internal/moves/archive 1.022s
ok github.com/carlosframework/platform/internal/objstore 0.341s
ok github.com/carlosframework/platform/internal/ops 0.274s
ok github.com/carlosframework/platform/internal/park 0.348s
ok github.com/carlosframework/platform/internal/plans 0.015s
ok github.com/carlosframework/platform/internal/privatefile 0.004s
ok github.com/carlosframework/platform/internal/provision 23.719s
ok github.com/carlosframework/platform/internal/publicrelease 0.008s
? github.com/carlosframework/platform/internal/regionname [no test files]
ok github.com/carlosframework/platform/internal/registry 5.609s
ok github.com/carlosframework/platform/internal/relay 7.237s
ok github.com/carlosframework/platform/internal/release 26.583s
ok github.com/carlosframework/platform/internal/rollout 3.848s
ok github.com/carlosframework/platform/internal/rolloutwords 0.003s
ok github.com/carlosframework/platform/internal/rootaws 0.007s
ok github.com/carlosframework/platform/internal/rootparticipation 0.069s
ok github.com/carlosframework/platform/internal/rootstate 0.027s
ok github.com/carlosframework/platform/internal/runs 0.627s
ok github.com/carlosframework/platform/internal/s3compat 0.011s
ok github.com/carlosframework/platform/internal/safefile 0.004s
ok github.com/carlosframework/platform/internal/schedule 2.670s
ok github.com/carlosframework/platform/internal/seeds 0.012s
ok github.com/carlosframework/platform/internal/sim/engines 2.635s
ok github.com/carlosframework/platform/internal/sim/hostlife 10.659s
ok github.com/carlosframework/platform/internal/sim/litestreamfacts 4.061s
ok github.com/carlosframework/platform/internal/status 0.076s
ok github.com/carlosframework/platform/internal/steering 0.007s
ok github.com/carlosframework/platform/internal/stopevidence 0.295s
ok github.com/carlosframework/platform/internal/svcrole 0.002s
ok github.com/carlosframework/platform/internal/telemetry 0.006s
ok github.com/carlosframework/platform/internal/termfence 0.005s
ok github.com/carlosframework/platform/internal/tunnelclient 0.004s
ok github.com/carlosframework/platform/internal/unixdial 0.003s
ok github.com/carlosframework/platform/internal/updatewords 0.006s
ok github.com/carlosframework/platform/internal/usage 0.005s
ok github.com/carlosframework/platform/internal/version 0.003s
ok github.com/carlosframework/platform/internal/vet 1.677s
=== internal_console@0 (84 s)
ok github.com/carlosframework/platform/internal/console 82.344s
=== internal_console@1 (37 s)
ok github.com/carlosframework/platform/internal/console 34.657s
=== internal_console@2 (35 s)
ok github.com/carlosframework/platform/internal/console 32.673s
=== internal_console@3 (40 s)
ok github.com/carlosframework/platform/internal/console 37.558s
=== internal_console@4 (45 s)
ok github.com/carlosframework/platform/internal/console 42.443s
=== internal_console@5 (41 s)
ok github.com/carlosframework/platform/internal/console 38.783s
=== internal_console@6 (43 s)
ok github.com/carlosframework/platform/internal/console 40.751s
=== internal_console@7 (43 s)
ok github.com/carlosframework/platform/internal/console 40.904s
=== root@0 (31 s)
ok github.com/carlosframework/platform 29.663s
=== root@1 (44 s)
ok github.com/carlosframework/platform 42.609s
=== root@2 (46 s)
ok github.com/carlosframework/platform 44.673s
=== cross ===
--- shard 0 of 5 ---
cross-compiling darwin/arm64
--- shard 1 of 5 ---
cross-compiling darwin/amd64
--- shard 2 of 5 ---
cross-compiling linux/arm64
linux/arm64 carlos binary: 50266274 bytes (ceiling 52000000)
--- shard 3 of 5 ---
cross-compiling windows/amd64
--- shard 4 of 5 ---
cross-compiling windows/arm64
=== minio-contract ===
minio contract: arm64, minio RELEASE.2025-09-07T16-13-09Z, mc RELEASE.2025-08-13T08-35-41Z
minio: cached, digest verified
mc: cached, digest verified
minio healthy on 127.0.0.1:20999
Added `local` successfully.
Bucket created successfully `local/contract-bucket`.
Bucket created successfully `local/denied-bucket`.
Created policy `contract-only` successfully.
Added user `scopeduser` successfully.
Attached Policies: [contract-only]
To User: scopeduser
buckets and scoped user ready
=== RUN TestDeliveredContractMinio
=== RUN TestDeliveredContractMinio/put
=== RUN TestDeliveredContractMinio/get_round-trips_the_body
=== RUN TestDeliveredContractMinio/list_shows_the_key
=== RUN TestDeliveredContractMinio/head_and_list_agree_on_the_version
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_its_own_object
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/not_by_PutObjectTagging
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/and_not_by_x-amz-tagging_on_upload
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CreateMultipartUpload
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CopyObject_with_a_REPLACE_tagging_directive
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/but_multipart_itself_is_allowed
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_copy_itself_is_allowed
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/a_POST-policy_forged_tag_with_a_matching_version_is_still_not_a_verdict
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_an_ordinary_tagged-with-something-else_upload_is_allowed
=== RUN TestDeliveredContractMinio/delete_removes_it
=== RUN TestDeliveredContractMinio/cross-bucket_denial
--- PASS: TestDeliveredContractMinio (0.02s)
--- PASS: TestDeliveredContractMinio/put (0.00s)
--- PASS: TestDeliveredContractMinio/get_round-trips_the_body (0.00s)
--- PASS: TestDeliveredContractMinio/list_shows_the_key (0.00s)
--- PASS: TestDeliveredContractMinio/head_and_list_agree_on_the_version (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/not_by_PutObjectTagging (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/and_not_by_x-amz-tagging_on_upload (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route (0.01s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CreateMultipartUpload (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CopyObject_with_a_REPLACE_tagging_directive (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/but_multipart_itself_is_allowed (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_copy_itself_is_allowed (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/a_POST-policy_forged_tag_with_a_matching_version_is_still_not_a_verdict (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_an_ordinary_tagged-with-something-else_upload_is_allowed (0.00s)
--- PASS: TestDeliveredContractMinio/delete_removes_it (0.00s)
--- PASS: TestDeliveredContractMinio/cross-bucket_denial (0.00s)
PASS
ok github.com/carlosframework/platform/internal/objstore 0.025s
=== RUN TestT4StorageProbeMinio
2026/10/22 15:20:25 moves: T4: STORE: list: operation error S3: ListObjectsV2, https response error StatusCode: 403, RequestID: 18E0E32AEA3B4E45, HostID: 7c420053e0fbcd7f41653fdd92ffa2802c903d05303b1aa15adc2e8bb65d183f, api error SignatureDoesNotMatch: The request signature we calculated does not match the signature you provided. Check your key and signing method.
--- PASS: TestT4StorageProbeMinio (0.01s)
PASS
ok github.com/carlosframework/platform/internal/host 0.023s
=== RUN TestS3StoreMinioContract
=== RUN TestS3StoreMinioContract/conditional_get_and_etag_listing
=== RUN TestS3StoreMinioContract/bump_through_every_mutation_path
--- PASS: TestS3StoreMinioContract (0.03s)
--- PASS: TestS3StoreMinioContract/conditional_get_and_etag_listing (0.01s)
--- PASS: TestS3StoreMinioContract/bump_through_every_mutation_path (0.02s)
PASS
ok github.com/carlosframework/platform/internal/release 0.032s
minio contract: PASS
diff --git a/docs/superpowers/specs/CODEX-REVIEW-BRIEF-S3-CHANGE-INDEX-CODE.md b/docs/superpowers/specs/CODEX-REVIEW-BRIEF-S3-CHANGE-INDEX-CODE.md| new file mode 100644 |
| index 000000000..b9811e33b |
| --- /dev/null |
| +++ b/docs/superpowers/specs/CODEX-REVIEW-BRIEF-S3-CHANGE-INDEX-CODE.md |
| @@ -0,0 +1,62 @@ |
| +# Review brief: S3 change index, whole-branch code review |
| + |
| +You are the final, independent reviewer of branch `s3-polling-336` before |
| +it is merged. Read cold and adversarially. Verify against the code, cite |
| +`file:line` for every claim. |
| + |
| +**Range:** `git diff 5f341f33..<commit named in the prompt>` (5f341f33 is the |
| +merge base with main; the branch already contains main up to it). The same |
| +diff with commit list and stat is in |
| +`.superpowers/sdd/2026-10-21-s3-change-index/review-5f341f33..26b9e850.diff`. |
| + |
| +**Spec (binding):** `docs/superpowers/specs/2026-10-21-s3-change-index-design.md` |
| +(rev 3 plus the §3.2 `schedule-status` row and the §4.4 confirm-in-bucket |
| +note). **Plan:** `docs/superpowers/plans/2026-10-21-s3-change-index.md`. |
| +**Execution ledger (rulings, deferred minors, carried findings):** |
| +`.superpowers/sdd/2026-10-21-s3-change-index/progress.md`. |
| + |
| +## Fixed rulings, do not re-argue |
| + |
| +Spec §1 R1 to R4, and every line in the ledger that starts with `Ruling:`. |
| +Report only mechanisms that fail to honour them, or that break something. |
| + |
| +## What matters most |
| + |
| +The feature is dormant until `CARLOS_CHANGE_INDEX=read` is set; writers |
| +always bump. In priority order: |
| + |
| +1. **Disarmed equivalence.** With the variable unset, is every box, edge, |
| + console and CLI path behaviourally identical to main, apart from the |
| + writers' best-effort bump of `control/changes.json`? Any new read, |
| + goroutine, changed store type, changed error, or changed timing. |
| +2. **Destructive decisions on stale data, when armed.** Reconcile and |
| + sidecar removals, trash removals, moves steps, seed-sweep snapshot |
| + deletes, orphan-run deletes, claim install and retire. Each must still |
| + be proved against the live bucket, or by a snapshot that is provably at |
| + least as fresh as the walk it replaces. |
| +3. **Lost changes beyond the 30-minute backstop.** Any write a reader acts |
| + on that can be missed indefinitely: scopes, gates, the cert mirror, the |
| + home map, the console sweeps, the fast tick's last-acted map. |
| +4. **Concurrency.** Lock order `w.pass` then `reconcileMu` then |
| + `RecordView.mu` (a leaf); the watch's poll slot; the edge and agent |
| + sharing one watch; anything that can stall the health heartbeat. |
| +5. **Cost.** The point of the work. Any steady-state loop that still reads |
| + per app or per box when nothing changed, once armed. |
| +6. **Census and root.** Task 12's overlays |
| + (`internal/provision/testdata/plan14-root-reads-s3-change-index.tsv`, |
| + `internal/provision/s3_change_index_census_test.go`): are the classes |
| + right, and is root's new read-increment-CAS of `control/changes.json` |
| + (via `runSystemClaims`) acceptable? |
| + |
| +Also triage the ledger's `minor (deferred)` lines: name any that must be |
| +fixed before merge, and why. One is flagged by the controller as likely: |
| +RecordView's index poll runs under the caller's unbounded context, and a |
| +lock give-up leaves `ReadGate` readers trusting a frozen observation. |
| + |
| +## Output |
| + |
| +Numbered findings, each with severity (P1 = correctness, data loss or an |
| +outage; P2 = a goal failure or significant gap; P3 = minor), `file:line` |
| +evidence, and the change you would require. Then the deferred-minor triage |
| +(must-fix list). End with a verdict: accept, or reject with the P1s that |
| +block. |