amadan
Astra stage B plan round 6: unedited
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 file changed,
+39
−0
docs/superpowers/plans/CODEX-PLAN-REGION-HA-STAGE-B-R6.md+39 −0
diff --git a/docs/superpowers/plans/CODEX-PLAN-REGION-HA-STAGE-B-R6.md b/docs/superpowers/plans/CODEX-PLAN-REGION-HA-STAGE-B-R6.md| new file mode 100644 |
| index 000000000..161d34c29 |
| --- /dev/null |
| +++ b/docs/superpowers/plans/CODEX-PLAN-REGION-HA-STAGE-B-R6.md |
| @@ -0,0 +1,39 @@ |
| +Reviewed branch HEAD `cdb92961`; its plan is unchanged from rev 5 at `d92a721e`. |
| + |
| +1. **P2 — Probe-stop replay can take over another operation’s fence.** [Plan:11001](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/region-ha-1b-next-build/docs/superpowers/plans/2026-10-10-region-ha-1b-next-stage-b.md:11001) |
| + The persisted marker records only the probe session. After an agent restart, it survives while the activator’s fence does not. If another operation installs a lower or equal fence, the old marker authorizes `FenceAndStop` to replace it; completion then lifts it. Ownership must identify the current activator fence and be checked atomically. Add a restart test with an existing foreign fence. |
| + |
| +2. **P2 — A failed marker write permanently blocks probe-stop retries.** [Plan:11012](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/region-ha-1b-next-build/docs/superpowers/plans/2026-10-10-region-ha-1b-next-stage-b.md:11012) |
| + The activator fence is installed before its ownership marker is written. If that write fails, every retry sees `ErrFenceHeld` and a missing marker, returning before retrying persistence or requesting root’s stop. Recovery of the filesystem does not help; the relocation eventually becomes stuck. Make acquisition recoverable and test a failed first marker write followed by retry. |
| + |
| +3. **P2 — R5-2 loses successor-operation recovery.** [Plan:2599](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/region-ha-1b-next-build/docs/superpowers/plans/2026-10-10-region-ha-1b-next-stage-b.md:2599) |
| + Consider A→B completing, then B→C starting before B performs C10’s discharge. The start guard permits this: A’s outstanding retirement concerns neither B nor C. B still retains the previous participation slot, so main’s `Prepare` returns `ErrLost` for the successor indefinitely. The removed lifecycle coverage included successors before cleanup; the replacements omit them. Restore a deterministic test through real start transitions and provide safe handover or prevent the successor from starting before discharge. |
| + |
| +4. **P2 — Landing conversion bypasses worker authorization.** [Plan:13070](/home/paulca/amadan.net/carlos/platform/.claude/worktrees/region-ha-1b-next-build/docs/superpowers/plans/2026-10-10-region-ha-1b-next-stage-b.md:13070) |
| + `convertFencedLanding` never validates the converting worker’s current enrollment, active status, or destination region. `Worker.Fence` checks the target’s fence; its authority validates the original fence reporter, not this caller. An out-of-region or revoked worker can therefore perform a conversion that ordinary `Worker.Step` would refuse. Apply the same worker checks and add no-mutation tests for unauthorized callers. |
| + |
| +**Verdict: not ready to build unchanged.** |
| + |
| +C10 matches the quoted claim-session contract, including persisted binding and stopping cleanup on read errors. R5-1 is acceptable. R5-2’s replacement coverage is insufficient as described above. R5-3 may remain deferred while dormant, but task 10b must be mandatory before activation; checklist item 18’s “if wired” wording should reflect that. R5-4 is acceptable as an explicit activation gate, without claiming equivalent integration coverage. |
| + |
| +Static review only; no tests executed or files changed. |
| + |
| +--- |
| + |
| +**FIRST PROMPT:** |
| +Review Stage B plan rev 5 at branch HEAD using brief 6. |
| + |
| +**WHAT:** |
| +Check consolidation, withdrawn tests, C10, and activation gates. |
| + |
| +**STATUS:** |
| +Review complete: four P2 findings; not ready to build. |
| + |
| +**NEEDED:** |
| +Nothing. |
| + |
| +**RECOMMENDED:** |
| +Revise the four affected paths and add their regression tests before building. |
| + |
| +**SESSION:** |
| +Safe to close. Workspace unchanged; read-only permissions prevented saving a handoff file. |
| \ No newline at end of file |