amadan
spec: Astra whole-branch review brief for plans 2
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 file changed,
+42
−0
docs/superpowers/specs/CODEX-REVIEW-BRIEF-PLANS-2-CODE.md+42 −0
CI passed — run details
CI log
=== gate ===
.amadan/test-gate.sh
=== launchctx (2 s)
ok amadan.net/carlos/platform.git/launchctx 0.012s
? amadan.net/carlos/platform.git/launchctx/controlname [no test files]
? amadan.net/carlos/platform.git/launchctx/wireid [no test files]
=== vet (16 s)
=== gofmt (1 s)
gofmt -l .: clean
=== rest (150 s)
? github.com/carlosframework/platform/cmd/changelog [no test files]
ok github.com/carlosframework/platform/cmd/console 3.494s
ok github.com/carlosframework/platform/cmd/moveprobe 11.755s
ok github.com/carlosframework/platform/cmd/zddprobe 0.770s
ok github.com/carlosframework/platform/internal/activator 63.919s
ok github.com/carlosframework/platform/internal/agentsock 0.016s
ok github.com/carlosframework/platform/internal/alerting 0.006s
ok github.com/carlosframework/platform/internal/analytics 0.026s
ok github.com/carlosframework/platform/internal/appconfig 2.773s
ok github.com/carlosframework/platform/internal/apperr 0.091s
ok github.com/carlosframework/platform/internal/applog 0.170s
ok github.com/carlosframework/platform/internal/awsinv 0.004s
ok github.com/carlosframework/platform/internal/boxchoice 0.005s
ok github.com/carlosframework/platform/internal/boxid 0.436s
? github.com/carlosframework/platform/internal/boxid/boxidtest [no test files]
? github.com/carlosframework/platform/internal/boxid/internal/signtest [no test files]
ok github.com/carlosframework/platform/internal/boxvolumes 0.012s
ok github.com/carlosframework/platform/internal/caps 0.014s
ok github.com/carlosframework/platform/internal/certwarm 0.002s
ok github.com/carlosframework/platform/internal/cgroup 0.808s
ok github.com/carlosframework/platform/internal/changelog 0.438s
ok github.com/carlosframework/platform/internal/claimactivation 0.967s
ok github.com/carlosframework/platform/internal/clamd 0.059s
? github.com/carlosframework/platform/internal/cliflag [no test files]
? github.com/carlosframework/platform/internal/controlname [no test files]
? github.com/carlosframework/platform/internal/controlsock [no test files]
ok github.com/carlosframework/platform/internal/dbdoor 6.293s
ok github.com/carlosframework/platform/internal/dbdoor/dbdoortest 0.014s
ok github.com/carlosframework/platform/internal/dbverify 0.005s
ok github.com/carlosframework/platform/internal/dnsrec 0.004s
ok github.com/carlosframework/platform/internal/docsite 0.008s
ok github.com/carlosframework/platform/internal/domains 2.726s
ok github.com/carlosframework/platform/internal/doorkey 0.006s
ok github.com/carlosframework/platform/internal/economics 0.006s
ok github.com/carlosframework/platform/internal/edge 45.446s
? github.com/carlosframework/platform/internal/edgeproof [no test files]
ok github.com/carlosframework/platform/internal/edgesfile 0.008s
ok github.com/carlosframework/platform/internal/fleetapi 0.148s
ok github.com/carlosframework/platform/internal/gate 1.663s
ok github.com/carlosframework/platform/internal/genselect 0.022s
ok github.com/carlosframework/platform/internal/geo 0.015s
ok github.com/carlosframework/platform/internal/geoip 0.040s
ok github.com/carlosframework/platform/internal/historyreadback 0.220s
ok github.com/carlosframework/platform/internal/host 123.419s
ok github.com/carlosframework/platform/internal/hostactors 5.891s
ok github.com/carlosframework/platform/internal/hostactors/awsmembership 0.016s
ok github.com/carlosframework/platform/internal/hostbox 2.903s
ok github.com/carlosframework/platform/internal/hostclaim 0.785s
ok github.com/carlosframework/platform/internal/hostenv 0.015s
ok github.com/carlosframework/platform/internal/hostevidence 0.005s
ok github.com/carlosframework/platform/internal/hostexec 5.348s
ok github.com/carlosframework/platform/internal/hostfence 0.033s
ok github.com/carlosframework/platform/internal/hostfiles 10.407s
ok github.com/carlosframework/platform/internal/hostfloor 0.017s
ok github.com/carlosframework/platform/internal/hostguard 1.026s
ok github.com/carlosframework/platform/internal/hostops 1.994s
? github.com/carlosframework/platform/internal/hostops/fencerelease [no test files]
ok github.com/carlosframework/platform/internal/hostops/internal/fencerelease 0.017s
ok github.com/carlosframework/platform/internal/hostquarantine 0.015s
ok github.com/carlosframework/platform/internal/hostrelocate 0.566s
ok github.com/carlosframework/platform/internal/hostresolve 0.195s
ok github.com/carlosframework/platform/internal/hostwrite 0.015s
ok github.com/carlosframework/platform/internal/infraview 0.015s
ok github.com/carlosframework/platform/internal/instancectl 5.229s
ok github.com/carlosframework/platform/internal/instanceexec 2.754s
ok github.com/carlosframework/platform/internal/instancefs 0.025s
ok github.com/carlosframework/platform/internal/instancekey 0.016s
ok github.com/carlosframework/platform/internal/instanceupdates 0.029s
ok github.com/carlosframework/platform/internal/layout 1.764s
ok github.com/carlosframework/platform/internal/lbhealth 0.019s
ok github.com/carlosframework/platform/internal/lease 10.160s
ok github.com/carlosframework/platform/internal/lease/leasetest 0.560s
ok github.com/carlosframework/platform/internal/ledger 0.040s
ok github.com/carlosframework/platform/internal/mail 0.234s
ok github.com/carlosframework/platform/internal/maintenance 0.082s
ok github.com/carlosframework/platform/internal/maintenanceexec 5.534s
ok github.com/carlosframework/platform/internal/maintenanceguard 0.100s
ok github.com/carlosframework/platform/internal/metrics 0.005s
ok github.com/carlosframework/platform/internal/moves 21.830s
ok github.com/carlosframework/platform/internal/moves/archive 0.978s
ok github.com/carlosframework/platform/internal/objstore 0.291s
ok github.com/carlosframework/platform/internal/ops 0.187s
ok github.com/carlosframework/platform/internal/park 0.267s
ok github.com/carlosframework/platform/internal/plans 0.006s
ok github.com/carlosframework/platform/internal/privatefile 0.005s
ok github.com/carlosframework/platform/internal/provision 20.789s
ok github.com/carlosframework/platform/internal/publicrelease 0.014s
? github.com/carlosframework/platform/internal/regionname [no test files]
ok github.com/carlosframework/platform/internal/registry 5.610s
ok github.com/carlosframework/platform/internal/relay 7.226s
ok github.com/carlosframework/platform/internal/release 25.186s
ok github.com/carlosframework/platform/internal/rollout 3.786s
ok github.com/carlosframework/platform/internal/rolloutwords 0.004s
ok github.com/carlosframework/platform/internal/rootaws 0.007s
ok github.com/carlosframework/platform/internal/rootparticipation 0.059s
ok github.com/carlosframework/platform/internal/rootstate 0.027s
ok github.com/carlosframework/platform/internal/runs 0.593s
ok github.com/carlosframework/platform/internal/s3compat 0.005s
ok github.com/carlosframework/platform/internal/safefile 0.005s
ok github.com/carlosframework/platform/internal/schedule 2.725s
ok github.com/carlosframework/platform/internal/seeds 0.015s
ok github.com/carlosframework/platform/internal/sim/hostlife 10.834s
ok github.com/carlosframework/platform/internal/sim/litestreamfacts 3.700s
ok github.com/carlosframework/platform/internal/status 0.082s
ok github.com/carlosframework/platform/internal/steering 0.007s
ok github.com/carlosframework/platform/internal/stopevidence 0.067s
ok github.com/carlosframework/platform/internal/svcrole 0.002s
ok github.com/carlosframework/platform/internal/telemetry 0.004s
ok github.com/carlosframework/platform/internal/termfence 0.005s
ok github.com/carlosframework/platform/internal/tunnelclient 0.004s
ok github.com/carlosframework/platform/internal/unixdial 0.005s
ok github.com/carlosframework/platform/internal/updatewords 0.005s
ok github.com/carlosframework/platform/internal/usage 0.006s
ok github.com/carlosframework/platform/internal/version 0.003s
ok github.com/carlosframework/platform/internal/vet 1.683s
=== internal_console@0 (208 s)
ok github.com/carlosframework/platform/internal/console 207.209s
=== internal_console@1 (37 s)
ok github.com/carlosframework/platform/internal/console 35.510s
=== internal_console@2 (32 s)
ok github.com/carlosframework/platform/internal/console 31.207s
=== internal_console@3 (35 s)
ok github.com/carlosframework/platform/internal/console 34.048s
=== internal_console@4 (34 s)
ok github.com/carlosframework/platform/internal/console 33.299s
=== internal_console@5 (35 s)
ok github.com/carlosframework/platform/internal/console 33.913s
=== internal_console@6 (40 s)
ok github.com/carlosframework/platform/internal/console 38.316s
=== internal_console@7 (40 s)
ok github.com/carlosframework/platform/internal/console 38.829s
=== root@0 (33 s)
ok github.com/carlosframework/platform 31.508s
=== root@1 (44 s)
ok github.com/carlosframework/platform 42.597s
=== root@2 (41 s)
ok github.com/carlosframework/platform 40.099s
=== cross ===
--- shard 0 of 5 ---
cross-compiling darwin/arm64
--- shard 1 of 5 ---
cross-compiling darwin/amd64
--- shard 2 of 5 ---
cross-compiling linux/arm64
linux/arm64 carlos binary: 49938594 bytes (ceiling 52000000)
--- shard 3 of 5 ---
cross-compiling windows/amd64
--- shard 4 of 5 ---
cross-compiling windows/arm64
=== minio-contract ===
minio contract: arm64, minio RELEASE.2025-09-07T16-13-09Z, mc RELEASE.2025-08-13T08-35-41Z
minio: cached, digest verified
mc: cached, digest verified
minio healthy on 127.0.0.1:20999
Added `local` successfully.
Bucket created successfully `local/contract-bucket`.
Bucket created successfully `local/denied-bucket`.
Created policy `contract-only` successfully.
Added user `scopeduser` successfully.
Attached Policies: [contract-only]
To User: scopeduser
buckets and scoped user ready
=== RUN TestDeliveredContractMinio
=== RUN TestDeliveredContractMinio/put
=== RUN TestDeliveredContractMinio/get_round-trips_the_body
=== RUN TestDeliveredContractMinio/list_shows_the_key
=== RUN TestDeliveredContractMinio/head_and_list_agree_on_the_version
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_its_own_object
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/not_by_PutObjectTagging
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/and_not_by_x-amz-tagging_on_upload
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CreateMultipartUpload
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CopyObject_with_a_REPLACE_tagging_directive
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/but_multipart_itself_is_allowed
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_copy_itself_is_allowed
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/a_POST-policy_forged_tag_with_a_matching_version_is_still_not_a_verdict
=== RUN TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_an_ordinary_tagged-with-something-else_upload_is_allowed
=== RUN TestDeliveredContractMinio/delete_removes_it
=== RUN TestDeliveredContractMinio/cross-bucket_denial
--- PASS: TestDeliveredContractMinio (0.02s)
--- PASS: TestDeliveredContractMinio/put (0.00s)
--- PASS: TestDeliveredContractMinio/get_round-trips_the_body (0.00s)
--- PASS: TestDeliveredContractMinio/list_shows_the_key (0.00s)
--- PASS: TestDeliveredContractMinio/head_and_list_agree_on_the_version (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/not_by_PutObjectTagging (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_its_own_object/and_not_by_x-amz-tagging_on_upload (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route (0.01s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CreateMultipartUpload (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/not_by_CopyObject_with_a_REPLACE_tagging_directive (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/but_multipart_itself_is_allowed (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_copy_itself_is_allowed (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/a_POST-policy_forged_tag_with_a_matching_version_is_still_not_a_verdict (0.00s)
--- PASS: TestDeliveredContractMinio/the_app_cannot_tag_by_any_other_route/and_an_ordinary_tagged-with-something-else_upload_is_allowed (0.00s)
--- PASS: TestDeliveredContractMinio/delete_removes_it (0.00s)
--- PASS: TestDeliveredContractMinio/cross-bucket_denial (0.00s)
PASS
ok github.com/carlosframework/platform/internal/objstore 0.023s
=== RUN TestT4StorageProbeMinio
2026/10/21 17:56:58 moves: T4: STORE: list: operation error S3: ListObjectsV2, https response error StatusCode: 403, RequestID: 18E09D2176A9C9F3, HostID: 7c420053e0fbcd7f41653fdd92ffa2802c903d05303b1aa15adc2e8bb65d183f, api error SignatureDoesNotMatch: The request signature we calculated does not match the signature you provided. Check your key and signing method.
--- PASS: TestT4StorageProbeMinio (0.01s)
PASS
ok github.com/carlosframework/platform/internal/host 0.022s
minio contract: PASS
diff --git a/docs/superpowers/specs/CODEX-REVIEW-BRIEF-PLANS-2-CODE.md b/docs/superpowers/specs/CODEX-REVIEW-BRIEF-PLANS-2-CODE.md| new file mode 100644 |
| index 000000000..da1a28407 |
| --- /dev/null |
| +++ b/docs/superpowers/specs/CODEX-REVIEW-BRIEF-PLANS-2-CODE.md |
| @@ -0,0 +1,42 @@ |
| +# Whole-branch code review brief: Plans 2 (boxes read account limits) |
| + |
| +You are a senior Go reviewer on the carlos platform. Review branch |
| +`plans-2-box-limits`, range `4a1e4b29a7196a2a0acb505cd4f8a3dcea054ad0..HEAD` (`git diff 4a1e4b29a7196a2a0acb505cd4f8a3dcea054ad0..HEAD`; the |
| +docs under docs/superpowers/ are requirements, not code to review). The |
| +review is read-only: do not modify the working tree, index, HEAD or |
| +branches. You may run `go test` for packages you want to probe (set |
| +GOFLAGS=-buildvcs=false). |
| + |
| +Requirements, in order of authority: |
| +1. Spec: docs/superpowers/specs/2026-10-20-plans-caps-packs-design.md |
| + (§5.2 idle window, §7 limits reach the boxes and fail open, §10). Its |
| + section 3 decisions are not to be argued with. |
| +2. Plan: docs/superpowers/plans/2026-10-21-plans-2-box-limits.md, especially |
| + "Self-hosters": Paul's requirement that deployments without a plan |
| + catalog are never interrupted. |
| +3. Executor rulings: `.superpowers/sdd/2026-10-21-plans-2-box-limits/progress.md`, |
| + lines containing `Ruling:`. Weigh each. |
| + |
| +The spec is a vision document. For behaviour it is silent on, judge by what a |
| +reasonable operator, self-hoster or customer would expect, and grade by effect. |
| + |
| +Check these deliberately (the plan's Review Focus): |
| +1. Plans off (marker absent): exactly one bucket read per pass, no limits. |
| +2. CARLOS_PLAN_LIMITS=off: zero bucket reads, cache cleared. |
| +3. Bucket blips: marker read error keeps the whole cache; a per-account |
| + error keeps that account's last value. |
| +4. Plans turned off again: marker disabled clears the cache; windows revert. |
| +5. A plan idle longer than the box default: the box default stands. |
| + |
| +Also look hard at: any path where a self-hosted box (no catalog ever) changes |
| +behaviour or cost; the activator sweep change (always-on workers, held-for-tick, |
| +probe entries, sidecar workers); races on the package-level cache and the |
| +atomic hook; the console marker publisher (once per start, disable path, |
| +CAS); SetAccountPlan's live-account guard SQL; the hostops and storedoor |
| +entries for control/plans.json; the census overlay rows' honesty; and |
| +darwin/windows builds. |
| + |
| +Output: findings most severe first, each Critical / Important / Minor with |
| +file:line, the concrete failure scenario and a suggested fix; then "Declined |
| +to judge" (every behaviour set aside, one line each with the reason); then a |
| +verdict: ready to merge, ready with fixes, or not ready. |